|
Welcome the channel on the development of Cro, a set of libraries for building reactive distributed systems, lovingly crafted to take advantage of all the Raku Programming Language has to offer (cro.services). This channel is being logged for historical purposes. Set by lizmat on 24 May 2021. |
|||
| japhb | jnthnwrthngtn: Is there a reason not to merge vendethiel's github.com/croservices/cro-websocket/pull/32 ? | 20:26 | |
|
22:47
Altai-man left,
Altai-man joined
|
|||
| japhb | This looks like a typo to me: github.com/croservices/cro-websock...er.pm6#L72 | 23:22 | |
| Shouldn't that be `$so.break($_);` (replacing $m with $so in that line)? | |||
| Also, why does keeping the serialization outcome happen *before* the emit here: github.com/croservices/cro-websock...er.pm6#L24 but happens *after* the emit in the following LAST block? | 23:54 | ||
| Shouldn't those both be after, in order to ensure the serialization outcome promise is not kept until all the stages of the serialization pipeline have succeeded? (Or if not, that the QUIT or CATCH blocks have triggered?) | 23:55 | ||
| Granted that this change might reduce concurrency a bit, since the SO is awaited at github.com/croservices/cro-websock...n.pm6#L127 | 23:57 | ||
| I guess whatever order is chosen, it should be the *same* order in MessageSerializer | |||