| timotimo | tbh i had hoped for a bit of praise :P | 02:01 | |
|
02:14
Ven joined
|
|||
| brokenchicken | W00t! Amazing! timotimo++ Job well done! | 02:40 | |
|
02:48
ilbot3 joined
03:31
Ven joined
|
|||
| samcv | timotimo, sorry good work :) | 04:05 | |
| working on getting them generating without any 'gaps' | |||
| i had surgury a few days ago which is why i was afk for a long while, so still not totally with it | 04:06 | ||
|
04:07
Ven joined
|
|||
| samcv | as of this change we won't have any 0 value base 40 numbers either :) (though one at the end of everything is possible) | 04:10 | |
|
04:15
Ven joined
|
|||
| samcv | nice 470K => 402K | 04:18 | |
|
04:23
Ven_ joined
|
|||
| samcv | timotimo, names.c now works with removing one line. look me a bit to figure out how it worked, but here's the change github.com/samcv/UCD/commit/20c96e...492272ff27 | 05:40 | |
|
06:10
Ven joined
07:13
Ven joined
07:37
Ven joined
07:59
FROGGS joined
09:05
domidumont joined
09:10
domidumont joined
|
|||
| Geth | arVM: 7f591ea159 | (Daniel Green)++ | 12 files Change tabs to spaces To be consistent with the rest of the source. |
09:18 | |
| arVM: 76872dbe71 | (Jimmy Zhuo)++ | 12 files Merge pull request #510 from MasterDuke17/change_tabs_to_spaces Change tabs to spaces |
|||
|
09:27
domidumont joined
09:29
domidumont joined
|
|||
| timotimo | ah, that line could have done with a comment like "flush the queue" | 12:22 | |
| mst | so ... add such a comment? | 13:47 | |
| timotimo | well, samcv already understands what's going on in that line | 13:48 | |
| i don't expect that code to last much longer | |||
| though i guess for historical reasons it'd be interesting? | |||
| mst | even if you expect the code to be nuked, it's probably still worth it since (a) code often lasts longer than expected (b) people looking at the new code will likely look at the last release containing the old code to compare | 14:08 | |
| (c) basically it can't hurt | |||
|
14:23
zakharyas joined
14:40
geekosaur joined
|
|||
| MasterDuke | is there a way to silence/fix the remaining two warnings (`implicit declaration of function ‘pthread_yield’`) when building moar? | 14:49 | |
| jnthn | MasterDuke: Probably, but iirc the last attempt somebody made at fixing tht totally broke the build on some platform. | 14:56 | |
| MasterDuke | ah, then i'm just going to keep on ignoring them | 14:59 | |
| jnthn | Yeah, that's what I've done too ;) | 15:00 | |
| dogbert17 | jnthn: are you around? | 16:03 | |
| have a gist (wrt MoarVM Issue #234) that possibly might be of interest: gist.github.com/dogbert17/b9f7edee...bee21ff4f6 | 16:04 | ||
| nwc10 | according to the wisdom of the internet the correct fix is to replace pthread_yield() with sched_yield() | 16:10 | |
| samcv | timotimo, not sure if this was the off by one error you were seeing, but with the latest changes: gist.github.com/4e54b6566d95336961...74d7e8de19 | 16:19 | |
| oh just fixed the off by one. it's lined up properly now. wasn't a problem with the c code at all | 16:28 | ||
|
16:31
domidumont joined
|
|||
| timotimo | yes, i fixed it in the p6 code | 16:33 | |
| the off-by-one was what made MARTIAL ARTS UNIFORM b0rk, and i pointed out in the pr comments that i fixed it | 16:34 | ||
| jnthn | dogbert17: Seems to give a hint of what's going on, at least | 16:37 | |
| nwc10: (sched_yield) that sounds...familiar :) | 16:38 | ||
| dogbert17 | jnthn: made the loop smaller so that the (Too many open files) shouldn't have anything to do with it | 16:40 | |
| and 32k nursery | |||
| jnthn | Ah, here's the history: github.com/MoarVM/MoarVM/commit/01...e9b9f7f85b | 16:43 | |
| So, switching to sched_yield was not the thing we tried | |||
| So, we can try that :) | |||
| timotimo | why don't we just #ifndef that? :) | 16:44 | |
| or are there platforms that pthread_yield with an argument? | |||
| geekosaur | more likely platforms that have it return (void) | 16:45 | |
| timotimo | we don't care about the return value anywhere in the code, i don't think | 16:49 | |
| so just defining it to be void(void) should be fine | |||
| geekosaur | the point is, on platforms that *do* have it defined, your redefinition must match | 16:50 | |
| or you will get a compile error | |||
| timotimo | no | ||
| i already said we #ifnde it | |||
| geekosaur | and the define you use is? | ||
| (if you are already checking for a valid prototype then it should have been conditional already. if you weren't, there is no preprocessor symbol you can use to test for it) | 16:51 | ||
| timotimo | ...? | 16:53 | |
| #ifndef pthread_yield void pthread_yield(void); #endif | 16:54 | ||
| geekosaur | you arer confusing macros with functions | ||
| timotimo | are you sure you can't #ifndef a symbol? | 16:55 | |
| geekosaur | a C function symbol? yes | 16:56 | |
| it is not a preprocessor macro | |||
| it is not considered defined by the preprocessor | |||
| timotimo | oh! | ||
| i was under the impression that you could do that, and even #undef things | |||
| geekosaur | only if it's a macro | ||
| some things are, many are not | |||
| timotimo | got to go! :) | 16:57 | |
|
20:45
ggoebel joined
21:23
ggoebel joined
|
|||