| samcv | please tell spesh not to be a meanie | 00:07 | |
| TimToady | spesh: don't be a meanie! | 00:09 | |
| Geth | MoarVM: 4bc916e2ba | (Samantha McVey)++ | src/strings/normalize.c Fix mixed declarations and code from ccc() Was causing a compilation error for some configs. |
00:10 | |
| samcv | ok dogbert17 looks like 2.11.91 they changed the format | 00:27 | |
| so i'll need to alter my plugin | |||
| er module | |||
|
00:30
travis-ci joined
|
|||
| travis-ci | MoarVM build passed. Samantha McVey 'Fix mixed declarations and code from ccc() | 00:30 | |
| travis-ci.org/MoarVM/MoarVM/builds/251358389 github.com/MoarVM/MoarVM/compare/e...c916e2ba62 | |||
|
00:30
travis-ci left
03:02
TimToady joined
|
|||
| samcv | jnthn, i found a problem in our handling of Hangul I believe | 05:43 | |
| err wait nvm | 05:46 | ||
| misread something for a sec | 05:47 | ||
|
08:01
domidumont joined
08:07
domidumont joined
08:16
FROGGS joined
|
|||
| FROGGS | o/ | 08:16 | |
| timotimo | o/ FROGGS | 08:19 | |
| FROGGS | hi timotimo | ||
| Geth | MoarVM: 6011f876db | (Stefan Seifert)++ | 2 files Improved debug output for serialization errors |
09:40 | |
| nine | 12/win 10 | 11:31 | |
| lizmat | no lottery ? | 11:34 | |
| nine | Nah, only leading spaces make it into the lottery | 11:37 | |
| jnthn | .oO( Don't leave me hanguling... ) |
12:06 | |
| nine | Lesson of the day: NULL debug_name makes debugging hellish | 12:08 | |
| jnthn | Back in the day we didn't have that at all and coped ;) | 12:09 | |
| But yeah, it's very useful :) | |||
| I suspect only a handful of things don't set it | |||
| It needs doing explicitly after newtype | |||
| So you can probably grep for those places with context | |||
| To figure where we forgot it | 12:10 | ||
| nine | Ah I already know it's DefiniteHOW :) I just didn't know how debug_name is set at all | 12:11 | |
| jnthn | There's an op for setting it | 12:12 | |
| Meta-objects set it on new types they make | |||
| nine | But according to the comments, we avoid a meta-object instance per coercion type, which may be the reason for not setting a debug_name | 12:15 | |
| jnthn | Avoid a meta-object instance yes, but maybe do have an STable per coercion type | 12:16 | |
| Yes, we must | 12:17 | ||
| 'cus we have distinct type objects | 12:18 | ||
| nine | Where would such an STable be created? | ||
| jnthn | github.com/rakudo/rakudo/blob/nom/...OW.nqp#L62 | ||
| That's where we'd set the debug name also | |||
| It's created as part of the parameterization process | 12:19 | ||
| nine | debug_name = 0x3811160 "?:?:D" | 12:26 | |
| Talk about Perl being cryptic :) | |||
| jnthn | I...suspect we could do better than that :P | 12:32 | |
| (I think since we get passed the parameters, which are the types, we can call .HOE.name on each of them | 12:39 | ||
| uh. .HOW | |||
| This ain't a meta-shed... | |||
| nine | Ah, I tried it on $type, which is probably the type currently in creation and thus not yet ready to be queried for its name | 12:40 | |
| STable Mu:U does not exist in serialization context | 12:43 | ||
| I juts setdebugtypename in method new_type like in ClassHOW | 12:45 | ||
| jnthn | I'd expect it to make the name something like $params[0].HOW.name($params[0]) ~ '(' ~ $params[1].HOW.name($params[1]) ~ ')' or so | 12:46 | |
| $type is what you're setting the debug name for | 12:47 | ||
| nine | Both work. nqp::setdebugtypename($root, self.name($root)); in new_type and nqp::setdebugtypename($thing, $params[0].HOW.name($params[0]) ~ ($params[1] ?? ':D' !! ':U')); in the setparameterizer sub | 12:48 | |
| I like the first better for obvious reasons :) | |||
| That will work in CoercionHOW, too, though I lack a test case for verification | 12:49 | ||
| jnthn | Oh wait, we were looking at different meta-objects | 12:50 | |
| hah | |||
| Shows how awake I am today | 12:51 | ||
| nine | Well, now that I see that it's about Mu:U, I at least know that something's seriously b0rked ;) With that I will move on to re-potting plants. It's too hot for anything else anyway :) | 12:54 | |
| jnthn: thanks for the explanations :) At least this way I was able to make a bit of progress. | |||
| jnthn | heat-- | 12:55 | |
| timotimo | it's too hot to be doing manual labour like re-potting plants :o | ||
|
12:57
domidumont joined
15:08
AlexDaniel joined
|
|||
| nine | timotimo: plants are in my office. Office has AC :) Though the AC had quite some work to do to keep up while at home it's quite bearable without any AC at all. Insulation++, (being able to open all windows at night)++ | 15:54 | |
| timotimo | wow | ||
| nine | In summer we follow a very strict "keep everything open exactly as long as its cooler outside than inside" policy. With that we managed to keep top temperatures at 26 degrees inside during a 2 week heat wave the year before last | 15:56 | |
| timotimo | we don't have good measurement tools on hand to implement such a policy | 15:57 | |
| mst | I mostly open all the windows and rely on the breeze | 16:17 | |
| timotimo | the breeze is like 33 degC at the moment :| | ||
| AlexDaniel | it's actually pretty hot here today | 16:19 | |
| 19°C | |||
| :| | |||
| but that's probably better than all days of June, so… :( | 16:20 | ||
| MasterDuke | screenshot of the flamegraph view in hotspot (after running the example from jnthn's blog post about reading a 1million line file): i.imgur.com/pfgXGI7.png | 16:49 | |
| timotimo | wow, that frame_try_return | 16:54 | |
| MasterDuke | any way to make it cheaper? | 17:03 | |
| timotimo | yeah, inline everything | 17:14 | |
| jnthn | Much of the work seems in remove_one_frame. | 17:16 | |
| One further note - spesh currently runs at frame exit | |||
| So the spesh work will probably come under that too | |||
| timotimo | i see | ||
| jnthn | Also that graph seems a tad...confused? | ||
| Why isn't everything under main? | 17:17 | ||
| I'm guessing 'cus the JIT confuses it | |||
| timotimo | oh, that's possible | 17:40 | |
| the jit really is confusing | |||
|
20:02
committable6 joined,
greppable6 joined
20:04
committable6 joined
20:12
greppable6 joined
|
|||
| samcv | o/ hi all | 20:53 | |
|
21:26
vendethiel joined
21:55
stmuk joined
22:00
stmuk_ joined
|
|||
| dogbert17 | hello samcv | 22:12 | |
| samcv | hey :) | 22:13 | |
| dogbert17 | if you pull the latest rakudo changes your font prg will work without MVM_SPESH_DISABLE | ||
| Geth | MoarVM: 20812a0ba4 | (Samantha McVey)++ | 2 files Rename is_control_beyond_latin1 to is_control_full More accurately describes the function, as it also works for codepoints in the Latin-1 range. Also reorder the latin1 range check to make the range more visible. |
22:14 | |
| MoarVM: 48371396f3 | (Samantha McVey)++ | src/strings/normalize.c Work Hangul grapheme seg into GCB switches This simplifies the code in should_break() and we are able to use the same switches we use for all the other properties. This mostly has the same functionality except it is more strictly in line with Unicode's spec. by going off property and not assuming everything returning true from maybe_hangul() is Hangul. |
|||
| samcv | dogbert17, :) | 22:29 | |
| yay! | |||
| dogbert17, well it works for much longer | 22:31 | ||
| i still got a segfault eventually though | |||
| gonna time it. before it took 5.2 seconds. took way longer this time | |||
| oh rakudo. my bad i pulled Moar :p | 22:32 | ||
| dogbert17 | :) | 22:33 | |
| perhaps an ENOOCOFFEE error :-) | |||
| samcv | :-) | ||
|
22:36
unicodable6 joined,
bisectable6 joined,
evalable6 joined,
greppable6 joined,
committable6 joined,
bloatable6 joined,
quotable6 joined,
coverable6 joined,
benchable6 joined,
statisfiable6 joined
|
|||
| samcv | yay now it works! | 22:38 | |
| dogbert17 | :) | ||
| samcv: do you know if we have tests for RT #127047 (it has been working for some time, see github.com/rakudo/rakudo/commit/7c...0246afcf0) | 22:50 | ||
| synopsebot6 | Link: rt.perl.org/rt3/Public/Bug/Display...?id=127047 | ||
| samcv | yeah we do | ||
| dogbert17 | then we can close it :) | ||
| samcv | we have a whole emoji test file that contains all of the Emoji v4.0 | ||
| xwell | |||
| we don't pass all tests | 22:51 | ||
| dogbert17 | nooooo :) | ||
| samcv | but i think we do pass the ones they list there | ||
| yeah we do | |||
| but there's others not yet passing sadly | 22:52 | ||
| need to figure out how to do that.. ugh | |||
| dogbert17 | I have to click on reply or comment in order to change status on an issue | 22:53 | |
| samcv | i'll comment on it. | 22:54 | |
| dogbert17 | with some luck you'll see a 'status' listbox at the top | 22:55 | |
| MasterDuke | dogbert17: you don't have an 'Actions' link/menu in the upper right? | ||
| dogbert17 | no | 22:56 | |
| MasterDuke: are the bots working better now? | |||
| MasterDuke | AlexDaniel just built a new rakudo to run them, and they've been restarted, but i don't know if they've been tested | 22:57 | |
| dogbert17: might want to ask [Coke] or Zoffix about that, i thought you were given ticket management permissions in RT | 22:59 | ||
| dogbert17 | well, I can manage them if I go to them directly and use comment or reply | 23:01 | |
| probably not the optimal solution though :) | |||
| samcv | jk closing the issue :) | 23:02 | |
| because of semi arbitrary reasons. and counting the ZWJ sequences different from the non ZWJ sequences. and we pass all the non zwj ones | 23:03 | ||
| well. | |||
| except the rainbow flag. let me see what that is | |||
| ZWJ. ok so i'm right | |||
| dogbert17 | cool, any comments on the next one, i.e. T #127048 | ||
| synopsebot6 | Link: rt.perl.org/rt3/Public/Bug/Display...?id=127048 | ||
| samcv | :( makes me sad. i need to make it save state and come up with ways to know i'm in an emoji sequence. and stuff | 23:04 | |
| frustrating that the unicode rules are not very good for the ones we are not passing | |||
| dogbert17 | :( | 23:05 | |
| samcv | jk. what. did i just | 23:09 | |
| solve the 240 emoji that were failing | |||
| and now i fail graphemeclusterbreak tests tho | 23:10 | ||
| eeeh | 23:11 | ||
| AlexDaniel | dogbert17: yes | 23:17 | |
| dogbert17: the whole test suite just passed without any segfaults | |||
| MasterDuke: in the end we still bisected it with bisectable :D | 23:18 | ||
| samcv | maybe i'll try updating to unicode 10 and maybe hope they changed the properties for some emoji to be not crap | 23:20 | |
| i was able to get them all passing AlexDaniel all emoji getting the right number of chars. 100% | 23:32 | ||
| and not making any more GCB.t tests failing! | 23:33 | ||
| awesome. | |||
| AlexDaniel | \o/ | ||
| samcv | i did something i'd never though of. well i had. but thought it was too crazy to ever work | 23:34 | |
| having it so we don't break if it's ZWJ + (Emoji=True && GCB=Other) | 23:35 | ||
| though it might make sense to whitelist specific codepoints to avoid it causing numbers to bind to zwj. since zwj should probably not bind that way. well it should bind to the cp on the left and then only to the one on the right in specific circumstances | 23:37 | ||
| though there's not really any *real* cases where someone would do that. so that's more technicality | 23:38 | ||
