01:30
bisectable6 joined
01:51
Ven joined
|
|||
timotimo | lemire.me/blog/2017/11/16/fast-exa...perations/ and github.com/ridiculousfish/libdivide | 02:24 | |
i'm not sure how often we have a division by a known integer number, but maybe we can teach the jit a few division fastpaths? | |||
well, step one is surely to turn some divisions into bit shifts | 02:25 | ||
02:56
ilbot3 joined
08:21
domidumont joined
08:26
domidumont joined
08:56
robertle joined
10:15
evalable6 joined,
nativecallable6 joined,
quotable6 joined,
tangible6 joined,
releasable6 joined,
unicodable6 joined,
bloatable6 joined,
benchable6 joined,
committable6 joined,
greppable6 joined,
coverable6 joined,
squashable6 joined,
bisectable6 joined,
statisfiable6 joined
10:20
lizmat joined
11:02
Ven joined
11:04
lizmat joined
|
|||
nine | Yet another observation: it's probably not a terribly good idea to delete the only instruction of a basic block. This may be a reason why keeping a no_op instead helps (though not the only one). | 12:07 | |
12:40
nebuchadnezzar joined
12:42
lizmat joined
|
|||
dogbert17 | I guess that tests which fail when using MVM_SPESH_NODELAY=1 MVM_SPESH_BLOCKING=1 can't be considered as blockers | 13:22 | |
jnthn | No, if they were we'd not have had a release for a couple of years. :P There's a *lot* less of them now than there were before, though. | ||
And most, last I checked, are thanks to stack traces losing frames when inlines happen | 13:23 | ||
dogbert17 | indeed, it's hard work finding them :P | ||
jnthn | That's fixable, just a bit tedious | ||
dogbert17 | in this case it was in t/spec/S09-typed-arrays/native-num.t | 13:24 | |
test #247, 'Cannot resolve caller is-approx(Str, Str); none of these signatures match:' | |||
btw, what about brrt's fix from yesterday, will that be included in the release? | 13:26 | ||
jnthn | We can cherry-pick it I guess | 13:27 | |
We should not merge that branch though | |||
I don't want my other commit in the releas | |||
*release | |||
Hm, I wonder if it's on me to do the release this time :) | |||
13:30
lizmat joined
|
|||
dogbert17 | at least there aren't any real blockers this month | 13:39 | |
unless AlexDaniel manages to dig one up at the last second | 13:40 | ||
13:57
MasterDuke joined
|
|||
AlexDaniel | yeah, unfortunately toaster didn't manage to finish while I was sleeping, so had to kick it off again | 15:11 | |
but it should be ready soon. Once I see the results I think we'll be good to go | 15:12 | ||
jnthn: I was assuming that it's not, but at the same time I haven't heard from samcv yet | 15:15 | ||
timotimo | AlexDaniel: any +/- on the commit i sneaked in last night? | 15:19 | |
or you jnthn? as this is basically your code? | |||
AlexDaniel | timotimo: I've looked at it, but it's hard for me to predict what problems this could possibly cause | ||
timotimo | if any user code decides to return () from the additional-names method, it'll have exploded before and will explode even with the patch attached | 15:20 | |
applied* | |||
AlexDaniel | greppable6: alternative-names | ||
greppable6 | AlexDaniel, gist.github.com/d47791c04f07a7a629...830cd0e43e | ||
timotimo | it'd be cool to have a little summary to go along with the link, like "two lines matched" and "from only one module: doc" | 15:21 | |
AlexDaniel | github.com/perl6/whateverable/issues/259 | 15:22 | |
unicodable6 already does something similar, should be very easy to implement | |||
unicodable6: infinity | 15:23 | ||
unicodable6 | AlexDaniel, U+1AB2 COMBINING INFINITY [Mn] ( ᪲) | ||
AlexDaniel, U+221E INFINITY [Sm] (∞) | |||
AlexDaniel, 5 characters in total: gist.github.com/f074033df8c67bd23a...926cb17928 | |||
AlexDaniel | well… it doesn't show all of the characters if there are some weird ones :) | ||
timotimo | fair enough | ||
AlexDaniel | timotimo: I think your commit is OK. Thanks for notifying | 15:25 | |
timotimo | oh, a quick coverage run tells me the register function is not run during actual startup | 15:26 | |
15:35
zakharyas joined
15:39
zakharyas joined
16:01
MasterDuke joined
16:08
zakharyas1 joined
|
|||
AlexDaniel | speaking of blockers :) github.com/rakudo/rakudo/issues/1254 | 18:11 | |
.tell samcv you're probably interested in github.com/rakudo/rakudo/issues/1254 | |||
yoleaux | AlexDaniel: I'll pass your message to samcv. | ||
18:11
domidumont joined
|
|||
AlexDaniel | I guess this is the offending commit: github.com/MoarVM/MoarVM/commit/e76788819 | 18:12 | |
jnthn | Ah, there be blockers | 18:31 | |
AlexDaniel | unfortunately I had a busy week and couldn't get my hands on it earlier, sorry for that :) | 18:32 | |
jnthn | No worries, I was just thinking "oh man, I should make dinner but I should maybe work on cutting the release". Now the latter ain't an option anyway. ;) | 18:33 | |
With luck, samcv++ might have chance to comment/look at that. I fnot I guess we can always revert it, but I dunno if other stuff depends on it... | 18:44 | ||
*If not | 18:45 | ||
I'll have a bit of time for release tonight, or could do it tomorrow also | |||
AlexDaniel | I think tomorrow is a more realistic bet | 18:49 | |
ugexe | i'm not sure what will happen with github.com/libuv/libuv/issues/1625 - since node already made a release with the regression they might not revert | 18:50 | |
AlexDaniel | ugexe: oh… I have not seen that | 18:51 | |
ugexe: so, does it mean that we should revert 8b53b1e for now? | 18:55 | ||
Well, that's exactly what you said, but do you still think so? :) | |||
18:56
evalable6 joined
|
|||
AlexDaniel | fwiw I think it's much better to file tickets like this: github.com/rakudo/rakudo/issues/1255 | 19:08 | |
(instead of hoping that I'll find a comment in a pull request that points to a bug report in a different repo, for an issue that we probably want to handle before the release) | 19:09 | ||
samcv | good * everyone | 19:33 | |
yoleaux | 18:11Z <AlexDaniel> samcv: you're probably interested in github.com/rakudo/rakudo/issues/1254 | ||
samcv | that is a weird issue | 19:34 | |
time to add another roast test | |||
AlexDaniel: it's still passing roast right | 19:35 | ||
AlexDaniel | yeah | ||
samcv | never seen this before | ||
AlexDaniel | do I agree that it is weird, the case seems so down to earth that it's really surprising there was no test or something | ||
and only *one* ecosystem module is failing because of this | 19:36 | ||
samcv | Cn is unassigned. and i fixed unassigned characters but i would have think that it would have been caught hm. maybe we need tests for every single general category | ||
i just woke up. will look at it in 30 mins or so | |||
AlexDaniel | samcv: it's alright, take your time | 19:37 | |
samcv: by the way, is it you making the release this time or jnthn? | |||
samcv | i can do the MoarVM release again yeah | ||
AlexDaniel | (some context: irclog.perlgeek.de/moarvm/2017-11-18#i_15466864 ) | 19:38 | |
jnthn: objections? :) | 19:40 | ||
samcv | AlexDaniel: the reason i think ascii letters must come up Cn is that they have no bitfield row | 19:47 | |
but not 100% sure yet | 19:48 | ||
oh looks like non ascii also show Lu. argh | 19:51 | ||
AlexDaniel | yeah I didn't test much | 19:53 | |
samcv: fwiw Unicode::PRECIS is the module that has failing tests because of this | 19:54 | ||
samcv | this is really weird | 19:56 | |
ok so Cn is the default value as it should be. (index 0) and Ll is index 1 | |||
but lowercase letters work but not uppercase | |||
oh wow. cause "Lu" is totally missing… that's not good | 19:57 | ||
AlexDaniel | u: X | 20:02 | |
unicodable6 | AlexDaniel, U+0021 EXCLAMATION MARK [Po] (!) | ||
AlexDaniel, U+0036 DIGIT SIX [Nd] (6) | |||
AlexDaniel | waaat… | ||
unicodable6 | AlexDaniel, 1733 characters in total: gist.github.com/6dbffcb19ef6975b15...9ded3afa36 | ||
AlexDaniel | u: aX | 20:03 | |
20:03
domidumont joined
|
|||
unicodable6 | AlexDaniel, U+2F44 KANGXI RADICAL AXE [So] (⽄) | 20:03 | |
AlexDaniel, U+A009 YI SYLLABLE AX [Lo] (ꀉ) | |||
AlexDaniel, 56 characters in total: gist.github.com/fe5b9e2c8041045910...328b71ca66 | |||
AlexDaniel | u: ∞X | ||
unicodable6 | AlexDaniel, U+221E INFINITY [Sm] (∞) | ||
AlexDaniel, U+0058 LATIN CAPITAL LETTER X [Lu] (X) | |||
AlexDaniel | I guess unicodable is using some older version | ||
unicodable6: uptime | |||
unicodable6 | AlexDaniel, 9 hours, 48 minutes, and 44 seconds, 343.48KB maxrss. This is Rakudo version 2017.10-8-g6ac53e427 built on MoarVM version 2017.10 implementing Perl 6.c. | ||
AlexDaniel | yeah | ||
20:27
zakharyas joined
|
|||
jnthn | samcv++ | 20:29 | |
samcv: If you're up for doing the release, that'd be really nice :) | 20:30 | ||
AlexDaniel | jnthn: what are your thoughts on github.com/rakudo/rakudo/issues/1255 ? | 20:31 | |
jnthn | iiuc, we already shipped 2017.10 with that bump in place | 20:32 | |
AlexDaniel | oh… right. | ||
AlexDaniel completely missed that | |||
samcv | well i think i found what's happening. well not exactly but sort of | 20:33 | |
jnthn | oh, wait, that may not be the csae | ||
*case | |||
github.com/MoarVM/MoarVM/pull/719 | |||
It was filed longer ago, then merged 21 days ago, so it wasn't in 2017.10 | |||
samcv | i see $points_by_hex->{0041} ( for 'A') being set and can print it out. but then lower down it is undefined and i'm not sure why | ||
AlexDaniel | I see, that's an old commit but merged recently. | 20:34 | |
jnthn: so it's probably reasonable to revert it for now? | |||
jnthn | Was filed on 8th Oct, on 10th Oct I said OK to merge after upcoming release, which woulda been 2017.10 | ||
I think so, yes. This effectively means we are blocked from any libuv bumps until this issues is fixed upstream. | 20:35 | ||
AlexDaniel | or we find a workaround, but that's ok | ||
jnthn | Or that, yeah | ||
But given there's a good chance it impacts more than just us... | 20:36 | ||
jnthn checks the libuv ticket | |||
AlexDaniel | nobody complained so far | ||
at least according to that ticket | |||
japhb | AlexDaniel: I think unicodable6 is off in its units for memory use. I suspect it's supposed to be MB, not KB. | ||
(or maybe MiB) | |||
AlexDaniel | japhb: yes, it is. But it is also using nqp::getrusage when it should be using something else (whatever we have now available) | 20:37 | |
japhb | Telemetry, IIRC | ||
jnthn | I think lizmat discovered that the units getrusage returns aren't consistent across platforms | 20:38 | |
And may well have worked around that in Telemetry | |||
AlexDaniel: I'm going to merge the revert from ugexe++ | |||
Geth | MoarVM: 17cbb59876 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files Revert "Use uv_fs_copyfile API" |
||
MoarVM: 79d6f20057 | (Jonathan Worthington)++ (committed using GitHub Web editor) | 2 files Merge pull request #752 from ugexe/revert-719-uv_fs_copyfile Revert "Use uv_fs_copyfile API" |
|||
jnthn | That gives some space to figure it out | ||
AlexDaniel | jnthn: good. Thank you | ||
japhb: github.com/perl6/whateverable/issues/260 | 20:40 | ||
20:43
lizmat joined
|
|||
AlexDaniel | ugexe: so we're good now, right? | 20:44 | |
(with that particular proc issue) | |||
ugexe | yes. i also believe ive just proved the regression exists inside nodejs now too | 20:45 | |
AlexDaniel | ugexe++ | 20:47 | |
lizmat | japhb: what does "say VM.osname" say for you wrt MB vd KB in Telemetry ? | 20:48 | |
perhaps we need more of a heuristic approach to finding out what the unit is | 20:54 | ||
samcv | ok it seems to be assigning Lu and Cn to the same propvalue | 21:02 | |
21:02
zakharyas joined
|
|||
samcv | getting closer to figuring out how to fix this | 21:02 | |
and in doing so decided to nuke the $points_by_hex reference hash. since it's stupid to have $points_by_code AND $points_by_hex | 21:03 | ||
japhb | lizmat: I was noticing unicodable6 doing it in channel, not something on my machine | 21:23 | |
lizmat | japhb: ?? how ? | 21:24 | |
link? | |||
japhb | Hold on a sec | ||
irclog.perlgeek.de/moarvm/2017-11-18#i_15467144 | 21:25 | ||
lizmat | yeah, that looks to be off by a factor of 1024 :-) | 21:26 | |
AlexDaniel | the code is here: github.com/perl6/whateverable/blob...e.pm6#L161 | 21:27 | |
lizmat | unicodable6: help | ||
unicodable6 | lizmat, Just type any unicode character or part of a character name. Alternatively, you can also provide a code snippet. # See wiki for more examples: github.com/perl6/whateverable/wiki/Unicodable | ||
AlexDaniel | but it's pre-telemetry code | ||
lizmat | maybe the problem is in the "KB" :-) | 21:28 | |
AlexDaniel | c: HEAD use Telemetry; say max-rss, ‘ KB’ | 21:29 | |
committable6 | AlexDaniel, ¦HEAD(149ed24): «===SORRY!=== Error while compiling /tmp/w3abLsSZSIUndeclared routine: max-rss used at line 1 «exit code = 1»» | ||
AlexDaniel | c: HEAD use Telemetry; say T<max-rss>, ‘ KB’ | ||
committable6 | AlexDaniel, ¦HEAD(149ed24): «451880 KB» | ||
lizmat | m: use nqp; say nqp::atpos_i(nqp::getrusage,4) # says 69623808 for me | ||
camelia | 76004 | ||
AlexDaniel | c: HEAD use nqp; say nqp::atpos_i(nqp::getrusage,4) | 21:30 | |
committable6 | AlexDaniel, ¦HEAD(149ed24): «451964» | ||
AlexDaniel | yeah, it's ‘KB’ that is a problem :) | ||
lizmat | m: use Telemetry; say T<max-rss> # says 85640 for me | 21:31 | |
camelia | 92964 | ||
ugexe | node -e "const cp = require('child_process'); { const bat = cp.spawn('cmd.exe', ['/k', 'dir'], { stdio: 'inherit', detached: false, windowsHide: true }); }" # here is the proof of libuv regression inside the latest nodejs release, which went undetected by all of: libuv tests, nodejs test matrix / system, rakudo tests, rakudo spectests. | 21:33 | |
AlexDaniel | oh… but to get telemetry I'd need to update rakudo | 21:34 | |
so expect a bot kaboom | 21:35 | ||
mst | ugexe: some bugs just hate everybody at once. | 21:36 | |
21:38
bloatable6 joined,
quotable6 joined,
tangible6 joined,
bisectable6 joined,
committable6 joined,
nativecallable6 joined,
releasable6 joined,
coverable6 joined,
greppable6 joined,
evalable6 joined,
benchable6 joined,
unicodable6 joined,
statisfiable6 joined,
squashable6 joined
|
|||
AlexDaniel | unicodable6: uptime | 21:38 | |
unicodable6 | AlexDaniel, 27 seconds, 213.712MB maxrss. This is Rakudo version 2017.10-214-g14a90e044 built on MoarVM version 2017.10-82-ge876f1484 implementing Perl 6.c. | ||
japhb | lizmat: Ah, so Telemetry auto-corrects the getrusage difference? | ||
AlexDaniel++ | 21:39 | ||
lizmat++ | |||
mst | AlexDaniel: may be worth considering sticking ZNC in front of the bothead code like simcop does with perlbot | ||
lizmat | yes, afaik, only MacOS returns bytes rather than Kbytes | ||
AlexDaniel | mst: yes, absolutely. github.com/perl6/whateverable/issues/261 | 21:40 | |
samcv | i think i've almost fixed it | 21:41 | |
mst | also I strongly suspect he'd be happy to answer questions | ||
jnthn | ugexe++ # bug hunting | 21:44 | |
AlexDaniel | japhb: github.com/perl6/whateverable/commit/e9ccebadca :) | ||
mst | samcv: why are you trying to register perl6 as a group? we did that years ago, just tell me what you need | 21:46 | |
AlexDaniel | mst: I was also thinking about connecting through Matrix, but the current freenode bridge seems to be a bit slow sometimes | ||
samcv | i didn't do anything | ||
japhb | AlexDaniel: is Telemetry correcting to kB or KiB? | ||
mst | somebody's emailed in | ||
samcv: apparently somebody else attempted to send in a group registration and claimed you were part of the plan | 21:47 | ||
samcv | oh ok | ||
AlexDaniel | japhb: … it should be lowercase k, right? | 21:48 | |
samcv | well i heard something but i didn't submit anything. someone just told me something about perl 6 masks or something | ||
AlexDaniel | ah, but we don't talk about that anymore. | ||
samcv | but i didn't know what was going on | ||
AlexDaniel | japhb: in any case, docs talk about that: docs.perl6.org/type/Telemetry#method_max-rss | ||
lizmat | ah, I completely missed that my Telemetry pod was cleaned up! | 21:49 | |
++ to whoever did that | |||
lizmat will try to update Telemetry doc tomorrow when she's not as tired ad feeling better... | 21:50 | ||
AlexDaniel | japhb: OK. So it is incorrect now, right? | 21:53 | |
japhb: because we take “Kbytes” which I assume is KiB and divide that by 1000… | 21:54 | ||
AlexDaniel hates that with passion | |||
samcv | ok going to run spectest one more time then i'll push the Unicode fixes AlexDaniel | 21:56 | |
21:56
brrt joined
22:02
samcv joined
|
|||
japhb | AlexDaniel: Yeah, I would *hope* that getrusage is returning KiB (1024) when it's not returning true bytes as in MacOS ... but certainly taking KiB and dividing by 1000 to get MB is mixing bases. | 22:03 | |
Geth | MoarVM: a29bc81b53 | (Samantha McVey)++ | tools/ucd2c.pl unicode: fix uppercase letters not giving Lu for the General_Category ucd2c.pl was trying to set both Cn (Unassigned) and Lu (Letter Uppercase) to the same pvalue code (0). This fixes it so they are not set to the same value. |
22:04 | |
MoarVM: 89fae17a6f | (Samantha McVey)++ | 2 files Commit the updated Unicode database Generated with the changes from the previous commit's change to ucd2c.pl |
|||
samcv | \o/ | ||
AlexDaniel | samcv: \o/ | ||
samcv: should I bump moar&nqp? | |||
samcv | held off on some other changes i want to make to ucd2c.pl until after the release | ||
AlexDaniel | or is it coming? | ||
samcv | yes please! | ||
AlexDaniel | ok | ||
samcv | then i'll push an added roast test | ||
AlexDaniel | done | 22:07 | |
samcv | still amazed this wasn't caught in any of our tests! | ||
AlexDaniel | yes :'( | ||
samcv | i guess nothing tested Lu | ||
AlexDaniel | if not for that module, we'd release it like that :D | ||
“maybe”, depending on whether I'd run whateverable tests before the release or not | 22:08 | ||
samcv | i mean really i probably need to take a look at my tests i wrote during my grant and finalize some i didn't end up putting in | 22:15 | |
and tweak to make sure property values are reachable | 22:16 | ||
AlexDaniel | I was thinking maybe we should be testing whatever perl6 reports for a character against some database that we know is correct | 22:17 | |
23:03
nativecallable6 joined,
tangible6 joined,
committable6 joined,
quotable6 joined,
greppable6 joined,
benchable6 joined,
releasable6 joined,
evalable6 joined,
bloatable6 joined,
unicodable6 joined,
coverable6 joined,
squashable6 joined,
bisectable6 joined,
statisfiable6 joined
23:47
MasterDuke joined
23:54
Geth joined
|