|
00:35
lizmat joined
01:00
lizmat joined
03:00
matiaslina joined
05:07
cognominal joined
06:09
domidumont joined
06:15
domidumont joined
07:01
brrt joined
|
|||
| brrt | \o | 07:01 | |
| www.freelists.org/post/luajit/Rando...piled-code <- fortunately i'm not the only one that sometimes miscompiles code :-) | 07:02 | ||
| the infiniloop in nqp building on reframe-jit is not so easy to repeat | 07:13 | ||
| ... let's try ASAN | 07:14 | ||
|
07:18
zakharyas joined
|
|||
| brrt | does the --asan option work on OS X? | 07:23 | |
| clearly, it does not | |||
| fix is easy fortunately :-) | 07:26 | ||
|
07:51
lizmat joined
|
|||
| brrt | infiniloop does originate from something ASAN is catching | 07:59 | |
|
08:34
mtj_ joined
08:58
mtj_ joined
09:48
vendethiel- joined
11:10
leont_ joined
13:00
khagan joined
14:07
leont_ joined
14:21
tomboy64 joined
|
|||
| tomboy64 | psch: mind taking a look at that? bpaste.net/show/0337fa47a038 | 14:21 | |
|
14:34
cognominal joined
14:37
brrt left,
brrt joined
|
|||
| brrt | //quit | 14:37 | |
|
14:47
nebuchadnezzar joined
14:57
domidumont joined
14:59
tomboy64 joined
|
|||
| psch | tomboy64: okay, i took a look. i'm neither particularly perl5 savvy nor familiar with the moarvm build process, though... :) | 15:13 | |
| jnthn: did you see tomboy64++'s patch for a pkg-config aware moarvm Configure.pl? | 15:14 | ||
|
15:15
leont_ joined
|
|||
| jnthn | psch: No | 15:19 | |
| Link? | |||
| psch | an hour ago | ||
| 14:21 < tomboy64> psch: mind taking a look at that? bpaste.net/show/0337fa47a038 | |||
| jnthn | oh, no wonder I didn't pay any attention, it was addressed to you ;) | 15:20 | |
| psch | i just send tomboy64 here vOv | 15:21 | |
| *sent | |||
| the day before yesterday, i think.. :) | |||
| jnthn doesn't really know much about pkg-config and prefers to pretend not to know anything about the build process :P | |||
| On line 45, | 15:22 | ||
| + $config{cincludes} .= ' ' . "$result"; | |||
| Oh, includes, not flags | |||
| Though the invocation of pkg-config is --cflags :) | 15:23 | ||
| tomboy64 | the problem is, if you build against native libraries, Configure.pl doesn't get the includes for libffi right | ||
| except for libtommath, the proper way for that would be to run pkg-config | 15:24 | ||
| ExtUtils-PkgConfig would be a perl wrapper for that but i was told to use native pkg-config or a perl-core package | |||
| tomboy64 shrugs | |||
| jnthn | Only thing I'd really note is that if it detects pkg-config but then pkg-config doesn't know about the package in question, it'll blow up | 15:29 | |
| Whereas before it'd just carry on | |||
| tomboy64 | no, it will continue silently | ||
| jnthn | I dunno if that means "it'd be doomed anyway so this is fail fast" | ||
| Oh? | |||
| + my $result = `$config{pkgconfig} --cflags libuv`; | 15:30 | ||
| We then test $? and die otherwise | |||
| tomboy64 | there a check for $? before | ||
| jnthn | Does it come back with 0 if pkg-config doesn't know the package? | ||
| tomboy64 | it comes back with a non-zero result | ||
| try it out ;) | |||
| pkg-config --cflags blablubb | 15:31 | ||
| echo $? | |||
| jnthn | Right, so | 15:32 | |
| + if ($config{pkgconfig_works}) { | |||
| + my $result = `$config{pkgconfig} --cflags libuv`; | |||
| + if ( $? == 0 ) { | |||
| And later | |||
| tomboy64 | bpaste.net/show/72fc34c83e53 <--- i made a little change here, forgot to upload that | ||
| jnthn | oh, it's a print, not a die | ||
| d'oh | |||
| OK, no problem. I just can't read, apparently :) | |||
| tomboy64 | :) | ||
| it first checks if pkgconfig works in general | |||
| if pkgconfig works, check for the lib. if that's not there, use the original behavior. | 15:33 | ||
| jnthn | yeah, I got that part. I just wrongly thought that if it did work but didn't not he package, we bailed. | ||
| But it just notes it and goes on | |||
| tomboy64 | well, that would be an option ... | ||
| silent errors are rarely good :-} | |||
| jnthn | It would, but sounds less robust :) | ||
| I think I like noting it | |||
| As it does now | |||
| tomboy64 | only problem left is, tommath doesn't register .pc files | 15:34 | |
| e.g. to pkg-config it's invisible | |||
| (no idea why) | |||
| jnthn | OK. I'm fine with that patch going in | 15:37 | |
| tomboy64 | great :) | 15:38 | |
| ilmari | tomboy64: because nobody submitted patches to them? ;-P | ||
| tomboy64 | ilmari: mebbe :) | 15:40 | |
| jnthn: psch: what about patches for nqp? | 15:48 | ||
| is this the right place? | 15:49 | ||
| psch | tomboy64: no, i think that would be #p6dev, ideally with a PR to github.com/perl6/nqp | ||
| tomboy64 | psch: roger that | ||
| jnthn | tomboy64: If it's comfortable to PR that patch, please do so...otherwise I (or somebody else) can apply it manually later | 15:51 | |
| (Or just push it to a git remote somewhere is as good as the PR) | |||
| tomboy64 | i can do a pr | ||
| jnthn bbl | |||
| Thanks! | |||
| tomboy64 | i will just need to make sure it actually works the way i intend it to | ||
|
17:46
zakharyas joined
18:26
Ven joined
21:38
zakharyas joined
22:23
lizmat joined
22:29
tomboy64 joined
22:42
tomboy64 joined
23:01
tomboy64 joined
23:27
cognominal joined
23:55
cognominal joined
|
|||