|
01:26
tokuhirom joined
01:48
ilbot3 joined
04:27
tokuhirom joined
05:28
tokuhirom joined
07:15
domidumont joined
07:20
domidumont joined
08:53
pmurias joined
|
|||
| pmurias | when do we increament the MoarVM serialization format version? | 08:53 | |
| * increment | 08:54 | ||
| JimmyZ | normally: see github.com/MoarVM/MoarVM/commit/cd...f5f0574091 | 09:02 | |
| pmurias: this one really github.com/MoarVM/MoarVM/commit/6e...197765e859 | 09:03 | ||
| pmurias: it added codes like : if (reader->root.version >= 19) | 09:04 | ||
|
09:14
tokuhirom joined
09:26
tokuhirom joined
|
|||
| pmurias | JimmyZ: I didn't add a check because I added a flag | 10:04 | |
| JimmyZ: if we are deserializing something serialized by version 19 the flag will be set to 0 | 10:05 | ||
| if version 20 serializes an object with a set hll role, and version 19 gets attempts to serialize it, version 19 will ignore the new flag it doesn't know about and things will fail with a weird error | 10:06 | ||
| a hll role could be set before my commit, it was just not serialized | 10:07 | ||
|
10:11
domidumont joined
11:07
cognominal joined
11:27
tokuhirom joined
11:44
cognominal joined
12:37
domidumont joined
|
|||
| JimmyZ | pmurias: according your commit, if it didn't write it, then it won't read | 13:04 | |
|
14:54
Ven joined
15:29
tokuhirom joined
15:47
domidumont joined
17:30
tokuhirom joined
17:41
Ven joined
19:16
tokuhirom joined
19:28
tokuhirom joined
19:57
Ven joined
21:29
tokuhirom joined
23:15
dalek joined,
synopsebot6 joined
23:37
[Coke] joined
23:57
tokuhirom joined
|
|||