github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
00:06
ggoebel_ left
00:13
adium13 joined,
adium13 left
00:19
nbg9 joined,
nbg9 left,
lizmat left
00:23
lizmat joined
00:24
p6bannerbot sets mode: +v lizmat
00:28
lizmat left
00:45
Kaiepi left
00:57
ggoebel_ joined
00:58
p6bannerbot sets mode: +v ggoebel_
01:00
mst left,
moritz left,
nwc10 left,
krunen left,
krunen joined,
moritz joined,
mst joined,
p6bannerbot sets mode: +v mst
01:01
nwc10 joined,
mst left,
mst joined,
livingstone.freenode.net sets mode: +v mst,
p6bannerbot sets mode: +v mst,
p6bannerbot sets mode: +v krunen,
ChanServ sets mode: +o mst,
p6bannerbot sets mode: +v moritz
01:02
p6bannerbot sets mode: +v nwc10
01:04
sjms18 joined
01:05
sjms18 left
01:21
zakharyas joined
01:22
p6bannerbot sets mode: +v zakharyas
01:32
MasterDuke left
06:17
robertle joined
06:18
p6bannerbot sets mode: +v robertle
06:24
patrickb joined,
p6bannerbot sets mode: +v patrickb
06:38
robertle left
07:20
domidumont joined
07:21
p6bannerbot sets mode: +v domidumont
07:26
lizmat joined
07:27
p6bannerbot sets mode: +v lizmat
09:29
Belial` joined,
Belial` left
09:30
qyliss1 joined,
qyliss1 left
09:54
nebuchadnezzar left,
nebuchadnezzar joined
09:55
p6bannerbot sets mode: +v nebuchadnezzar
10:01
zakharyas left
10:16
[KS] joined,
[KS] left
11:06
avar left,
avar joined,
avar left,
avar joined,
p6bannerbot sets mode: +v avar
11:07
p6bannerbot sets mode: +v avar
11:38
obfusk5 joined,
obfusk5 left
11:39
TotallyNotKim8 joined
11:40
TotallyNotKim8 left
11:53
trittweiler3 joined,
trittweiler3 left
13:11
buggable left
13:12
buggable joined,
p6bannerbot sets mode: +v buggable
|
|||
dogbert2 | jnthn: are you around? | 13:13 | |
the DU chain errors you fixed the other day are present in master in will go out with 2018.09. Is that a problem? | 13:15 | ||
13:15
zakharyas joined
|
|||
dogbert2 | *and will go out | 13:15 | |
13:16
p6bannerbot sets mode: +v zakharyas
|
|||
jnthn | dogbert2: I don't think so. One resulted in an instruction not being deleted (so harmless), the other broke SSA form but was still writing correct values to correct places. | 13:27 | |
13:27
AquaL1te5 joined,
AquaL1te5 left
13:43
robertle joined
13:44
p6bannerbot sets mode: +v robertle
|
|||
dogbert2 | jnthn: thx | 13:54 | |
14:00
lizmat left
14:14
lizmat joined
14:15
p6bannerbot sets mode: +v lizmat,
kees24 joined,
kees24 left
14:36
zakharyas left
14:40
lizmat left
14:44
lizmat joined
14:45
p6bannerbot sets mode: +v lizmat
14:58
lizmat_ joined
14:59
p6bannerbot sets mode: +v lizmat_
15:02
lizmat left
15:13
lizmat_ left
15:15
lizmat joined,
p6bannerbot sets mode: +v lizmat,
robertle left
15:29
lizmat left
15:32
patrickb left
15:37
committable6 left,
notable6 left
15:39
shareable6 left,
unicodable6 left,
squashable6 left,
releasable6 left
15:46
bisectable6 left,
domidumont left
15:48
robertle joined
15:49
p6bannerbot sets mode: +v robertle
15:52
MoziM28 joined
15:53
MoziM28 left
15:56
jpa-14 joined,
jpa-14 left
16:20
lizmat joined
16:21
p6bannerbot sets mode: +v lizmat
16:45
cHawk14 joined,
cHawk14 left
16:49
lizmat left
16:52
notable6 joined,
statisfiable6 joined
16:53
unicodable6 joined,
lizmat joined,
p6bannerbot sets mode: +v notable6,
p6bannerbot sets mode: +v statisfiable6,
p6bannerbot sets mode: +v unicodable6
16:54
p6bannerbot sets mode: +v lizmat,
lizmat left
17:06
nativecallable6 joined,
shareable6 joined,
p6bannerbot sets mode: +v nativecallable6
17:07
p6bannerbot sets mode: +v shareable6
17:48
committable6 joined
17:49
bisectable6 joined,
p6bannerbot sets mode: +v committable6,
rhcp12 joined,
rhcp12 left
17:50
p6bannerbot sets mode: +v bisectable6,
releasable6 joined
17:51
p6bannerbot sets mode: +v releasable6
17:55
squashable6 joined
17:56
p6bannerbot sets mode: +v squashable6
18:18
fatalbit8 joined,
fatalbit8 left
18:36
lizmat joined
18:37
p6bannerbot sets mode: +v lizmat
18:39
domidumont joined
18:40
domidumont left
18:42
domidumont joined
18:43
p6bannerbot sets mode: +v domidumont
18:51
domidumont left
18:54
lizmat left
19:38
nzhuk98_ joined,
nzhuk98_ left
19:44
buggable left,
buggable joined
19:45
p6bannerbot sets mode: +v buggable
19:56
dogbert17 joined,
p6bannerbot sets mode: +v dogbert17
|
|||
dogbert17 | what does the following error message mean? | 19:58 | |
Unhandled exception: getlexref_*: outer index out of range | |||
at SETTING::src/core/IO/Socket/Async.pm6:170 (/home/dogbert/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:connect) | |||
20:02
robertle left
20:38
nekosune19 joined,
nekosune19 left
|
|||
jnthn | dogbert17: "Something went rather wrong" | 20:41 | |
dogbert17: I...really can't guess what | |||
20:49
TC018 joined,
TC018 left
21:06
Kuun-Lann4 joined,
Kuun-Lann4 left
21:14
charims22 joined,
charims22 left
|
|||
timotimo | oh, hm | 21:32 | |
nope, not hm after all! | |||
i'll now look into removing prof_allocated for arg_* and invoke_* ops being replaced by set ops | 21:33 | ||
the DU chain checker is barking at me on master, is that known? for the core setting compile | 21:51 | ||
jnthn | Yeah, probably fixed in postrelease-opts | 21:54 | |
I know it's clean in there, at least :) | |||
timotimo | hah. i should probably base my work on that branch, then | ||
21:57
mneptok1 joined,
mneptok1 left
|
|||
timotimo | MoarVM oops: Spesh: instruction prof_allocated missing from define-use chain | 22:02 | |
well, that's at least something | |||
jnthn | That one's on you :P | 22:04 | |
Hm, thinking about it...I didn't audit the profiler when I did the DU chain changes, I don't think | 22:05 | ||
timotimo | MoarVM oops: Malformed DU chain: reader prof_allocated of 3(5) in BB 8 missing | 22:08 | |
PHI r3(5), r3(19) | |||
prof_allocated r3(5) | |||
that looks like your change for returning | |||
to support umltiple returns properly | |||
jnthn | Well, the fix I did was to correct a malformed DU chain | 22:09 | |
timotimo | hah | ||
jnthn | It makes the PHI the original register that the invoke came back from | 22:10 | |
Uh, invoke put the return value into | |||
So if the prof_allocated used r3(5) before it should be alright | |||
timotimo | it's the same before and after the optimization pass i believe | 22:12 | |
well, since i was going to remove that one anyway, maybe i'll adapt that to the new "return has a phi now" code | 22:14 | ||
jnthn | I'm am quite curious how this broke things | 22:15 | |
timotimo | oh i have an idea | ||
hum. i think i used return_bb when i should have used invoke_bb | 22:16 | ||
but the error is still the same | 22:17 | ||
oh, i think i see what's up | 22:23 | ||
i'm trying to delete the user, but i don't know its BB | 22:24 | ||
in bb 32 (0x7fffec2f5d28) killing allocated logger of ins set for operand r14(15) | |||
maybe i used return_bb where i should have used inMoarVM oops: Malformed DU chain: reader prof_allocated of 14(15) in BB 33 (0x7fffec2f5d88) missing | |||
is there API for "give me the BB that has this ins in it"? | 22:26 | ||
jnthn | No | 22:27 | |
And it'd be linear search | |||
timotimo | is there a reason not to have that? | ||
yes, it would | |||
jnthn | So it's not really encouraged | ||
Everywhere we need the two we carry them around together | |||
timotimo | am i allowed to add the bb of an ins to the MVMSpeshUsageChainEntry? | 22:28 | |
22:28
lizmat joined
|
|||
jnthn | No, because BB merging will invalidate it | 22:28 | |
timotimo | then spesh optimize will have to see the prof_allocated and figure out that it can't be from something that allocates any more | ||
22:29
p6bannerbot sets mode: +v lizmat
|
|||
timotimo | though more likely it'd go through things that wrote to relevant registers and see if perhaps it got logged already | 22:29 | |
jnthn | What phase do you do this in? | ||
Could it be suitable to do in the post_inline phase? | |||
timotimo | at the moment it's happening right as we rewrite_args and rewrite_returns | ||
jnthn | Is it being kicked out for efficiency reasons? | 22:31 | |
Or correctness? | |||
timotimo | efficiency | 22:32 | |
for that, i'd say the args rewrites are more important | |||
because then identity should finally become just prof_enterinline, prof_leave | |||
i'll leave the return-allocate-logger-opt out for the moment, then | 22:33 | ||
MoarVM oops: Spesh: instruction box_i missing from define-use chain | 22:34 | ||
huh | |||
i wonder why there is barely any detail in this error message | 22:36 | ||
ah! it happens in a different place | |||
that's now in the post_inline pass for some reason? | 22:37 | ||
removing the allocation logging made the box_i unused and that sprung a trap? | 22:38 | ||
jnthn | The error means that there's a box_i in the graph that's *not* in the DU chain | ||
I wonder why the error is missing the register being read by the box_i... | 22:39 | ||
timotimo | MVM_spesh_usages_delete is giving me this, which was called via post_inline_pass, in the line that says "/* Box instruction becabe unused; delete. */" | ||
jnthn | Oh! | ||
Then it's not the DU checker | 22:40 | ||
timotimo | "becabe" m) | ||
yes, that's right | |||
jnthn | But the C stack tells exactly where, as you found :) | ||
timotimo | the only user in that chain was a PHI node | ||
22:41
mauved15 joined,
mauved15 left
|
|||
mst | timotimo: e.g. here | 23:00 | |
23:02
MasterDuke joined,
p6bannerbot sets mode: +v MasterDuke
23:03
MasterDuke left,
MasterDuke joined,
herbert.freenode.net sets mode: +v MasterDuke,
p6bannerbot sets mode: +v MasterDuke
23:04
leont joined
23:05
p6bannerbot sets mode: +v leont
|
|||
timotimo | rr shall help me. | 23:10 | |
23:32
leont left
|