| retupmoca | should a parameterized role be repossessed like it's generic? | 00:09 | |
| except that would mean it doesn't exist anywhere after serialization... | 00:10 | ||
| does each SC need it's own copy of a parameterized role? | |||
| unless it's just the generic role itself having issues... | 00:21 | ||
|
05:18
ashleydev joined,
Util joined,
tadzik joined,
JimmyZ joined,
odc joined,
lue joined,
camelia joined,
lizmat joined,
brother joined,
ggoebel11119 joined,
rurban_ joined,
daxim_ joined,
flussence joined,
TimToady joined,
eternaleye joined,
woolfy joined,
FROGGS joined,
cognominal joined,
cxreg joined,
dagurval_ joined,
avar joined,
ingy joined,
moritz joined,
BinGOs joined
05:19
bcode joined,
timotimo joined,
_sri joined,
jnthn joined,
sergot joined,
yawnt joined,
dalek joined,
lee_ joined,
tokuhirom joined
05:30
synopsebot joined
05:31
xiaomiao joined
05:38
xiaomiao joined
05:50
Ven_ joined
05:55
harrow joined
07:18
ChanServ joined
07:37
xiaomiao joined
09:19
ChanServ joined,
synopsebot joined
10:50
FROGGS[mobile] joined
11:49
colomon joined
|
|||
| dalek | arVM: 4f73c4b | (Steve Mynott)++ | src/platform/threads.h: add sched_yield for NetBSD |
12:36 | |
| arVM: 2055a67 | jonathan++ | src/platform/threads.h: Merge pull request #91 from stmuk/master add sched_yield for NetBSD |
|||
|
12:41
zakharyas joined
|
|||
| dalek | arVM: 161a98b | jnthn++ | src/core/frame.c: Fix callsite size calculation in tweak_cs. Avoids trying to access memory beyond its allocated boundary. Found by nwc10++ using ASAN/Valgrind. |
13:38 | |
|
15:00
hoelzro joined
15:06
FROGGS joined
15:28
colomon joined
|
|||
| tadzik | mm, beer | 15:32 | |
| jnthn | tadzik: IPA again? :) | ||
| tadzik | today it's Dark Lager | 15:33 | |
| I'm curious what it is | |||
| it's from the creators of "The Empire Strikes", and it's named "Black Hole" | |||
| jnthn | ooh :) | ||
| tadzik | ooh, it is good :} | 15:34 | |
| next time we meet I'll bring a backpackfull of those | |||
| jnthn | :D | 15:35 | |
| I'm on the way to Stockholm and found a place last time with a very, very nice Swedish imperial IPA on tap | |||
| it's 9% or so :) But I might take one tonight :) | 15:37 | ||
| tadzik | this one is 11.5 | 15:38 | |
| I didn't notice until I checked | |||
| ah, no | |||
| actually 4.2 | |||
| the weight vs volume trick | |||
| jnthn | ...small difference :P | ||
| tadzik | oh, the bottle even recommends a particular flavor of glass | 15:39 | |
| and recommended food | |||
| how fancy :) | |||
| jnthn | tadzik: If you can hunt it down, www.ratebeer.com/beer/great-divide-...out/85174/ comes highly recomended. | 15:41 | |
| tadzik | oooh, the Warsaw Beer Track has some new points on it | 15:42 | |
| jnthn: I'll look around for it :) | 15:43 | ||
|
16:40
colomon joined
16:48
retupmoca joined
|
|||
| nwc10 | jnthn: works on "my" machine | 17:06 | |
| jnthn | nwc10: Gets rid of ASAN fail? | ||
| nwc10 | that one, yes | ||
| need this for the second: paste.scsys.co.uk/348393 | |||
| to fix the naughtiness of | 17:07 | ||
| m: "\x1F63E".encode("UTF-16") | |||
| camelia | ( no output ) | ||
|
17:08
japhb joined
|
|||
| dalek | arVM: 551786d | nicholas++ | src/strings/utf16.c: Fix buffer overflow in UTF-16 encoding. |
17:25 | |
|
17:50
colomon joined
|
|||
| nwc10 | jnthn: the final thing that ASAN is unhappy about, also spotted by valgrind: paste.scsys.co.uk/348420 | 17:53 | |
|
17:54
btyler joined
|
|||
| nwc10 | jnthn: valgrind also complains (plus fix): paste.scsys.co.uk/348444 | 18:32 | |
| jnthn: however, there are other places that assign has_flattening but don't (yet) assign is_interned | |||
| jnthn | ah, yes...that really needs to be zero | 18:34 | |
| And may explain some of the intermittent bugs folks hvae been seeing with spesh enabled | 18:35 | ||
| nwc10 | yes, I did wonder that | ||
| as in, if that's garbage but true, it enters the block incorrectly | |||
| jnthn | right | 18:36 | |
| nwc10: Just made a pass through all the places where has_flattening is set, and is_interned is not, and reviewed them. | 18:39 | ||
| nwc10 | I found the right by trial and error | ||
| tried two other places, no change from valgrind | |||
| and I don't know anything near enough to make the right choice | 18:40 | ||
| dalek | arVM: fd4cb89 | jonathan++ | src/core/ (4 files): Make sure is_interned is zeroed as needed. Patch partially thanks to nwc10++ (the args.c case), who also found the general issue. Other 3 changes are other places vulnerable to the same kind of bug. |
18:45 | |
| japhb | At this point, are the known r-m segfaults and ASAN/valgrind complaints all dealt with? | 18:48 | |
| nwc10 | not the crazy threading one in ttp://paste.scsys.co.uk/348420 | 18:50 | |
|
18:53
colomon joined
19:27
zakharyas joined
|
|||
| nwc10 | jnthn: yes, works on "my" machine apart from that threading test | 19:52 | |
| timotimo | jnthn: should i count the nameds against the intern arity limit, too? | 20:33 | |
| jnthn | timotimo: um...hmm | 20:47 | |
| timotimo: probably | |||
| timotimo | now i get a strange error. probably because i have some parts implemented, but not most of them :) | 20:49 | |
| jnthn | hah, yes :) | 20:52 | |
| nwc10: OK. That one's on my todo list then :) | |||
| timotimo | merge conflicts :\ | 20:53 | |
| dalek | Heuristic branch merge: pushed 18 commits to MoarVM/named_to_positional by timo | 21:00 | |
| jnthn writed some feedback on github.com/MoarVM/MoarVM/pull/89 | 21:15 | ||
| timotimo | jnthn: what's the direct consequence of me starting to intern callsites that have nameds? | 21:25 | |
| jnthn | timotimo: the is_interned check in frame.c that guards trying spesh will be true | ||
| timotimo: And then you'll hit args.c, which assumes it's never getting a callsite with nameds. | 21:26 | ||
| And then drunk unicorns will fly out of the screen. | |||
|
21:27
brrt joined
|
|||
| jnthn | o/ brrt | 21:28 | |
| timotimo | ah, yes | 21:31 | |
| brrt | hi jnthn, timotimo | 21:32 | |
| good afternoon :-) | |||
| timotimo | hi :) | ||
| This type does not support positional operations | 21:34 | ||
| hmm | |||
| jnthn | tbh, if I was a drunk unicorn I'd probably say that too... :P | ||
| It probably means you've a P6opaque somewhere a VMArray is expected. | 21:35 | ||
| timotimo | in MVM_interp_run, can i easily tell whether i'm in specialized bytecode or not? | ||
| jnthn | yes. | ||
| brrt | how so? | ||
| jnthn | Look at tc->cur_frame->effective_bytecode | ||
| And see if it's the same as tc->cur_frame->static_info->body.bytecode | |||
| If they're different you're in specialized bytecode. | 21:36 | ||
| timotimo | tanks | ||
| jnthn | bombs | ||
| jnthn ponders if his plan for nqp::timer will work out on JVM | 21:37 | ||
| timotimo | er, huh | ||
| (gdb) print tc->cur_frame->static_info->body.bytecode | |||
| $4 = (MVMuint8 *) 0x7ff96c2ad6ee <Address 0x7ff96c2ad6ee out of bounds> | |||
| but they are the same pointer | |||
| jnthn | huh indeed | 21:38 | |
| if they're the same then you're running the original bytecode. | 21:39 | ||
| timotimo | maybe i'm breaking inside a frame that got called from spesh'd bytecode | ||
| oh well. i'll have a look at spesh/args.c and see what i can do | |||
| jnthn | That's possible. | ||
| Well, you can look at caller | |||
| Also you can set MVM_SPESH_DISABLE=1 and see if your problem goes away | 21:40 | ||
| If it does, then I'd probably get a working Moar, get the spesh log, then get your changed Moar, get its spesh log, and diff. | |||
| Because in theory nothing shoulda changed. | |||
| timotimo | right | 21:42 | |
| it still segfaults even with DISABELE=1 | 21:43 | ||
| jnthn | did you spell DISABLE right in trying it? | 21:44 | |
| brrt | (bloody legacy x86 registers) | ||
| timotimo | MVM_SPESH_DISABLE=1 | ||
| jnthn | right | ||
| So the breakage is nothing to do with spesh. | |||
| timotimo | the error happens in MVM_string_equal called from MVM_args_get_named_obj | ||
| it's trying to find the string "inheritable" in the args | 21:45 | ||
| brrt | (good luck folks, i'm going to sleep again :-)) | 21:49 | |
|
21:49
brrt left
|
|||
| timotimo | well, when i don't intern callsites that don't have nameds, it still works. so ... | 22:11 | |
| i'll continue thinking about this later. tomorrow or so. | |||
| jnthn | ok :) | ||
| No hurry :) | |||
| jnthn is currently tied up pondering timers :) | 22:12 | ||
|
22:37
colomon joined
22:59
colomon joined
|
|||