github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
00:19
harrow joined
00:40
lucasb left
00:48
Kaiepi left,
Kaiepi joined
01:08
ggoebel joined
01:13
Kaiepi left
01:15
Kaeipi joined
|
|||
Geth | MoarVM: vrurg++ created pull request #1204: Use `make` exit status as own |
01:38 | |
01:47
Kaeipi left
02:16
mtj_ joined
03:23
ggoebel left
03:36
ZzZombo_ joined
03:38
ZzZombo left,
ZzZombo_ is now known as ZzZombo
|
|||
Geth | MoarVM: bb239a91df | (Stefan Seifert)++ | src/types.h Fix MVMSpeshPluginState type defined twice Fixes part of GH #3266 |
06:43 | |
07:03
domidumont joined
07:04
travis-ci joined
|
|||
travis-ci | MoarVM build errored. Stefan Seifert 'Fix MVMSpeshPluginState type defined twice | 07:04 | |
travis-ci.org/MoarVM/MoarVM/builds/602174175 github.com/MoarVM/MoarVM/compare/b...239a91df14 | |||
07:04
travis-ci left
|
|||
nine | What I would give for a reliable CI... | 07:11 | |
tadzik | heh | 07:23 | |
I have mostly good experience with gitlab-ci fwiw | |||
but travis... for some reason, whenever something travis-backed shows CI failures, it's always travis' fault rather than the code's | |||
07:43
sena_kun joined
07:51
brrt joined
|
|||
brrt | \o | 07:51 | |
tellable6 | 2019-10-22T20:24:05Z #moarvm <lizmat> brrt please do write better notes, or better commit messages :-) | ||
brrt | I'll try :-D | ||
07:53
robertle_ joined
|
|||
nwc10 | o/ | 07:55 | |
08:32
MasterDuke joined
|
|||
Geth | MoarVM: 32003eecfd | (Vadim Belman)++ | Configure.pl Use `make` exit status as own Propagade `make install` exit code for upstream NQP `Configure.pl`. Otherwise NQP continues to build as if nothing happened and would confuse a user with bizzare _'too old moar'_ error message if older moar is already instaleld. Resolves rakudo/rakudo#3266 |
08:36 | |
synopsebot | RAKUDO#3266 [closed]: github.com/rakudo/rakudo/issues/3266 [build] Rebuilding fails on older git | ||
MoarVM: 67b6acf71e | (Jonathan Worthington)++ (committed using GitHub Web editor) | Configure.pl Merge pull request #1204 from vrurg/rakudo_3266 Use `make` exit status as own |
|||
09:08
domidumont left
09:09
domidumont joined
09:33
domidumont left
09:35
brrt left
09:44
MasterDuke left
10:12
MasterDuke joined
10:25
Guest13443 joined
10:55
ggoebel joined
10:59
ggoebel left
11:18
MasterDuke left
11:27
sena_kun left
11:28
sena_kun joined
11:45
ggoebel joined
11:55
Kaiepi joined
12:02
domidumont joined,
brrt joined
12:21
Kaiepi left
12:22
Kaiepi joined
12:23
Kaiepi left
12:27
Kaiepi joined
12:28
brrt left
12:31
MasterDuke joined
12:34
domidumont left
12:35
domidumont joined
13:24
lucasb joined
13:37
sena_kun left
13:38
sena_kun joined
14:13
robertle_ left
14:37
robertle_ joined
|
|||
Kaiepi | i suspect the way async sockets deal with their handles may be prone to memory leaks | 14:55 | |
it frees the handles whenever they get closed, rather than from the gc free function. it's not guaranteed there will be a socket that needs closing though, like if uv_tcp_connect or uv_tcp_bind fail, since uv_tcp_create doesn't actually create any kind of socket until another function that requires it to exist is used | 14:58 | ||
is this something worth looking into before the release or should i just focus on reverting the changes to dns resolution that are breaking? | 15:01 | ||
jnthn | No, I'd rather that such changes would have time for more testing | 15:03 | |
15:03
robertle_ left
|
|||
nine | Kaiepi: the important part of releases is to not introduce new errors. As long as we ensure that, we can say that every release is better than the previous one and we're on the right track. Requiring a release to fix all known errors would just lead to never releasing at all. | 15:04 | |
That's also why reverting is often preferable to last minute fixing frencies - you can't say what new issues you introduce with your fixes. | 15:06 | ||
s/frencies/frenzies/ | |||
15:09
robertle_ joined
|
|||
Kaiepi | aight | 15:12 | |
16:22
domidumont left
16:41
domidumont joined
16:46
squashable6 left
16:50
camelia joined,
squashable6 joined,
notable6 joined
16:51
greppable6 joined
17:35
Kaiepi left,
Kaiepi joined
|
|||
timotimo | Stage start : 0.000 | 17:41 | |
Malformed UTF-8 near bytes 00 00 80 | |||
at SETTING::src/core.c/Encoding/Decoder/Builtin.pm6:44 (/home/timo/perl6/install/share/perl6/runtime/CORE.c.setting.moarvm:consume-line-chars) | |||
how did this even happen | |||
i'll try rebuilding nqp and rakudo first | 17:43 | ||
with latest master | |||
ok the error is gone | 17:49 | ||
17:54
ZzZombo left
|
|||
Geth | MoarVM: Kaiepi++ created pull request #1205: Revert to only using the first address received from a DNS resolution |
18:01 | |
AlexDaniel | Kaiepi: wow, well. Is it just a revert or are there any extra changes? | 18:10 | |
18:25
brrt joined
|
|||
Kaiepi | i'll need to double check AlexDaniel, this was something i needed to do manually | 18:28 | |
actually AlexDaniel, would reverting this whole mess and remaking the changes that are worthwhile to have so the commits are possible to work with after the release be ok? | 18:36 | ||
rather than just the commit that broke tests | 18:39 | ||
18:50
MasterDuke left
18:57
brrt left
|
|||
AlexDaniel | Kaiepi: If you can do that, then probably yes | 19:03 | |
Kaiepi: but it sounds like a huge pain in the ass, so I'm definitely not insisting on that | 19:04 | ||
Kaiepi: also, is anybody from the moarvm team helping you out with the grant stuff? They might have a better opinion than I have | 19:05 | ||
by helping out I mean like supervising and giving advice | 19:06 | ||
19:10
robertle_ left
|
|||
Kaiepi | i'm supposed to have a supervisor, but we haven't been in contact since we first got introduced, which was at least a couple months ago by this point AlexDaniel | 19:14 | |
not sure if they're on the moarvm team or not | |||
AlexDaniel, the changes themselves didn't take terribly long to make, just i had a lot of trouble getting anyone to review them before they could be merged, so it's something i can do | 19:18 | ||
AlexDaniel | Kaiepi: then you're probably the only person who can do a good decision :) | 19:24 | |
Kaiepi: As long as I'm relatively sure that the changes are not breaking existing code in the wild, I'll be fine with it | |||
Geth | MoarVM: Kaiepi++ created pull request #1207: Revert "Merge pull request #1166 from Kaiepi/ipv6-unsupported" |
19:34 | |
20:07
brrt joined
|
|||
brrt | .tell Kaiepi - I'm not aware of the details of your grant, so I'd need some time to get up to speed, but I'll volunteer as a 'moarvm-side' mentor, if that'd be of any help | 20:09 | |
tellable6 | brrt, I'll pass your message to Kaiepi | ||
20:35
domidumont left
20:55
brrt left
20:57
ggoebel left
21:19
moon_child left
21:26
moon_child joined
21:40
sena_kun left
22:27
Kaiepi left
22:29
Kaiepi joined
22:35
Kaiepi left
22:41
Kaiepi joined
22:54
redable joined
22:56
redable left
23:36
greppable6_ joined,
greppable6_ left
|