github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
01:11
Kaeipi left
01:44
MasterDuke left
04:07
squashable6 left,
notable6 left,
shareable6 left,
reportable6_ left,
releasable6 left,
evalable6 left,
committable6 left,
coverable6 left,
linkable6_ left,
tellable6_ left,
greppable6 left,
bloatable6 left
04:08
quotable6 joined,
bisectable6 joined,
tellable6 joined,
linkable6 joined
04:09
shareable6 joined,
greppable6 joined,
evalable6 joined,
unicodable6 joined,
nativecallable6 joined,
statisfiable6 joined,
reportable6 joined,
bloatable6 joined
04:10
coverable6 joined,
benchable6 joined,
releasable6 joined,
committable6 joined,
squashable6 joined,
sourceable6 joined,
notable6 joined
06:42
Kaiepi joined
07:39
zakharyas joined
07:40
sena_kun joined
07:45
MasterDuke joined
07:50
zakharyas left
07:51
zakharyas joined
|
|||
nwc10 | good *, #moarvm | 09:02 | |
(I forgot) | |||
jnthn | releasable6: status | 09:16 | |
releasable6 | jnthn, Next release in ≈25 days and ≈9 hours. There are no known blockers. Changelog for this release was not started yet | 09:17 | |
jnthn, Details: gist.github.com/8b30ad8b34323fc920...46d0c95692 | |||
jnthn | I think that means we can merge the hash stuff rather soon :) | ||
nwc10 | ah yes | ||
I realised that I was a bit fried yesterady, so didn't try to prepare for this | |||
my plan was | |||
make a branch A-Better-Hash | |||
fix that XXX commit message | |||
and, maybe | |||
re-order the code review commits immediately after their relevant first commit(s), and verify that `git diff` between the two branches is 0 | 09:18 | ||
I'm notionally doing $work currently | |||
but I shouldn't summarise that on a logged channel. | 09:19 | ||
MasterDuke | nwc10: would you squash/rebase the code review commits into their relevant first commits or leave them separate? | 09:39 | |
nwc10 | if I put them next to them, I think I'd prefer to leave them separate | 09:40 | |
I see some merit in leaving the history of "ideas we explored but didn't quite get right first time" | 09:41 | ||
but "next to them" also then means that it's not too hard to see what we ended up with | |||
anyway, I have a work ticekt to work on | 09:42 | ||
which obviously means that I can now charge tea drinking to another department :-) | |||
jnthn: rakuast doesn't generate any ASAN excitement (did not run spec tests) | 10:18 | ||
but IIRC new-disp did at some point about the time you went on holiday. but as the spectests have (I think) moved on and it has not, I didn't run them | 10:19 | ||
and I can't currently spot what I thought was upsetting it | |||
10:38
Altai-man joined
10:41
sena_kun left
10:51
kawaii left
11:00
kawaii joined
|
|||
dogbert11 | libuv 1.39 is out, github.com/libuv/libuv/blob/v1.x/ChangeLog | 11:07 | |
jnthn | Looks fairly low risk, and good timing for us to bump | 11:09 | |
11:09
brrt joined
11:33
zakharyas left
12:19
brrt left,
brrt joined
|
|||
nwc10 | good *, brrt | 12:31 | |
or is that just good *, brrt's client? | 12:32 | ||
12:38
zakharyas joined
|
|||
brrt | good * nwc10 | 12:39 | |
12:48
brrt left,
brrt joined
|
|||
Geth | MoarVM: dogbert17++ created pull request #1339: Update libuv to v1.39.0 |
14:22 | |
14:39
sena_kun joined
14:40
Altai-man left
|
|||
jnthn | dogbert11: Hmm, CI sees a Windows test failure | 14:48 | |
MasterDuke | NMAKE : fatal error U1073: don't know how to make 'gen/nqp-version' | 14:56 | |
dogbert11 | MasterDuke: is that all it says? | 15:58 | |
this change is slightly suspect: * build,win: link to user32.lib and advapi32.lib (George Zhao) | 16:01 | ||
16:16
squashable6 left
16:17
squashable6 joined
16:41
MasterDuke left
17:20
zakharyas left
17:38
brrt left
|
|||
dogbert11 | how do I even know that libuv had anything to do with this | 18:19 | |
is it possible to rerun this part somehow? | 18:20 | ||
18:38
Altai-man joined
18:41
sena_kun left
18:53
kawaii left
18:55
kawaii joined
|
|||
timotimo | perhaps make a pullrequest with only that commit reverted? | 18:58 | |
Altai-man | timotimo, why? | 19:08 | |
After re-run CI passed. | 19:09 | ||
timotimo | damn | ||
[Coke] | Altai-man: adapated your PR comments after it got merged to master; thanks. | 19:11 | |
... wrong window. | |||
Altai-man | [Coke], you are welcome! Thanks for your improvements in the first place. :) | 19:14 | |
20:06
zakharyas joined
20:19
zakharyas left
|
|||
dogbert11 | yay, Altai-man, did you rerun the the CI test? | 20:24 | |
jnthn: the test failure disappeared after the failing test was rerun | 20:27 | ||
Altai-man | dogbert11, yeah. | 20:34 | |
20:35
MasterDuke joined
20:36
brrt joined
|
|||
jnthn | dogbert11: ah, ok, nice | 21:00 | |
Maybe unlucky timing with respect to some other nqp/rakudo change | |||
Geth | MoarVM: 29ce8171f7 | (Jan-Olof Hendig)++ | 3rdparty/libuv Update libuv to v1.39.0 Spectest clean under Linux Mint (Ulyana) 64-bit |
21:10 | |
MoarVM: 15a76dcb3e | (Jonathan Worthington)++ (committed using GitHub Web editor) | 3rdparty/libuv Merge pull request #1339 from dogbert17/update-libuv-2-v1.39.0 Update libuv to v1.39.0 |
|||
lizmat | will someone bump nqp and Rakudo ? | 21:14 | |
or should I? | |||
21:29
vrurg left,
vrurg joined
21:39
brrt left
21:54
camelia left
|
|||
jnthn | lizmat: go for it, if you didn't already | 22:27 | |
22:39
sena_kun joined
22:41
Altai-man left
23:16
sena_kun left
|