dalek | ast: c3923e8 | (Zoffix Znet)++ | S06-other/main-usage.t: Unfudge now-passing test for RT#127977 sub MAIN constraint checks must not leak to the user of the program. Fixed by one of these commits: github.com/rakudo/rakudo/compare/7...ad497dd0cb |
00:03 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=127977 | ||
[Coke] | . | 01:15 | |
BrokenRobot: There is a presaved query at rakudo.org/tickets/ | 01:16 | ||
that links to tickets that need docs. I'll try to include the link the next time I mention it. | |||
MasterDuke | [Coke]: do you happen to have some sort of admin access to rt.perl.org? | 01:17 | |
.seen timotimo | 01:22 | ||
yoleaux2 | I saw timotimo 5 Jul 2016 20:18Z in #perl6-dev: <timotimo> ooooh | ||
jdv79 | [Coke] is an admin or more iirc | 01:24 | |
at least for the p6 stuff | |||
Zoffix | [Coke], out of all those links, only the testsneeded URL is working. The rest give query error | 01:26 | |
MasterDuke | excellent, then i hope he returns soon | ||
Zoffix | And I'm surprised the tests one doesn't give the CSFR error | 01:27 | |
Actually all of them have CSRF errors if I try another browser (not logged in there) | 01:29 | ||
" There was an error parsing your search query: Wrong query, expecting a VALUE in 'Queue=%>27perl6<--here%27 AND Status=%27new%27'. Your RT admin can find more information in the error logs. " | |||
[Coke] | awwaiid - added you on RT | 01:31 | |
MasterDuke: I have admin rights to the perl6 bugadmin queue. | |||
Zoffix | That error sounds a lot like the one I was getting a few days ago when I was trying to use RT's REST API. This URL worked after lots of twiddling: github.com/zoffixznet/Rele6sr/blob...RT.pm6#L44 | 01:32 | |
MasterDuke | [Coke]: hmm, would you be able to fix my account? | ||
Zoffix | ¯\_(ツ)_/¯ | ||
MasterDuke | i can't see/edit tickets when i'm logged in | ||
[Coke] | For the errors, we can try to find a URL that works now, or we can open a ticket with the perl rt admins. | 01:33 | |
MasterDuke: All i can do is give you admin privs to perl6 tickets. | |||
If you're having other issues, you need to talk to the perl rt admins. | 01:34 | ||
MasterDuke | ok. i tried in irc.perl.org:#rt and irc.freenode.net:#rt a couple days ago, but haven't heard anything from either | 01:36 | |
and i think part of my problem is my emails aren't getting through | 01:37 | ||
Zoffix | Register a throw-away email on gmail.com and try that? Try creating a new RT account? | ||
¯\_(ツ)_/¯ | |||
MasterDuke | i did try another gmail account that i never use for anything | 01:38 | |
Zoffix | No idea, sorry. | ||
timotimo | i've spoken up against migrating away from RT in the past, but a few of us are getting absolutely screwed over by that piece of ... software | 01:40 | |
[Coke] | tbrowder: your rt question about "top 10 tickets" isn't something I can help with | 01:41 | |
MasterDuke: what email address did you try to send the report from? | 01:42 | ||
and to? (privmsg me) | |||
psch | hm, do we get any info to the user about post constraints on MAIN with what fixed #127977? | 05:38 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=127977 | ||
psch | 'cause that's kinda the coolest bit that happened in the branch tadzik linked in the ticket | ||
alright, the getextype problem is because we're actually not creating a VMException in throwcatdyn_c | 07:30 | ||
which seems somewhat wrong, considering getextype needs one | |||
but i think we can just create one in throwcatdyn_c, so i'm gonna try that | 07:31 | ||
[Tux] | This is Rakudo version 2016.06-150-g41b685e built on MoarVM version 2016.06-9-g8fc21d5 | 07:44 | |
test 16.005 | |||
test-t 9.593 | |||
csv-parser 16.777 | |||
psch | humm, creating a VMException there seems to really blow up compilation time o.o | 08:01 | |
'bout 20 minutes now, and it's only at stage2/NQP.nqp | 08:02 | ||
nine | You sure it's still doing something usefull? | 08:05 | |
psch | yeah, it's still going, at Perl6-Actions.nqp now | 08:11 | |
i mean, driving total compilation time up by some 300% is a bit much to explain with "throwcatdyn_c is a really hot method", but it's not completely impossible vOv | 08:12 | ||
otoh, compared to previously, it now allocates a VMExceptionInstance *and* a Throwable for the Backtrace | 08:13 | ||
and i think especially the Backtrace is probably rather expensive | 08:14 | ||
nine | What's it doing with the VMExceptionInstance anyway? | 08:16 | |
psch | the handler for lexical &return needs a VMExceptionInstance | 08:17 | |
nine | But what for? | 08:18 | |
psch | to know what kind of Exception it is? | ||
&EXCEPTION in src/core/Exception.pm:250 for example | |||
nine | How do you create the VMExceptionInstance? | 08:20 | |
psch | pretty much exactly as die_s_c does | 08:21 | |
that is, get the exType from the hllConfig, call allocate on the STable | |||
well, the REPR | |||
then set field | |||
+s | 08:22 | ||
i'm pretty sure the biggest performance impact is the Backtrace, and i'm not sure we actually need it | |||
nine | Can't you leave out the nativeTrace in throwcatdyn_c? Considering that we got by without a VMExceptionInstance at all previously, we may not actually need everything. | ||
psch | right, i'm still gonna let the build finish, can't be longer than another 20 to 30 minutes... :) | 08:23 | |
nine | All other fields should be dirt cheap | ||
psch | gotta get more coffee and some breakfast anyway | ||
nine | coffee++ | ||
psch | also i'm kinda curious what stage parse comes out as heh | 08:27 | |
nine | You must be a very patient man | 08:28 | |
psch | well, i'm doing other things on the side, so it's not so bad | 08:37 | |
not even 9 minutes for stage parse, not so bad :P | 08:41 | ||
...but over 20 minutes stage jast, which i am now fed up with hah | 09:05 | ||
jnthn | psch: I suspect constructing a new Throwable on every single return/next/last etc. could easily do it | 10:02 | |
psch: That's really expensive 'cus it snapshots the entire call stack | |||
psch | jnthn: right, which is why i took that out. but apparently even allocating the VMExceptionInstance takes long enough for an unbearable impact | 10:03 | |
as in, i've been running Configure.pl without the new Throwable for almost an hour now | |||
not what else to try there, tbh, i don't think leaving a static VMExceptionInstance around would work | 10:04 | ||
jnthn | iirc, on Moar we only construct the VMException instance if the target handler actually needs it | 10:05 | |
Handlers that are just "goto"-ish don't need it | |||
And you can figure that you from the handler metadata, I believe. | |||
Same should be possible on JVM | |||
psch | i don't think i know all of the handler fields | 10:06 | |
jnthn | In fact must be, otherwise we'd not know to invoke the handler on the top of the call stack. | ||
psch | i *think* handlerInfo[1] is the extype, but does that tell me if it needs an vmExObj..? | ||
jnthn | /* Exception handler kinds. */ | 10:07 | |
public static final int EX_UNWIND_SIMPLE = 0; | |||
public static final int EX_UNWIND_OBJECT = 1; | |||
public static final int EX_BLOCK = 2; | |||
It's whatever is getting compared agaisnt those constants | |||
psch | ah, okay | ||
oh ffs | 10:08 | ||
i actually commented the new Throwable in die_s_c, not throwcatdyn_c ._. | |||
at least that easily explains why it didn't seem faster than the compile before... | 10:09 | ||
Zoffix | timotimo, the problem I see with all the calls to migrate from RT is no one's offering to be the person to do the enormous amount of work involved. | 10:32 | |
IIRC MadcapJake offered to make a better interface for bug reporting, but I'm not aware of even that being completed. Actually migrating would be orders of magnitude more work. | 10:33 | ||
AlexDaniel | Zoffix: migrate where? | 10:56 | |
if given enough permissions to work on stuff, I can do it. And I think that there are others who will happily help with it. The problem is that we can't decide what we should use instead of RT | 10:57 | ||
Zoffix | nine++ with RT#128457 gone I can now write my Mojolicious + Perl 6 article \o/ | 11:06 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=128457 | ||
Zoffix | Based on all the likes my peak-preview of the Perl 6 Mojo app got, it should be a well-read post. | ||
*peek | |||
nine | Yeah! | 11:08 | |
psch | well, i've got the getextype fixed with always creating a VMExceptionInstance, and that shows we still get the BEGIN EVAL problem | 11:13 | |
i'll probably change the getextype to "only create if the handler needs it" as jnthn++ suggested, though, so no commit yet | 11:14 | ||
nine | psch: the last thing rakudo-j needs is slower build times :) | 11:15 | |
psch | well, allocating a VMExceptionInstance doesn't really seem to impact it | ||
clean build still at around 13min | |||
nine | oh | ||
So it really was just those backtraces | |||
psch | as mentioned, i commented the new Throwable in die_s_c instead of throwcatdyn_c | ||
yeah | |||
dalek | kudo/nom: c843682 | lizmat++ | src/core/Array.pm: Make Array.push|append about 40% faster - remove ensure-allocated, integrate in code where needed This is really the big win: the ensure-allocated method for some reason did *not* get JITted. - rewrite hot code completely using nqp ops |
11:46 | |
lizmat hopes for some good test-t effects | 11:52 | ||
yoleaux2 | 5 Jul 2016 21:41Z <AlexDaniel> lizmat: fwiw, numeric overflow changes were before 2015.12, but you can still find it with bisectable: bisect: good=2015.10 2 ** 99999999999999999999999999999999999 | ||
BrokenRobot | wow! lizmat++ that's awesome! | 12:06 | |
Looks like test-t soon (already?) will be in the 8s rnage \o/ | 12:07 | ||
lizmat hopes so | 12:11 | ||
travis-ci | Rakudo build passed. Elizabeth Mattijsen 'Make Array.push|append about 40% faster | 12:41 | |
travis-ci.org/rakudo/rakudo/builds/142733653 github.com/rakudo/rakudo/compare/4...43682f3b58 | |||
[Coke] goes back to work today! (bah!) | 13:10 | ||
gfldex | jnthn: i'm getting «Internal error: invalid thread ID 111254976 in GC work pass» when use Gumbo;. Is there any easy way to provide you with debug info? | 13:31 | |
DrForr | For those of you needing an excuse to get cheap Guinness - conferences.oreilly.com/oscon/open-...tail/53512 | 13:36 | |
nine | DrForr: in your bio "for Parrot née Perl 6" looks like a typo? | 13:38 | |
DrForr | The ' née ' bit? I thought that was the proper way to spell that, with the accent. | 13:39 | |
perlpilot | it is | ||
nine | Oh, then I just learned a new English word :) | 13:40 | |
DrForr++ | |||
DrForr | www.wordnik.com/words/nee # The second definition. | ||
It's pretty rare, but when you're looking for the right words... | 13:43 | ||
gfldex | please update Pod::To::HTML on docs.perl6.org to get github.com/perl6/Pod-To-HTML/commi...478f36407c | 13:48 | |
Skarsnik | Skarsnik> Hello, I am not sure if someone remember my leak issue with rakudo/moar and the XML module. I was curious if it's finally fixed, but it's still here (even if it's smaller than before) gist.github.com/Skarsnik/03b970d2a4b827ba1e1d It was fixed for some revision it seem according to this gist | 13:50 | |
timotimo | at least one thing in there has been fixed since | 13:52 | |
i remember reversing the order of nfg and fsa destroying | |||
Skarsnik | Let me add an updated output | 13:53 | |
timotimo | because it used to destroy the FSA first, then try to free the NFG thing which had been allocated inside the FSA | ||
that'd be good | 13:54 | ||
Skarsnik | I added a 2a - recent | 13:55 | |
I don't remember how to get the valgrind output thou | |||
timotimo | valgrind --leak-check=full, and don't forget to --full-cleanup for moarvm | 13:59 | |
psch | well, perl6-valgrind-m exists | ||
timotimo | right, but i'm not sure it has --full-cleanup by default | ||
and it also doesn't allow you to give valgrind options | 14:00 | ||
really, someone who knows a bit about shell scripting ought to have a quick look at that thing | |||
psch | yeah | ||
Skarsnik | I need to rebuild moarvm ? | ||
timotimo | (that's how i spell "not me") | ||
no, you do not | |||
Skarsnik | or just edit the option | ||
timotimo | yeah, just put it into the shell script | ||
psch | okay this is just weird | 14:01 | |
the handler that gets invoked doesn't take any arguments, according to ArgsExpectetation | |||
but it apparently invokes something that needs the vm_ex | |||
...how does that work | |||
and how does the handler pass on the vm_ex when i create it in throwcatdyn_c | 14:02 | ||
timotimo | doesn't it get passed through the throwing mechanism? | 14:03 | |
psch | 'cause according to the backtrace it's the invokeDirect call in ExceptionHandling.java:215 that calls the handler | ||
timotimo just guessing | |||
psch | and that calls something that doesn't take args, the insightfully named method B9E5B486DDF0CC0DE86076CC049FDA9257D5E15D.qb_12146 | ||
Skarsnik | what | 14:04 | |
root@testperl6:~/piko# head /root/.rakudobrew/bin/perl6-valgrind-m | |||
#!/usr/bin/env perl | |||
# I AM RAKUDOBREW. ALSO POSSIBLY SPARTACUS. OUTLOOK CLOUDY, ASK AGAIN LATER. | |||
use strict; | |||
psch | oh. both hll routines that could refer to get their args with p6argvmarray | 14:05 | |
BrokenRobot | 0.o | ||
tadzik | it is self aware | ||
sorry | |||
BrokenRobot | :) | ||
psch | okay, yeah, i'm gonna stick with the "just always build a VMExceptionInstance" approach | 14:06 | |
timotimo | Skarsnik: are 2a recent and 2a - recent the same file? | ||
psch | it works, it doesn't seem to significantly impact performance, and i kinda understand it vOv | ||
Skarsnik | Yeah timotimo, I though it does not added the file or I am blind and add it again x) | 14:07 | |
timotimo | hehe. | ||
Skarsnik | hm, using the correct perl6-valgrind-m (and adding the full-cleanup stuff and co) I get Unhandled exception: failed to load library 'dynext/libperl6_ops_moar.so' | 14:11 | |
at <unknown>:1 (/root/.rakudobrew/moar-nom/perl6.moarvm:<dependencies+deserialize>) | |||
jnthn | gfldex: Probably, file as good reproduction instructions as you can unless you fancy further hunting. In the latter case, you can go to your MoarVM folder, and in src/gc/debug.h turn the MVM_GC_DEBUG define to 1, make clean, make install, and see if you get a different error. If yes, then a run under gdb (or your favorite tool) with a breakpoint set in MVM_panic and then getting the backtrace would also perhaps give some clues. Depends how mu | 14:12 | |
dalek | p: 32ad2eb | peschwa++ | src/vm/jvm/runtime/org/perl6/nqp/runtime/Ops.java: Always create a VMExceptionInstance in throwcatdyn_c. Otherwise we have cases in Rakudo where we expect a control exception, but get null instead. There's probably a more specific place where this could be solved, but it eludes me. |
14:13 | |
kudo/nom: 0295443 | peschwa++ | / (2 files): Add two debug ENV variables. Those are RAKUDO_JDB_PORT in perl6-jdb-server for setting the jdb port and RAKUDO_PRECOMP_NESTED_JDB, which, when set, uses perl6-jdb-server with increasing ports for precompilation. |
|||
kudo/nom: d505a8c | peschwa++ | tools/build/NQP_REVISION: Bump NQP_REVISION, for a getextype fix. This prevents reaching nqp::getextype calls without a valid argument. |
|||
Skarsnik | this take forever to run in valgrind x) | 14:27 | |
timotimo | of course it does :) | ||
but valgrind still has a very good pay-off for its cost | |||
Skarsnik | a libpath was removed for some reason in the valgrind script btw | 14:29 | |
timotimo | huh. | ||
Skarsnik | I edited the wrong file, I need to rerun this thing again x) | 14:30 | |
timotimo | oh | ||
Skarsnik | I mean the wrong perl6 script | 14:31 | |
not the valgrind shell script | |||
--libpath="/root/.rakudobrew/moar-nom/install/share/perl6/runtime" this was missing | 14:32 | ||
or whatever is generated from | |||
timotimo is a bit wary of rakudobrew's generated forwarder scripts | 14:34 | ||
Skarsnik | timotimo, gist.github.com/Skarsnik/03b970d2a...rind-trace | 14:43 | |
timotimo | ugh, no line numbers | ||
[Coke] | RT: 1340; CONC: 7; GLR: 6; JVM: 70; LHF: 1; LTA: 73; NYI: 28; OSX: 6; PERF: 16; POD: 3; PRECOMP: 4; RFC: 22; SEGV: 22; STAR: 1; TESTNEEDED: 14; TODO: 9; UNI: 5; WEIRD: 3 | 14:47 | |
lizmat | afk& | 14:48 | |
sno | [Tux]: do you have a moment wrt. DBD::File? (query?) | 14:53 | |
gfldex | moritz: please update Pod::To::HTML on docs.perl6.org to get github.com/perl6/Pod-To-HTML/commi...478f36407c | 15:10 | |
moritz | gfldex: doing it now | 15:11 | |
... done | 15:13 | ||
gfldex | thanks | ||
Tux_ | sno, yes, but I don't think this channel is the right spot | 15:40 | |
sno | Tux_: that's why I suggested a query | ||
BrokenRobot | ENODALEK | 16:18 | |
[Tux] | This is Rakudo version 2016.06-153-gd505a8c built on MoarVM version 2016.06-9-g8fc21d5 | 19:02 | |
test 16.186 | |||
test-t 9.331 | |||
csv-parser 17.269 | |||
dalek | ast: 98952f9 | (Zoffix Znet)++ | S06-traits/is-readonly.t: Fix broken plan |
19:05 | |
travis-ci | Rakudo build errored. Pepe Schwarz 'Bump NQP_REVISION, for a getextype fix. | 20:40 | |
travis-ci.org/rakudo/rakudo/builds/142773456 github.com/rakudo/rakudo/compare/c...05a8c4ad46 | |||
lizmat | m: say 0.rand # sorta expected to see Nil there | 21:29 | |
camelia | rakudo-moar d505a8: OUTPUT«0» | ||
timotimo | that'd be a strange edge-case, IMO | 21:35 | |
lizmat | well, it's an edge case that perhaps needs to be highlighted somehow | 21:36 | |
because usually it means that the value you want a rand of, was not initialized | |||
or somehow lost its value | 21:37 | ||
not really important, though | |||
timotimo | that sounds more like you want to warn when you use an actually undefined value | ||
i can see having the invocant be a number that varies between 0 and whatever | |||
dalek | kudo/nom: 55c359e | lizmat++ | src/core/ (2 files): Make Array use List.is-lazy No reason to special case Array |
21:38 | |
Zoffix | m: say 09 | 22:31 | |
camelia | rakudo-moar 55c359: OUTPUT«Potential difficulties: Leading 0 does not indicate octal in Perl 6. Please use 0o9 if you mean that. at <tmp>:1 ------> say 09⏏<EOL>9» | ||
Zoffix | m: say 08 | ||
camelia | rakudo-moar 55c359: OUTPUT«Potential difficulties: Leading 0 does not indicate octal in Perl 6. Please use 0o8 if you mean that. at <tmp>:1 ------> say 08⏏<EOL>8» | ||
Zoffix | PR to Fix: github.com/rakudo/rakudo/pull/812 | ||
And I'll do tests for rt.perl.org/Ticket/Display.html?id=119339 if/when the PR is merged. | |||
Oh, wait. Made a booboo. | 22:34 | ||
($value can be more than 1 digit) | 22:35 | ||
travis-ci | Rakudo build passed. Elizabeth Mattijsen 'Make Array use List.is-lazy | 22:36 | |
travis-ci.org/rakudo/rakudo/builds/142887649 github.com/rakudo/rakudo/compare/d...c359e8e448 | |||
Zoffix | K, now it's good: github.com/rakudo/rakudo/pull/813 | 23:13 | |
gfldex | Zoffix: if you got the time please review github.com/perl6/Pod-To-HTML/commi...c87b589b26 | 23:33 |