[00:51] *** sena_kun joined [00:53] *** Altai-man left [00:53] *** ceibal joined [01:19] *** ceibal left [02:55] *** sena_kun left [03:27] *** AlexDaniel` left [03:28] *** MasterDuke left [03:35] *** AlexDaniel` joined [06:47] *** MasterDuke joined [06:59] *** patrickb joined [07:10] good *, #moarvm [07:20] *** zakharyas joined [07:22] *** zakharyas1 joined [07:24] *** zakharyas left [07:56] *** leont joined [08:07] *** MasterDuke left [08:12] *** AlexDaniel` left [08:20] *** AlexDaniel` joined [08:22] *** patrickb left [08:35] *** sena_kun joined [08:51] *** Altai-man joined [08:54] *** sena_kun left [09:05] good morning [09:05] nwc10: Remind me, is anything blocking on me for the hash branch at this point? Will have some time to look at it soon if so. [09:16] I'm not aware of anything blocking [09:16] I believe that I have made commits that answer your questions [09:16] releasable6: status [09:16] *don't* merge it (as-is) because it has that commit message that starts 'XXX' [09:16] jnthn, Next release in ≈4 days and ≈9 hours. 2 blockers. Changelog for this release was not started yet [09:16] jnthn, Details: https://gist.github.com/74a76b4b4b4e61b6edc2c4b41ae63b4e [09:17] *nod* [09:17] and I have a suspicion that we should wait for 4 days and 10 hours before merging it :-) [09:17] the NQP tests (and implied NQP language spec) PR is also "interesting" if you have time [09:18] I was about to go out shopping. (back in an hour I guess) [09:18] we're fine for beer, but critically low on sherry [09:18] (and milk and other stuff) [09:18] oh deer [09:18] *dear [09:18] bah [09:18] use more 'coffee' ? [09:19] Whenever I drink sherry my thoughts are "I wish this was port instead" :) [09:19] I have some white port, but not the red stuff [09:19] Andrea's dad has ruby port, but I think that he mostly uses it for cooking. [09:20] anyway, I'm told that sherry casks are always in short supply for whisky making, so I'll keep doing my bit to help [09:20] (I have no idea how accurate this statement is. I was told it by someone who IIRC had been told it at a whisky tasting. It might be true.) [09:24] Ah, the red stuff is what I like :) [10:58] *** benchable6 left [10:58] *** quotable6 left [10:58] *** greppable6 left [10:58] *** coverable6 left [10:58] *** statisfiable6 left [10:58] *** reportable6 left [10:58] *** releasable6 left [10:58] *** bloatable6 left [10:58] *** unicodable6 left [10:58] *** bisectable6 left [10:58] *** linkable6 left [10:58] *** squashable6 left [10:58] *** committable6 left [10:58] *** shareable6 left [10:58] *** tellable6 left [10:58] *** sourceable6 left [10:58] *** evalable6 left [10:58] *** nativecallable6 left [10:58] *** notable6 left [10:58] *** releasable6 joined [10:59] *** coverable6 joined [10:59] *** sourceable6 joined [10:59] *** bisectable6 joined [10:59] *** benchable6 joined [10:59] *** greppable6 joined [10:59] *** quotable6 joined [11:00] *** unicodable6 joined [11:00] *** statisfiable6 joined [11:00] *** tellable6 joined [11:00] *** linkable6 joined [11:01] *** committable6 joined [11:01] *** nativecallable6 joined [11:01] *** squashable6 joined [11:01] *** evalable6 joined [11:01] *** notable6 joined [11:01] *** bloatable6 joined [11:01] *** reportable6 joined [11:01] *** shareable6 joined [11:15] *** zakharyas1 left [11:24] *** AlexDaniel left [11:49] jnthn: also, I don't know how to (so have not) tested the debug server or the heap profiler, which IIRC get touched as a side effect of hashes [12:30] *** zakharyas joined [12:30] Looked over the commits; agree they address all my comments. [12:30] * [Coke] wonders if whisky vs. whiskey is a UK/US thing. [12:34] Hmm...I just installed App::MoarVM::HeapAnalyzer and tried to run it on the produced heap profile output and it reports malformed UTF-8 [12:34] timotimo: Any idea about ^^? [12:38] [Coke]: it's certainly a Scotland vs Ireland thing [12:38] jnthn: \o/ [12:39] The debugger seems busted though [12:39] and also, I didn't have any better suggestions for the debug server thing than I'd already put in the comment in the code (which appeared near your question to timotimo ) [12:39] :-( [12:39] I don't know enough to fix that. (As in, even where to start) [12:41] Process finished with exit code 139 (interrupted by signal 11: SIGSEGV) [12:42] I don't even know where TFM is for the debug server, so I don't know how to start it [12:42] There's a command line client but I don't know how to use it :P [12:42] so you use netcat? [12:42] No, I use it from the IDE :) [12:47] https://gist.github.com/jnthn/bef407c806db596ce16ecd042f869c70 [12:47] Seems to happen when it hits a breakpoint [12:47] Ah, well, more to the point, when it is handling a follow-up request after hitting a breakpoint [12:48] this is a regression in the branch? [12:49] hashtable=0x0 [12:50] Well, I think that thing can legitimately be null' [12:50] And indeed adding a null check there fixes things [12:50] yes, and IIRC NULL is a "valid" UT hash [12:52] Yeah, I think so to [12:52] *** sena_kun joined [12:52] Or at least, not distinguishable from an empty hash [12:52] Shall I push a commit fixing it? [12:52] yes please [12:53] *** Altai-man left [12:54] ¦ MoarVM/AAAA-A-better-hash: 2af3ffbf60 | (Jonathan Worthington)++ | src/debug/debugserver.c [12:54] ¦ MoarVM/AAAA-A-better-hash: Don't try to use a NULL debug locals hash [12:54] ¦ MoarVM/AAAA-A-better-hash: [12:54] ¦ MoarVM/AAAA-A-better-hash: Under the previous hash implementation, the hash pointer being NULL was [12:54] ¦ MoarVM/AAAA-A-better-hash: interpreted as an empty hash, and thus a lookup would just come back [12:54] ¦ MoarVM/AAAA-A-better-hash: NULL and there was no problem. Under the new one, we should NULL-check [12:54] ¦ MoarVM/AAAA-A-better-hash: it explicitly. Fixes a crash in the debug server. [12:54] ¦ MoarVM/AAAA-A-better-hash: review: https://github.com/MoarVM/MoarVM/commit/2af3ffbf60 [12:55] I looked if there's any other instances of the problem with the debug locals, but it seems that was the only one [12:56] *** angelds joined [12:56] I had a look in that file, and couldn't spot any others [12:56] OK [12:56] I think for now that's all I have :) [12:57] time, or bugs? [12:57] Bugs. [12:57] I have time but want to spend it on my RakuAST grant, which I barely touched in the last month, though mostly 'cus I had the audacity to go on vacation :) [12:59] jnthn: speaking of which, it's mid of the month, and nominally time for the grant report [12:59] expect a report with pictures of Swiss hills? [12:59] haha, yeah... [13:00] jnthn: there's bascially two options: 1) publish a "I did nothing" grant report, or 2) we move the grant report the start of the month, and I'll publish one start of September [13:00] <[Coke]> a grant report of 'was busy with things including vacation' is an acceptable report. :) [13:00] moritz: I was going to write it at the end of this week and account for what I did this week in it so it'll be mildly more exciting :) [13:00] jnthn: works fine for me [13:07] *** angelds left [13:18] *** raku-bridge left [13:18] *** raku-bridge joined [13:18] *** raku-bridge left [13:18] *** raku-bridge joined [14:35] *** AlexDaniel joined [14:35] *** AlexDaniel left [14:35] *** AlexDaniel joined [15:56] *** MasterDuke joined [16:51] *** Altai-man joined [16:53] *** sena_kun left [17:38] *** zakharyas left [19:41] *** zakharyas joined [20:39] *** zakharyas left [20:52] *** sena_kun joined [20:53] *** Altai-man left [21:22] *** squashable6 left [21:22] *** squashable6 joined [22:42] *** kawaii left [22:54] *** kawaii joined [23:18] *** squashable6 left [23:19] *** squashable6 joined [23:19] *** squashable6 left [23:21] *** squashable6 joined [23:30] *** MasterDuke left