[09:59] <Geth> ¦ MoarVM/main: f27687e211 | ab5tract++ (committed using GitHub Web editor) | src/6model/reprs/VMArray.c

[09:59] <Geth> ¦ MoarVM/main: Leave a VMArray unchanged when pop or unshift is given the wrong register kind (#2078)

[09:59] <Geth> ¦ MoarVM/main: 

[09:59] <Geth> ¦ MoarVM/main: pop decremented elems before the switch that checks the register kind,

[09:59] <Geth> ¦ MoarVM/main: and that check throws before zero_slots clears the slot. So nqp::pop_i on

[09:59] <Geth> ¦ MoarVM/main: an object array died with "pop expected object register" with the last

[09:59] <Geth> ¦ MoarVM/main: element already gone from the array, while its slot still held the

[09:59] <Geth> ¦ MoarVM/main: object pointer. VMArray_gc_mark marks only the first elems slots, so a

[09:59] <Geth> ¦ MoarVM/main: <…commit message has 30 more lines…>

[09:59] <Geth> ¦ MoarVM/main: review: https://github.com/MoarVM/MoarVM/commit/f27687e211

[10:43] <ShimmerFairy> ab5tract: Hang on a minute, why are you pushing these AI-generated updates to the main branch now, instead of issuing another PR? I don't know for certain what MoarVM's policies on AI or direct pushes to main are, but this seems like something people would like to review first, no?

[10:44] <lizmat> ShimmerFairy: *I* did the merge

[10:44] <lizmat> and it was a PR

[10:44] <lizmat> and I reviewed it

[10:45] <lizmat> https://github.com/MoarVM/MoarVM/pull/2078

[10:45] <ShimmerFairy> Oh, I'm sorry. Nothing about Geth's messages or the linekd github page made it clear it was a PR. (I thought the #2078 was a bug report number)

[10:46] <lizmat> this one was pretty clear (at least to me)

[10:46] <lizmat> and MoarVM was clearly in error in the behviour

[10:46] <ShimmerFairy> (also, it appears Geth happened to miss listing this PR earlier, funny enough)

[10:46] <lizmat> other PRs that ab5tract added yesterday I'm less sure about

[10:47] * lizmat checks the webhooks

[10:48] <ShimmerFairy> Yeah, I'm not 100% against AI or anything (more like 50% perhaps?), I just mistakenly thought that they accidentally pushed to main or something, and esp. given the LLM assistance wanted to make sure it didn't slip by unnoticed.

[10:50] <lizmat> well, in this case I thought it made sense, as it was not ab5tract's primary goal

[10:50] <ab5tract> Nope I don’t have write access to moarvm so those are all merges

[10:51] <lizmat> they're working on a port of MoarVM to Zig and this came out of porting the logic to Zig

[10:51] <ShimmerFairy> Alright, that's good to know in the future. Like I said, just got the wrong impression from how the fix journeyed into main.

[10:51] <ab5tract> There were two batches so maybe one from the earlier batch was brought in by lizmat

[10:52] <ShimmerFairy> Also, about that zig work, I haven't heard of it before. Is there a plan to port MoarVM to zig I don't know about, or is it just like a project for an alternate version or something?

[10:52] <ab5tract> Yeah no worries just clarifying. I appreciate the shout out as i would share the same concerns

[10:52] <lizmat> it's a private project by ab5tract afaik

[10:52] <ab5tract> ShimmerFairy: just shaking the trees to see what falls out. If all that comes of it is a safer moarvm I’m fine with that

[10:53] <ab5tract> I find zig code easier to read than C so it’s primarily education motivated

[10:54] <ShimmerFairy> I'm vaguely aware of zig being a sorta-backwards-compatible C, with the goal of being safer than it, so seems like a good choice for tree-shaking. (AFAIK Rust is considered the champion for memory safety, but is *way* less C-like ofc.)

[11:13] <Geth> ¦ MoarVM/main: 2041fa1b69 | ab5tract++ (committed using GitHub Web editor) | src/6model/reprs/VMArray.c

[11:13] <Geth> ¦ MoarVM/main: Refuse VMArray splices from sources it cannot copy from (#2079)

[11:13] <Geth> ¦ MoarVM/main: 

[11:13] <Geth> ¦ MoarVM/main: asplice takes the source's element count through the source's own REPR,

[11:13] <Geth> ¦ MoarVM/main: so any object with elems gets through, but copy_elements then reads the

[11:13] <Geth> ¦ MoarVM/main: source as a VMArray: for any other REPR it sets the source's REPR data to

[11:13] <Geth> ¦ MoarVM/main: NULL, skips the fast path and reads slot_type through that NULL.

[11:13] <Geth> ¦ MoarVM/main: nqp::splice(nqp::list(1, 2, 3), nqp::hash('k', 1), 1, 0) crashed with

[11:13] <Geth> ¦ MoarVM/main: <…commit message has 68 more lines…>

[11:13] <Geth> ¦ MoarVM/main: review: https://github.com/MoarVM/MoarVM/commit/2041fa1b69

[11:35] <Geth> ¦ MoarVM/main: 5249be7aa7 | ab5tract++ (committed using GitHub Web editor) | src/strings/normalize.c

[11:35] <Geth> ¦ MoarVM/main: Fix the output arrays of nqp::normalizecodes and nqp::strtocodes (#2083)

[11:35] <Geth> ¦ MoarVM/main: 

[11:35] <Geth> ¦ MoarVM/main: MVM_unicode_normalize_codepoints builds the normalized code points in a

[11:35] <Geth> ¦ MoarVM/main: buffer of result_alloc 32-bit elements and then hands that buffer to the

[11:35] <Geth> ¦ MoarVM/main: output array, but it set the array's ssize to result_pos *

[11:35] <Geth> ¦ MoarVM/main: sizeof(MVMuint32): the number of elements produced, in bytes. ssize is

[11:35] <Geth> ¦ MoarVM/main: the capacity in elements, so the array claimed about four times the

[11:35] <Geth> ¦ MoarVM/main: <…commit message has 29 more lines…>

[11:35] <Geth> ¦ MoarVM/main: review: https://github.com/MoarVM/MoarVM/commit/5249be7aa7

[12:18] *** lizmat left
[12:18] *** rakkable left
[12:18] *** lizmat joined
[12:19] *** rakkable joined
[13:57] <ab5tract> lizmat++

[13:57] <ab5tract> For taking a look at these

[13:58] <lizmat> I've looked at all, but these were the only ones I was confident enough to merge

[14:02] <ab5tract> Yeah I figured that was the case. Much appreciated

[14:02] <lizmat> I hope that MasterDuke17 ShimmerFairy patrickb will find the time to have a look at the others

[14:49] *** rakkable joined
[14:50] *** Geth left
[16:22] *** ab5tract left
[16:24] *** ab5tract joined
[16:27] *** Geth joined
[19:45] *** jdv left
[19:45] *** jdv joined
[23:41] *** disbot left
[23:41] *** disbot5 joined
