|
2009 -- the year of November. <november-wiki.org> <github.com/viklund/november> <irclog.perlgeek.de/november-wiki> <nopaste.snit.ch> Set by moderator on 10 August 2009. |
|||
|
07:56
szabgab joined
08:16
szabgab joined,
arthur-_ joined,
mj41 joined,
omega joined
08:45
masak joined
09:21
sri_kraih joined
10:54
ihrd joined,
ihrd left
11:36
ihrd joined
11:37
ihrd left
12:02
ruoso joined
|
|||
| masak | arthur-_: pulled. | 12:16 | |
| arthur-_ | masak: thanks | ||
| masak | arthur-_: if you discover a small typo and haven't pushed yet, there's "git commit --amend" to save you. | 12:17 | |
| arthur-_ | masak: ok noted | ||
| masak reviews the commits themselves | 12:18 | ||
| arthur-_ | masak: I found get '/hello/:name' => -> $n { a bit ugly | 12:19 | |
| changed it to get '/hello/:name' answers -> $n { | |||
| if you have any better idea ... | |||
| masak | I'll think about it. | ||
| I agree that '=> ->' doesn't read extremely well. | 12:20 | ||
| arthur-_: um, if I read the code right, it currently calls all handlers that match. is that intentional? | 12:21 | ||
| arthur-_ | yep, i'll correct that once i start writing tests | 12:22 | |
| masak | nice. | ||
| I already wrote one spectest, but it presupposes a Web::MockRequest, which I haven't written yet. | 12:23 | ||
| arthur-_ | ( i don't do request.finish() either ) | ||
| masak | hm, no. | 12:26 | |
| I can fix that if you want. | |||
| arthur-_ | i'll do it a bit later, i finish work in a few hours | 12:27 | |
| masak | oki. | ||
| in the meantime, I'll move lib/Astaire/Astaire.pm to lib/Astaire.pm, so that any script that includes Astaire won't have to do 'use Astaire::Astaire' :) | 12:28 | ||
| arthur-_ | ok | 12:29 | |
| masak | (so, make sure to pull that change later) | 12:30 | |
|
14:49
szabgab joined
15:33
arthur-_ joined
|
|||
| arthur-_ | masak: Web::Response.write wants Str, so post '/test' answers { 2 + 2 }; does not work | 15:50 | |
| cat we say that write accepts Any ? | 15:51 | ||
| s/cat/can/ | |||
| masak | yes. | 15:52 | |
| maybe simply remove the typing from that one. | |||
| arthur-_ | ok, I do it | ||
| masak | arthur-_++ | 15:53 | |
| arthur-_ also makes Web::Response a rw as in racks spec, so we can haz 404 | 15:58 | ||
| masak | sorry, making what in Web::Response rw? | 16:00 | |
| arthur-_ | status | 16:01 | |
| sorry :) | |||
| ok 9 - inexistant page gives 404 error | |||
| masak | :) | ||
| nice. | |||
| s/inexistant/nonexistent/, though. | 16:02 | ||
| arthur-_ | thanks | ||
| inexistant == french ^^ | |||
| masak | oui, I suspected as much. :) | 16:04 | |
| arthur-_ | masak: pull request | 16:19 | |
| masak | arthur-_: thank you. will look at it. | 16:21 | |
| arthur-_ | k. | 16:22 | |
| masak | hm, github says my fork queue is empty. I'll have to do it manually. | 16:24 | |
| arthur-_: hm, your commits seem to recreate the astaire.pod file with a small 'a'. | 16:27 | ||
| nowadays, it's called Astaire.pod, for spectest reasons. | |||
| arthur-_ | can you remove it ? | ||
| masak | also, I'd recommend putting tests in t/spec, and not directly in t/ | ||
| arthur-_ | i did not touch it intentionally, probably just an error | 16:28 | |
| masak | ok, then I'll remove it. | ||
| arthur-_ | ok about t/spec, i move the file | ||
| masak | great. | ||
| there, pulled, changed, and pushed. | 16:29 | ||
| arthur-_: I just want to say that it's really nice working with you. :) | 16:30 | ||
| arthur-_ | masak: thx ^^ | 16:32 | |
| arthur@aquarelle ~/d/s/c/web> git rm t/astaire/ | 16:33 | ||
| fatal: pathspec 't/astaire/' did not match any files | |||
| ( rm -r is not better ) | |||
| ( nice working with you too ) | 16:34 | ||
| masak | I removed it for you, so you just need to pull. | 16:35 | |
| gotta go now. | |||
| arthur-_ | ok | ||
| masak | we're going swimming. | ||
| arthur-_ | have fun | ||
| masak | thanks. | ||
| see you around! | |||
| arthur-_ | yep | ||
|
19:14
sri_kraih joined
20:19
lichtkind joined
22:15
p6eval joined
23:44
ihrd joined
|
|||