Parrot 6.4.0 "Double-eyed Fig Parrot" | parrot.org/ | Log: irclog.perlgeek.de/parrot | #parrotsketch meeting Tuesday 19:30 UTC
Set by moderator on 25 May 2014.
dalek rrot/rurban/pmc2c_orig: 116764c | rurban++ | src/pmc/ (11 files):
[pmc] fix wrong C99 UNUSED macros and add a few :no_wb

class,imccompiler,key,namespace,nci,opcode,packfileview,parrotlibrary, sockaddr,socket,timer
00:07
03:03 rurban joined 03:24 Tene joined 05:05 rurban joined 05:07 rurban1 joined 06:08 rurban joined 06:52 FROGGS joined 07:09 rurban joined 07:11 rurban1 joined 07:20 rurban joined 08:21 rurban joined 08:42 rurban joined 08:53 basiliscos joined 09:47 Psyche^ joined 09:51 jsut joined 10:19 rurban1 joined 10:27 rurban joined 11:31 rurban joined 11:34 rurban1 joined 12:35 rurban joined 13:36 rurban joined 13:48 bluescreen joined 13:50 bluescreen_ joined 14:32 Chirag joined 14:38 rurban joined 15:13 rurban joined
Chirag Hey! 15:34
rurban: I merged your changes into my branch..
t/examples/shootout.t failed 8 tests of 20 for me..
make fulltest gives 15:35
get_pmc_keyed() not implemented in class 'Continuation'
current instr.: 'generate_code_gcc' pc 951 (tools/dev/pbc_to_exe.pir:318)
called from Sub 'main' pc 129 (tools/dev/pbc_to_exe.pir:49)
rurban_ Your branch has a few mangled commits. but it is not ready yet. yes 15:39
I merged your branch on top of mine 15:40
f12030a1f4 has a wrong message
Chirag I copied your last commit message 15:41
rurban_ The fix would be to add all WB's until the etsts are fixed and then remove the ones which are really not needed until the tests break again. 15:42
Chirag hmm.. make fulltest right? 15:43
rurban_ make test is enough. fulltest only for the final push (testing coding standards and all optimizations) 15:45
Chirag ok..
rurban_ and the regex sample I added to the commit message
t/examples/shootout.t 15:46
Chirag yes that fails 15:47
how do I repair my commit messages? rebase it to your branch? 15:48
rurban_ For me prove -j4 t/op/gc.t t/examples/shootout.t t/pmc/*.t is enough to catch all errors
yes
Chirag gc.t and pmc/*.t pass for me 15:49
rurban_ My fixup commit is also wrong. This needs to be merged into the big single pmc2c commit
Interesting. A 64bit ubuntu or 32bit?
Chirag ubuntu 64
rurban_ I got a debian 64bit
For me I get: t/op/gc.t SEGV at 19, t/pmc/fixedstringarray.t SEGV at 40 and t/pmc/namespace-old.t FAIL with 27-30 15:50
But we are very close 15:51
Chirag my lack of memory creates a difference?
rurban_ Ah yes, probably 15:52
I'd need to set my ulimits
Chirag i have 3gb .. maybe u can set that 15:53
rurban_ But the compiler is good now, just the annotations are wrong. I should add a pmc2c -v flag to print the WB messages
I commented it out for now 15:54
Chirag there aren't any "need PARROT_GC_WRITE_BARRIER" messages
for satisfying the tests, I add WBs to all functions without considering anything? 15:57
rurban_ uncomment the warnings, remove all :no_wb and convert the needed return to RETURN (and fix wrong UNUSED)
UNUSED needs to be after the declarations 15:58
make src/pmc/<pmc>.i to see the preprocessed C code
into what code UNUSED expands
Chirag thanks.. will do that 15:59
rurban_ Should be doable in two days or so 16:00
But I'm a bit faster
Chirag I wonder if I am taking too long to finish this task? 16:01
rurban_ No, we are way ahead :) no worries 16:11
You just need to get practice with git and our coding standards. This is normal 16:12
Chirag nice! :).. will still try to keep up the pace! 16:13
16:45 Chirag joined 17:49 FROGGS joined 19:08 rurban joined 22:01 cottoo joined