Parrot 6.4.0 "Double-eyed Fig Parrot" | parrot.org/ | Log: irclog.perlgeek.de/parrot | #parrotsketch meeting Tuesday 19:30 UTC
Set by moderator on 25 May 2014.
00:24 rurban joined 00:59 rurban joined 01:09 davidfetter joined 01:26 FROGGS_ joined 02:02 rurban joined 03:03 rurban joined 03:05 rurban1 joined 03:51 bighugedog joined 04:06 rurban joined 04:18 rurban joined 05:19 rurban joined 05:56 woosley joined 06:21 rurban joined 06:24 FROGGS joined 07:24 kshannon joined, mtj joined, cxreg joined, smash joined, dngor joined, p6eval joined, GeJ joined, ggherdov__ joined, pmichaud_ joined, Coke joined, Maddingue joined, Timbus_ joined, atrodo joined, Util joined, Tene joined, cottoo joined, ingy joined, rblackwe joined, cooper joined, autark_ joined, ivan joined, Khisanth joined, sorear joined, Patterner joined, FROGGS joined, rurban joined, basiliscos joined, dalek joined, jsut joined, Liz joined, woolfy joined, slavorg joined, rurban_ joined, TonyC joined, cosimo joined 08:23 rurban joined 09:06 TonyC joined 09:23 rurban joined 10:24 rurban joined 11:10 dalek joined 11:25 rurban joined 12:01 FROGGS joined 12:15 rurban joined 13:16 particle joined 14:15 rurban joined 14:17 particle joined 15:00 rurban joined
rurban_ How is it going? 15:08
15:28 Chirag joined
Chirag Hey! I realized after my message that the removed WB was for dest.. reverted back :) 15:30
a*.pmc, b*.pmc, c*.pmc modified and verified.. 15:33
81/95 to go :) 15:34
rurban_ you had to do some changes? Can you post a gist or push it? 15:37
Chirag I ll push it 15:38
give me 5 min..
rurban_ sure. I thought I got almost everything right 15:39
Chirag i changed some annotations mostly 15:40
i couldnt commit because it said branches have diverged.. so i directly pushed it.. i guess that doesnt work 15:57
rurban_ first rebase onto my latest changes, and then push to yours 16:02
you need to push -f
Chirag i should first create a patch? else i might lose my changes? 16:05
rurban_ first commit your changes, then rebase 16:15
because I already fixed everything 16:16
Chirag pushed.. 16:19
rurban_ yeah, seems to be right. just the test_*.c needs to be ignored 16:36
the .i also
did you test it already or still working? 16:37
Chirag only checked 14 .. many remaining 16:39
rurban_ uuh 16:40
"The 4 eye principle"
Chirag I ll do it right? 16:41
might take a while..
rurban_ wait a few minutes 16:42
still testing and looking. 1st look looked right
Chirag ok 16:43
rurban_ yeah, and t/op/gc.t passes now! You found it!
you just need to remove the 2 wrong files and rebase
Chirag :D .. which one was it? 16:45
rurban_ no idea yet 16:46
I'm a bit busy now with work, and will check later 16:47
Chirag one quick question
rurban_ sure
Chirag in complex.pmc .. MULTI PMC *add should have no_wb
just how VTABLE PMC *add behaves?
rurban_ because SELF is read-only, only dest is written to 16:48
and dest is created within the method
we only read from SELF here 16:49
WB are only needed when SELF is written to
Chirag ok.. so MULTI methods get no_wb based on Vtable.. but how are MULTI different from VTABLE? 16:50
rurban_ MULTI has nothing to do with that 16:51
MULTI are methods on 2 ops with varying types
Not on 2 ops, on 2 args 16:52
Chirag oh.. ok
i ll continue modifying the others
rurban_ good 16:56
17:34 davidfetter_ joined 17:58 basiliscos joined
Chirag rurban: in fixedpmcarray.pmc -> set_number_keyed() , in the function we have one call to set_number_keyed_int() and one RECURSIVE call to itself... So this is like inserting at the end of a list?? .. Also, I can give this function its own WB and make others depending on it, manual ?? 18:47
rurban_ I'll look... 18:52
Interesting... 18:53
Looks like a bug to me 18:54
Chirag the recursive part? 18:55
rurban_ yes, I'll debug into it 18:56
dalek rrot/rurban/pmc2c_orig2: bf50d89 | ZYROz++ | src/pmc/ (9 files):
[pmc] Changed wrong WB annotations
18:58
rrot/rurban/pmc2c_orig2: 9b1a789 | rurban++ | .gitignore:
.gitignore: add local .perldb helper

so that git clean -dxf will not wipe it.
rrot/rurban/pmc2c_orig2: 2055f70 | rurban++ | src/pmc/complex.pmc:
[pmc] no_wb for Complex.add
rurban_ I fixed now your wrong files
the *.i and test_* stuff
Chirag yeah i removed them too
fixedintegerarray.pmc had methods calling each other in a chain so only the first one had a WB (auto) .. others had a manual_wb .. But that file is fine since no recursion 19:00
rurban_ nope, it's correct. Parrot_FixedPMCArray_set_number_keyed_int calls Parrot_FixedPMCArray_set_pmc_keyed_int 19:02
there are several tests in t/pmc/fixedpmcarray.t 19:03
if the methods are calling each other and the last setter already has a WB the cqalling method doesn't need one. => :manual_wb 19:04
but now t/op/gc.t fails again. maybe my last testrun was flowed 19:05
Chirag passes for me 19:06
rurban_ good. I'll clean and run again 19:07
I renamed my branch to have the same name as yours: rurban/pmc2c_orig2-gh1069
Chirag do I need to change my remote or something? 19:09
rurban_ : I got a working build! :D ... 19:22
rurban_ nope 19:25
great. the shootout example also?
Chirag earlier 8 tests failed .. now 3
rurban_ I try to get my benchm,ark machine into shape, currently it's too unstable to get proper timings
Chirag just pushed my changes.. 19:26
rurban_ maybe we can even merge it his week, great! better than expected 19:28
Util #ps time 19:31
19:51 particle joined
Chirag YAPC::EU is in August.. My university officially requires me to be doing a thesis/internship from Aug-Dec .. thats not possible either.. 20:08
rurban_ ok
But it's only 3 days.
You can show it as your new affiliation to Google :) 20:09
Chirag :)
rurban_ There's also Google meeting planned in California (with full travel costs reimbursed), but only 2 people are allowed per organisation 20:10
and Mark already said he wants to go 20:11
Chirag I saw that.. i guess it's for mentors and admins
Util Correct; for mentors and/or admins. 20:13
Chirag I have got an acceptance for carrying out my thesis work at ETH Zurich's CV lab.. but I am planning to postpone it to the second semester.. else Bulgaria would have accessible..
been*
rurban_ ETH is better
Mentors and admins only? Ok, so maybe I can go. But I don't want to. They are always bothering me to work for them, I don't want to 20:14
Chirag :D
I will confirm the waiting time for a US visa .. Else I will try to figure out the logistics for Bulgaria 20:23
rurban_ Good. 20:24
2 weeks will be not enough I'm sure for the embassy in Hyderabad 20:25
But Bulgaria should be possible if you've got health care coverage.
Chirag I dont know if its for $50,000 20:26
rurban_ Maybe they can upgrade it for a week. We'd need to know how much they'll charge for that. 50.000 is a small sum for this kind of insurance 20:27
(2 days hospital) 20:28
Chirag I ll have to find out how this works.. My dad's in the army.. So it's covered by the govt..
rurban_ Sounds good. I'll ask for our sponsorship if they can cover that (Send a newbie at #yapc) 20:29
Chirag great! 20:30
rurban_ Upsana wanted to come to YAPC::US but her US Visa was declined, said #yapc 20:32
Chirag Was Upasana a gsoc student last time? 20:35
rurban_ I cannot really remember 20:39
blogs.perl.org/users/upasana/
It was this gnome.org/opw/ GNOME Outreach Program for Women
Chirag oh.. 20:40
rurban_ She is in Bangalore
Oh no, she is in Delhi says her facebook page 20:43
Chirag ah .. maybe I can ping her.. 20:44
rurban_ www.facebook.com/upasana.shukla.94
and plus.google.com/102847440526822202929/posts 20:45
Chirag are you planning to attend yapc::eu?
rurban_ That is the perl program I thought of www.send-a-newbie.enlightenedperl.o...tions.html 20:46
I'm not sure yet
If you want to come to Sofia, fill out this form. They'll handle the money 20:47
Chirag thats great! 20:48
but I will first try to be sure on my part .. insurance, thesis/internship, and it would be my first time abroad :D 20:49
rurban_ blogs.perl.org/users/shadowcat_mdk/...apcna.html 20:51
Chirag aww.. if only I had known about the conference before 20:53
rurban_ upasana applied to this one 20:55
but got denied by us customs 20:56
they are too afraid that she'll just stay here and work illegally
So I guess they'll deny you too. Your are too qualified 20:57
Chirag oh..
I wonder if it will be difficult when I apply for my masters 20:59
rurban_ yes
it might depend on their mood. I don't like them. 21:00
Chirag but I think students visa is relatively easy .. My friends have been accepted at GAtech, UCSD etc..
rurban_ students yes. just business, tourist 21:01
young, bright, without family at home. 21:02
Chirag I will leave now.. will continue with pmc's tomorrow.. Bye! 21:04
rurban_ thanks, bye 21:05
21:05 rurban joined
rurban_ hmm, for me t/op/gc.t still fails 21:16
dalek rrot/rurban/pmc2c_orig2-gh1069: 3e7b3a9 | rurban++ | lib/Parrot/Pmc2c/PCCMETHOD.pm:
[pmc2c] support RETURN(PMC* const ...) and (INTVAL pos>>32)

const is no variable name. allow full expressions as return value, not just names.
just skip ptr dereferences /^\\**/. Note that the * return syntax is flawed, as we should support both cases, return *ptr; and return ptr; But we get away with it as we return only return (decl)*ptr and return (decl*)ptr;
21:20
rrot/rurban/pmc2c_orig2-gh1069: bf3896f | rurban++ | t/pmc/fixedstringarray.t:
[test] move test_gc to the end of t/pmc/fixedstringarray.t

all other tests pass fine, even with wrong write barriers
rrot/rurban/pmc2c_orig2-gh1069: 6c4b317 | rurban++ | / (2 files):
[tools] add tools/dev/vgp_old using parrot_old

building parrot_old is much faster than parrot, when tracing leaks
rrot/rurban/pmc2c_orig2-gh1069: d89d02e | rurban++ | src/gc/system.c:
[gc] simplify the stack scanning loop

just inc the stack ptr reverse the hi <=> lo markers to make sense comment the unsafe ptr dereference here, where asan and valgrind do complain.
rrot/rurban/pmc2c_orig2-gh1069: ee33e2f | rurban++ | src/pmc/task.pmc:
Revert "[pmc] task: WB related errors"

This reverts commit ab201b1657795217c95c7f62c8f1bf71418687b0.
rrot/rurban/pmc2c_orig2-gh1069: 2d82f76 | rurban++ | src/ (88 files):
[pmc] Fixup most WBs. :no_wb for all non-writers, ... [1/2]

  :manual_wb on VTABLE method calls on SELF which to a WB (avoid duplicates).
See new description at github.com/parrot/parrot/issues/1069
rrot/rurban/pmc2c_orig2-gh1069: f6bc0cc | rurban++ | src/pmc/ (41 files):
[pmc] Fixup most WBs [2/2]

  :no_wb on non-writers, :manual_wb on VTABLE method calls on SELF which to a WB (avoid duplicates).
See new description at github.com/parrot/parrot/issues/1069 Some UNUSED missing.
Still the same 2 regressions: t/op/gc.t (Wstat: 11 Tests: 19 Failed: 0)
   Non-zero wait status: 11
   Parse errors: No plan found in TAP output
t/pmc/namespace-old.t (Wstat: 1024 Tests: 38 Failed: 4)
   Failed tests: 27-30
   Non-zero exit status: 4
rrot/rurban/pmc2c_orig2-gh1069: 287f951 | rurban++ | src/pmc/ (10 files):
[pmc] add more UNUSED for :no_wb methods

also remove a wrong task WB
rrot/rurban/pmc2c_orig2-gh1069: 17396b2 | rurban++ | src/pmc/class.pmc:
[pmc] fix class WBs, detected by ZYROz

isa_pmc, freeze have a manual WBs thawfinish, remove_attribute indirectly via build_attrib_index name needs one for the write case
rrot/rurban/pmc2c_orig2-gh1069: 3aaa825 | rurban++ | lib/Parrot/Pmc2c/PCCMETHOD.pm:
[pmc2c] fix del_namespace. require {} around WB return

there exist many methods without proper {} blocks for RETURN().
grep -B1 "RETURN(" src/pmc/*.pmc|grep -A1 "if "|grep -v "{" such as: src/pmc/namespace.pmc- if (PMC_IS_NULL(ns)) src/pmc/namespace.pmc: RETURN(void);
rrot/rurban/pmc2c_orig2-gh1069: 3009168 | rurban++ | src/pmc/ (7 files):
[codingstd] fix trailing whitespace

and remove one too much WB in pmclist.shift_pmc
parrot/rurban/pmc2c_orig2-gh1069: b06fb01 | ZYROz++ | src/pmc/ (9 files):
parrot/rurban/pmc2c_orig2-gh1069: [pmc] Changed WB annotations a*-c*.pmc
21:22 dalek joined 21:58 rurban joined 22:47 basiliscos joined 23:38 rurban joined