dalek | kudo/nom: 0a90a5e | ugexe++ | src/core/CompUnit/Repository/Installation.pm: Cleanup short-name folders when empty |
00:38 | |
kudo/nom: 88ceabc | (Zoffix Znet)++ | src/core/CompUnit/Repository/Installation.pm: Merge pull request #860 from ugexe/patch-11 Cleanup short-name folders when empty |
|||
ugexe | $dir.rmdir unless $dir.dir; # dir dirdir dir dirdirdirdir dir dirddiridir | 00:39 | |
japhb | .oO( Dear Dr. Deer, ... ) |
00:41 | |
TheLemonMan | awwaiid, I think RT#129179 is related to your REPL cleanup, you've removed the CATCH block and when repl-eval now throws it just never comes back to the repl | 08:26 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=129179 | ||
[Tux] | This is Rakudo version 2016.08.1-75-g88ceabc built on MoarVM version 2016.08 | 11:59 | |
csv-ip5xs 10.634 | |||
test 15.274 | |||
test-t 7.435 | |||
csv-parser 16.421 | |||
dalek | p: 543cf5c | (Pawel Murias)++ | src/vm/js/ (2 files): [js] Make getlexouter also find variables from outside the chunk of code we are compiling. |
12:00 | |
p: c59e5a0 | (Pawel Murias)++ | src/vm/js/Compiler.nqp: [js] Implement contvar lexicals. |
|||
p: 881b00b | (Pawel Murias)++ | t/qast/01-qast.t: Test contvar locals. |
|||
p: 89f83a4 | (Pawel Murias)++ | src/vm/js/Compiler.nqp: [js] Fix syntax error. |
|||
Heuristic branch merge: pushed 1000 commits to rakudo/js by pmurias | 12:01 | ||
lizmat | pmurias: 1000 ??? | 12:06 | |
wow | |||
timotimo | what a nice round number | ||
lizmat | one wonders :-) | 12:07 | |
pmurias | lizmat: I have updated rakudo/js with new commits from master, it seems people have been busy working on rakudo :) | 12:29 | |
dalek | kudo/nom: a54e5e7 | (Zoffix Znet)++ | docs/ChangeLog: Add 2016.08.1 |
12:33 | |
kudo/nom: a75a714 | (Zoffix Znet)++ | docs/ChangeLog: Start blank 2016.09 section |
12:34 | ||
kudo/nom: 42e9d7c | (Zoffix Znet)++ | docs/ChangeLog: Fix formatting |
12:35 | ||
TheLemonMan | so, the compiler decides that a MAST node with op 'die_s' and a SVal is nop-d out by the compiler | 13:18 | |
and...that sentence doesn't make any sense heh | 13:20 | ||
so, the compiler decided that a MAST node with op 'die_s' and a SVal has to be translated into a 'nop' | |||
with no warning :D cue hours of hair-pulling (and recompiling rakudo) | 13:21 | ||
TimToady | was it dead code? | 13:45 | |
TheLemonMan | nope | 13:46 | |
TimToady | was there a try {} around it? or a CATCH { default {} } in the same scope? | 13:48 | |
not that I think our optimizer is quite *that* smart... | |||
really sounds more like a bug; would be good to have a small test case | 13:49 | ||
but if it's one of those subtle buffer boundary things, could just evaporate when you try to reduce it | |||
(not that MAST should be doing anything with buffers, at last not until something is serialized) | 13:50 | ||
*least | |||
jnthn: another datapoint, exempting 'role' from the lexpad unification doesn't fix the run() hang | 13:51 | ||
TheLemonMan | it was like this 'if_i reg1, label1; die ...; label1: other ops...' and reg1 came from a method call so I guess we can't blame the constant-folding phase | 13:53 | |
TimToady has never got down into the codegen phase much, except to patch a thing or two | 14:00 | ||
TheLemonMan | it's pretty nice if you don't take into account that every recompilation takes ~2m on this box | 14:01 | |
hoelzro | awwaiid, TheLemonMan: I tracked down RT#129179 to this commit: 85cbb6ddbfb7b32788abff2ed3288c1eae2abd03 | 14:08 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=129179 | ||
TheLemonMan | hoelzro, yeah, by re-introducing the CATCH block it works fine again | 14:11 | |
travis-ci | Rakudo build errored. Zoffix Znet 'Start blank 2016.09 section' | 14:15 | |
travis-ci.org/rakudo/rakudo/builds/157299636 github.com/rakudo/rakudo/compare/a...5a714cc45e | |||
buggable | [travis build above] ✓ All failures are due to timeout (1), missing build log (0), or GitHub connectivity (0) | ||
travis-ci | Rakudo build failed. Zoffix Znet 'Fix formatting' | 14:42 | |
travis-ci.org/rakudo/rakudo/builds/157299730 github.com/rakudo/rakudo/compare/a...e9d7cfaf36 | |||
buggable | [travis build above] ☠ Did not recognize some failures. Check results manually | ||
hoelzro | TheLemonMan++ | 14:56 | |
TheLemonMan | I finally managed to finish this damn PR! o/ | 15:22 | |
Zoffix | travis-ci.org/rakudo/rakudo/builds/157299730 | 15:52 | |
buggable | [travis build above] ✓ All failures are due to timeout (0), missing build log (0), or GitHub connectivity (1) | ||
Zoffix | buggable, botsnack | ||
synopsebot6 | om nom nom | ||
buggable | Zoffix, om nom nom nom | ||
TimToady | jnthn: also, conditionalizing the <.finishpad> doesn't change the hang | 16:11 | |
TimToady wonders which parts of token comp_unit are not idempotent... | 16:13 | ||
well, obviously the $*begin_compunit stuff is not, unless we want to allow a unit declaration inside a unit declaration :) | 16:19 | ||
m: use MONKEY; say EVAL 'unit class Foo; has $.bar' | 16:21 | ||
camelia | rakudo-moar 42e9d7: OUTPUT«(Foo)» | ||
TimToady | well, most of the sekrit soss for UNIT is probably in the action routines, so we'd have to prevent the outer reduction from over-riding the inner one, if we just call comp_unit again | 16:24 | |
awwaiid | rt broken :( | 16:47 | |
Zoffix | awwaiid, the REPL ticket was about errors kicking out of REPL.... try typing this on bleed: sub } | 16:51 | |
m: sub () returns Str(Int) { 42 }().WHAT.say | 16:54 | ||
camelia | rakudo-moar 42e9d7: OUTPUT«Type check failed for return value; expected Str(Int) but got Int (42) in sub at <tmp> line 1 in block <unit> at <tmp> line 1» | ||
Zoffix | m: sub (--> Str()) { 42 }().WHAT.say | ||
camelia | rakudo-moar 42e9d7: OUTPUT«Type check failed for return value; expected Str(Any) but got Int (42) in sub at <tmp> line 1 in block <unit> at <tmp> line 1» | ||
dalek | kudo/nom: b508576 | LemonBoy++ | src/vm/moar/Perl6/Ops.nqp: Add support for coercing return types. RT#128964 |
||
kudo/nom: 94e3b29 | LemonBoy++ | src/vm/moar/Perl6/Ops.nqp: Remove an useless register allocation. |
|||
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=128964 | ||
rakudo/nom: 4d5abda | (Zoffix Znet)++ | src/vm/moar/Perl6/Ops.nqp: | 16:55 | ||
rakudo/nom: Merge pull request #861 from LemonBoy/return-type-coercion | |||
rakudo/nom: | |||
TheLemonMan | we need some tests for that | ||
m: sub x(uint32(Int) $y) { ... }; x(42); | 16:58 | ||
camelia | rakudo-moar 42e9d7: OUTPUT«Method 'uint32' not found for invocant of class 'Int' in sub x at <tmp> line 1 in block <unit> at <tmp> line 1» | ||
TheLemonMan | weird, it should fail here github.com/rakudo/rakudo/blob/nom/...P.nqp#L375 | 17:01 | |
awwaiid | hoelzro: ah great, thanks. I'll fix and add a test. I still want to avoid adding the CATCH back there if it breaks the other stuff | 17:20 | |
thanks TheLemonMan for the REPL bug report :) | 17:21 | ||
Zoffix | m: use Test; sub t (--> Str()){}; isa-ok &t.returns, Str(Any), '.returns() gives correct value'; | 17:49 | |
camelia | rakudo-moar 4d5abd: OUTPUT«Too many positionals passed; expected 2 arguments but got 3 in sub isa-ok at /home/camelia/rakudo-m-inst-2/share/perl6/sources/C712FE6969F786C9380D643DF17E85D06868219E (Test) line 377 in block <unit> at <tmp> line 1» | ||
travis-ci | Rakudo build errored. Zoffix Znet 'Merge pull request #861 from LemonBoy/return-type-coercion | ||
travis-ci.org/rakudo/rakudo/builds/157331785 github.com/rakudo/rakudo/compare/4...5abda7fb46 | |||
buggable | [travis build above] ✓ All failures are due to timeout (1), missing build log (0), or GitHub connectivity (0) | ||
Zoffix | m: use Test; sub t (--> Str()){}; isa-ok &t.returns, Str(Any); | 17:50 | |
camelia | rakudo-moar 4d5abd: OUTPUT«Too many positionals passed; expected 2 arguments but got 3 in sub isa-ok at /home/camelia/rakudo-m-inst-2/share/perl6/sources/C712FE6969F786C9380D643DF17E85D06868219E (Test) line 377 in block <unit> at <tmp> line 1» | ||
Zoffix | heh | ||
m: sub t (--> Str()){}; say &t.returns.isa( Str(Any) ) | 17:51 | ||
camelia | rakudo-moar 4d5abd: OUTPUT«Too many positionals passed; expected 2 arguments but got 3 in block <unit> at <tmp> line 1» | ||
Zoffix | m: use Test; sub t (--> Str()){}; say &t.returns ~~ Str(Any); | ||
camelia | rakudo-moar 4d5abd: OUTPUT«True» | ||
Zoffix | m: use Test; sub t (--> Str()){}; say &t.returns eqv Str(Any); | ||
camelia | rakudo-moar 4d5abd: OUTPUT«True» | ||
Zoffix | m: use Test; sub t (--> Str()){}; say is-deeply &t.returns, Str(Any); | ||
camelia | rakudo-moar 4d5abd: OUTPUT«ok 1 - True» | ||
Zoffix | awwaiid, RT is back | 17:59 | |
dalek | ast: dedfdf9 | (Zoffix Znet)++ | S06-signature/definite-return.t: type coercions work in returns RT#128964 |
18:03 | |
synopsebot6 | Link: rt.perl.org/rt3//Public/Bug/Displa...?id=128964 | ||
awwaiid | Thanks Zoffix | 20:57 | |
dalek | kudo/nom: 694b169 | (Brock Wilcox)++ | / (2 files): Catch another class of compile-time errors |
22:27 | |
kudo/nom: aceb4af | (Zoffix Znet)++ | / (2 files): Merge pull request #862 from awwaiid/repl-compiletime-error Catch another class of compile-time errors |
|||
awwaiid | Zoffix: do those tests get run by ci? (I did run the repl one manually) | 22:34 | |
Zoffix | awwaiid, yup: github.com/rakudo/rakudo/blob/nom/...is.yml#L14 | ||
oh wait | 22:35 | ||
awwaiid | travis-ci.org/rakudo/rakudo/jobs/157362066#L957 | ||
I see SOME are run | |||
Zoffix | I think `make test` doesn't run all the tests is what the issue is | 22:36 | |
awwaiid | github.com/rakudo/rakudo/blob/nom/...ar.in#L213 might be where this is | 22:38 | |
Zoffix | Just runs t/01-sanity and t/04-nativecall | ||
¯\_(ツ)_/¯ | |||
awwaiid | and lots of fails when I locally run t/02-rakudo | 22:39 | |
actually just two fails | |||
er. no, more than two | |||
Zoffix | Running prove -e './perl6' -vlr t/02-rakudo/ fails about 10 tests gist.github.com/zoffixznet/830f2d9...a0f8c8e7c6 | 22:42 | |
That's a couple of commits behind bleed | |||
travis-ci | Rakudo build passed. Zoffix Znet 'Merge pull request #862 from awwaiid/repl-compiletime-error | 23:22 | |
travis-ci.org/rakudo/rakudo/builds/157372575 github.com/rakudo/rakudo/compare/4...eb4af21d6a |