[00:26] *** sjn left [00:32] *** sjn joined [01:22] *** guifa_ joined [02:30] *** guifa_ left [02:36] *** guifa_ joined [03:08] ¦ rakudo: ugexe++ created pull request #6312: RakuAST: Don't iterate worries when promoting under fatal [03:08] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6312 [03:08] ¦ rakudo: ugexe++ created pull request #6313: RakuAST: Skip coercion types in the duplicate-multi check [03:08] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6313 [03:09] ¦ rakudo: ugexe++ created pull request #6314: RakuAST: Resolve an indirect `is ::Name` parent as a type [03:09] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6314 [03:35] ¦ rakudo: ugexe++ created pull request #6315: RakuAST: Allow a pseudo-package nested in a declared name [03:35] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6315 [03:45] ¦ rakudo: ugexe++ created pull request #6316: RakuAST: Report a leading pseudo-package cleanly instead of crashing [03:45] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6316 [03:51] *** guifa_ left [04:57] *** Geth joined [04:57] *** lizmat left [04:58] ¦ rakudo/main: 236ce7cf8d | (Nick Logan)++ (committed using GitHub Web editor) | 3 files [04:58] ¦ rakudo/main: RakuAST: build the CORE:: PseudoStash at runtime, not compile time [04:58] ¦ rakudo/main: [04:58] ¦ rakudo/main: Referencing a CORE:: symbol at compile time in a module (for example [04:58] ¦ rakudo/main: `&CORE::prompt` in a role method) died "Missing serialize REPR function [04:58] ¦ rakudo/main: for REPR MVMContext (BOOTContext)". Dynamically compiled code built the [04:58] ¦ rakudo/main: CORE PseudoStash from the setting context and inserted it into the QAST [04:58] ¦ rakudo/main: as a literal value. That is fine when the frame is thrown away, but a [04:58] ¦ rakudo/main: <…commit message has 10 more lines…> [04:58] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/236ce7cf8d [04:59] *** lizmat joined [06:18] ¦ rakudo: patrickbkr++ created pull request #6317: Allow resizing the pty of a non-started Proc::Async [06:18] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6317 [06:25] Non-RakuAST merges to main are currently blocked, right? [06:32] *** finanalyst joined [07:00] Next release in ≈2 days and ≈11 hours. 1 blocker. Please log your changes in the ChangeLog: https://github.com/rakudo/rakudo/wiki/ChangeLog-Draft [07:32] *** librasteve_ joined [08:03] *** vrurg_ joined [08:04] *** vrurg left [10:31] ¦ rakudo/main: 1964cf3835 | (Patrick Böker)++ (committed using GitHub Web editor) | src/core.c/Proc/Async.rakumod [10:31] ¦ rakudo/main: Stop crash when resizing the pty of a non-started Proc::Async [10:31] ¦ rakudo/main: [10:31] ¦ rakudo/main: With this PR, calling $proc.resize-pty(...) on a Proc::Async object that has not been started yet, succeeds (and does the right thing) instead of dying with "Argument 0 to MoarVM syscall 'pty-resize' has repr P6opaque, but should be MVMOSHandle". It errors because $!process-handle is Any until the proc is started. [10:31] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/1964cf3835 [10:32] @[Coke]: I signed off on that ^^ [10:50] *** guifa_ joined [11:34] *** guifa_ left [12:34] *** finanalyst left [12:35] *** finanalyst joined [12:57] *** finanalyst left [12:58] *** finanalyst joined [13:02] *** finanalyst left [13:06] <[Coke]> ok [13:10] *** finanalyst joined [13:15] *** finanalyst left [13:15] *** finanalyst joined [13:16] *** finanalyst left [13:26] *** finanalyst joined [13:31] *** finanalyst left [14:01] *** finanalyst joined [14:03] *** finanalyst_ joined [14:05] *** finanalyst left [14:44] patrickb: would `X::Proc::Async::MustBeStarted.new(...).throw unless $!started` not be the correct thing to do? [14:45] i say this based on just a quick visual pattern matching of how $!started is used in that file [15:10] ¦ rakudo/main: 2a42263f3c | (Nick Logan)++ | 4 files [15:10] ¦ rakudo/main: RakuAST: let a real routine override an imported stub [15:10] ¦ rakudo/main: [15:10] ¦ rakudo/main: `use subs ; sub foo { ... }` (the `subs` pragma predeclares stub [15:10] ¦ rakudo/main: routines that real definitions later fill in) died "Redeclaration of [15:10] ¦ rakudo/main: symbol '&foo'". An imported symbol is a generated lexical declaration, so [15:10] ¦ rakudo/main: a real declaration of the same name collided with it in the scope's [15:10] ¦ rakudo/main: redeclaration check. [15:10] ¦ rakudo/main: <…commit message has 9 more lines…> [15:10] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/2a42263f3c [15:10] ¦ rakudo/main: 63dfcb576d | (Nick Logan)++ | 2 files [15:10] ¦ rakudo/main: RakuAST: don't warn redefining a forward-declared stub routine [15:10] ¦ rakudo/main: [15:10] ¦ rakudo/main: `sub foo { ... }; sub foo { 42 }` warned "Redeclaration of routine 'foo'" [15:10] ¦ rakudo/main: even though defining a forward-declared stub is the supported pattern and [15:10] ¦ rakudo/main: works. The scope's redeclaration check warned for any two same-named [15:10] ¦ rakudo/main: routine declarations, not accounting for the first being a stub. [15:10] ¦ rakudo/main: [15:10] ¦ rakudo/main: Skip the warning when the existing declaration is a stub routine, the way [15:11] ¦ rakudo/main: the routine installer already allows the definition to replace it. [15:11] ¦ rakudo/main: Redefining a non-stub routine is still a redeclaration. [15:11] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/63dfcb576d [15:11] ¦ rakudo/main: 6b88ef5e92 | (Elizabeth Mattijsen)++ (committed using GitHub Web editor) | 5 files [15:11] ¦ rakudo/main: Merge pull request #6307 from ugexe/ugexe/rakuast-routine-overrides-import [15:11] ¦ rakudo/main: [15:11] ¦ rakudo/main: RakuAST: let a real routine override an imported stub [15:11] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/6b88ef5e92 [15:12] ¦ rakudo/main: df7ca4ae40 | (Nick Logan)++ (committed using GitHub Web editor) | 4 files [15:12] ¦ rakudo/main: RakuAST: parse the `my :(...)` signature literal declaration [15:12] ¦ rakudo/main: [15:12] ¦ rakudo/main: Previously `my :($a, $b) := (1, 2)` failed to parse under RakuAST with [15:12] ¦ rakudo/main: "Malformed my". The declarator grammar accepted the list form [15:12] ¦ rakudo/main: `my ($a, $b)` but not the signature literal form with a leading colon. [15:12] ¦ rakudo/main: [15:12] ¦ rakudo/main: Accept an optional colon before the parenthesized signature in the [15:12] ¦ rakudo/main: <…commit message has 5 more lines…> [15:12] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/df7ca4ae40 [15:13] ugexe: No. The reason is, that we pass in the size on process start. So when calling a pty-resize before starting the process, we are not sending a size change to the running process, but we do save the new sizes. Once the process is started, it will be started with the new sizes. [15:14] ¦ rakudo/main: ed28bde563 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:14] ¦ rakudo/main: RakuAST: attach a top level variable's `will` phaser to the mainline [15:14] ¦ rakudo/main: [15:14] ¦ rakudo/main: A `will leave`/`will enter` (etc.) phaser trait on a top level variable [15:14] ¦ rakudo/main: died "No such method 'add_phaser' for invocant of type 'Mu'". The trait [15:14] ¦ rakudo/main: attaches the phaser to the variable's enclosing block, found via [15:14] ¦ rakudo/main: find-attach-target('block'). At the top level there is no block on the [15:14] ¦ rakudo/main: attach-target stack, so the lookup returned Nil and the code object [15:14] ¦ rakudo/main: <…commit message has 8 more lines…> [15:15] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/ed28bde563 [15:19] ¦ rakudo/main: 9c87e104ab | (Nick Logan)++ (committed using GitHub Web editor) | 3 files [15:19] ¦ rakudo/main: RakuAST: skip arity check for feed-stage calls [15:19] ¦ rakudo/main: [15:19] ¦ rakudo/main: Previously a call used as a stage of a `==>` or `<==` feed wrongly [15:19] ¦ rakudo/main: reported "Calling foo() will never work with declared signature" when [15:19] ¦ rakudo/main: the called sub had a mandatory positional. The fed value is appended as [15:19] ¦ rakudo/main: an extra argument at QAST time, so the argument count visible at the AST [15:19] ¦ rakudo/main: level is short by one. The check-time trial-bind in RakuAST::Call::Name [15:19] ¦ rakudo/main: <…commit message has 10 more lines…> [15:19] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/9c87e104ab [15:20] ¦ rakudo/main: 347366d64a | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:20] ¦ rakudo/main: RakuAST: Declare a block's type captures as block-local [15:20] ¦ rakudo/main: [15:20] ¦ rakudo/main: A type capture on a pointy or loop block's signature parameter was not [15:20] ¦ rakudo/main: declared as a lexical inside that block. The capture bound an outer [15:20] ¦ rakudo/main: same-named lexical instead, so `for ... -> ::T { }` inside a routine [15:20] ¦ rakudo/main: that already had a `::T` parameter overwrote the routine's capture. [15:20] ¦ rakudo/main: [15:20] ¦ rakudo/main: RakuAST::Routine already declares its parameters' type captures in [15:20] ¦ rakudo/main: PRODUCE-IMPLICIT-DECLARATIONS. Do the same in RakuAST::Block so blocks [15:20] ¦ rakudo/main: with their own signature (pointy blocks, loop blocks) declare theirs too. [15:20] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/347366d64a [15:21] ¦ rakudo/main: b1e0906c27 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:21] ¦ rakudo/main: RakuAST: Don't iterate worries when promoting under fatal [15:21] ¦ rakudo/main: [15:21] ¦ rakudo/main: A node with a sorry-level check-time problem but no worry under `use fatal` [15:21] ¦ rakudo/main: crashed with "Cannot iterate over a Mu type object". The worry list stays a [15:21] ¦ rakudo/main: type object until the first worry is added, and promote-worries-to-sorries [15:21] ¦ rakudo/main: iterated it unconditionally. Guard the promotion on a worry having been [15:21] ¦ rakudo/main: recorded. [15:21] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/b1e0906c27 [15:22] ¦ rakudo/main: a72df512e7 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:22] ¦ rakudo/main: RakuAST: Skip coercion types in the duplicate-multi check [15:22] ¦ rakudo/main: [15:22] ¦ rakudo/main: The duplicate-multi-signature check smartmatches two candidate signatures, [15:22] ¦ rakudo/main: which erases a coercion type to its target type. Two coercions that share a [15:22] ¦ rakudo/main: target but accept different types (such as `Int(Cool)` and `Int(Str)`) then [15:22] ¦ rakudo/main: compare as equivalent and produce a spurious "equivalent signatures would [15:22] ¦ rakudo/main: lead to ambiguous dispatch" report, which `use fatal` turns into a compile [15:22] ¦ rakudo/main: <…commit message has 5 more lines…> [15:22] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/a72df512e7 [15:27] ¦ rakudo/main: 39d70c1ee7 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:27] ¦ rakudo/main: RakuAST: Resolve an indirect `is ::Name` parent as a type [15:27] ¦ rakudo/main: [15:27] ¦ rakudo/main: `is ::Name` names an existing type to inherit from through an indirect [15:27] ¦ rakudo/main: lookup. The `is` trait rejects type captures, so `::Name` falls through to [15:27] ¦ rakudo/main: the longname branch and was applied as a property name. Its name was then [15:27] ¦ rakudo/main: resolved late, after the declaring package's own name was in scope, so a [15:27] ¦ rakudo/main: role like `role Exception is ::Exception` resolved its parent to the wrong [15:27] ¦ rakudo/main: <…commit message has 6 more lines…> [15:27] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/39d70c1ee7 [15:28] ¦ rakudo/main: 7b9f50a55b | (Nick Logan)++ (committed using GitHub Web editor) | 3 files [15:28] ¦ rakudo/main: RakuAST: Report a leading pseudo-package cleanly instead of crashing [15:28] ¦ rakudo/main: [15:28] ¦ rakudo/main: A pseudo-package leading a declared name is rejected with a sorry, but for [15:28] ¦ rakudo/main: CORE and GLOBAL the name resolver crashed before that sorry was reported. [15:28] ¦ rakudo/main: `class CORE::Foo` died with "Can't shift from an empty array" because the [15:28] ¦ rakudo/main: CORE branch shifted an already-empty part list, and `class GLOBAL` died [15:28] ¦ rakudo/main: with "Empty name lookup not possible as a constant" because a bare GLOBAL [15:28] ¦ rakudo/main: reduces to an empty name in IMPL-FULL-NAME. Return Nil for a bare CORE and [15:28] ¦ rakudo/main: skip resolving an empty full name, so both report the normal error like the [15:28] ¦ rakudo/main: other pseudo-packages do. [15:28] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/7b9f50a55b [15:30] ¦ rakudo/main: e1f9e3ebc2 | (Nick Logan)++ (committed using GitHub Web editor) | 7 files [15:30] ¦ rakudo/main: RakuAST: Don't compose a class whose body fails to begin [15:30] ¦ rakudo/main: [15:30] ¦ rakudo/main: A begin-time error while declaring a package body member can be deferred as a [15:30] ¦ rakudo/main: sorry rather than aborting the parse: a trait that dies, or a begin-time [15:30] ¦ rakudo/main: evaluation on a check-time node. The package was then composed and installed as [15:30] ¦ rakudo/main: a complete type anyway. Re-declaring that name (as `throws-like { EVAL ... }` [15:30] ¦ rakudo/main: does when a test exercises a bad declaration twice) raised a spurious [15:31] ¦ rakudo/main: <…commit message has 7 more lines…> [15:31] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/e1f9e3ebc2 [15:32] ¦ rakudo/main: 2e27eab619 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:32] ¦ rakudo/main: RakuAST: Fix enum declaration with a non-string key [15:32] ¦ rakudo/main: [15:32] ¦ rakudo/main: An enum value's name is a string, but a key written as a numeric literal [15:32] ¦ rakudo/main: (`12844 => 25`) reaches enum building as an Int. Two paths then failed [15:32] ¦ rakudo/main: under RakuAST where legacy did not. [15:32] ¦ rakudo/main: [15:32] ¦ rakudo/main: `add_enum_value` unboxes the key to a native string at BEGIN time. Coerce [15:32] ¦ rakudo/main: <…commit message has 8 more lines…> [15:32] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/2e27eab619 [15:51] ¦ rakudo/main: d4c5749463 | (Nick Logan)++ (committed using GitHub Web editor) | 2 files [15:51] ¦ rakudo/main: RakuAST: Initialize attribute defaults that are type objects at construction [15:51] ¦ rakudo/main: [15:51] ¦ rakudo/main: An attribute whose default is a type object (`has T $.x = T`) compiled to a [15:51] ¦ rakudo/main: build value that is not concrete. The metamodel only initializes the attribute [15:51] ¦ rakudo/main: at construction when the build is concrete, so it was never initialized there. [15:51] ¦ rakudo/main: The slot was left to MoarVM, which vivifies it lazily on the first read, and [15:51] ¦ rakudo/main: that vivification is not synchronized. Under concurrency a node published with [15:51] ¦ rakudo/main: <…commit message has 8 more lines…> [15:51] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/d4c5749463 [17:23] <[Coke]> I assume all these new commits are 1) rakuast, and 2) going in knowing the release is in 2 days? [17:40] All have a "RakuAST" prefix, except for that one commit of mine, which apparently got a special permit. :-P (It is a very localized and small fix though.) I am well aware the release is in two days. [17:54] ¦ rakudo/main: 0a62540648 | (Nick Logan)++ | 2 files [17:54] ¦ rakudo/main: RakuAST: Resolve a package lookup through a runtime lexical [17:54] ¦ rakudo/main: [17:54] ¦ rakudo/main: `t::{$key}` where `t` is a lexical bound to a type (my \t := SomeEnum) [17:54] ¦ rakudo/main: failed to compile with "Symbol 't' does not have a compile-time value". [17:54] ¦ rakudo/main: Resolving the qualified name ran the leading part through the constant [17:54] ¦ rakudo/main: name resolver, which threw for a lexical that is not itself a constant, [17:54] ¦ rakudo/main: before the runtime .WHO fallback could take over. This broke installing [17:54] ¦ rakudo/main: <…commit message has 8 more lines…> [17:54] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/0a62540648 [17:54] ¦ rakudo/main: 3b1e53c06a | (Nick Logan)++ | 2 files [17:54] ¦ rakudo/main: RakuAST: Resolve a package-qualified call through a runtime lexical [17:54] ¦ rakudo/main: [17:54] ¦ rakudo/main: `t::foo()` where `t` is a lexical bound to a type (my \t := SomeType) [17:54] ¦ rakudo/main: could not find the routine. Resolve the leading part as a plain lexical [17:54] ¦ rakudo/main: so a runtime package base binds as the call's package even when it lacks [17:54] ¦ rakudo/main: a compile-time value. Codegen already takes .WHO on its value to find [17:54] ¦ rakudo/main: the routine, the same as for a compile-time package. [17:54] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/3b1e53c06a [17:54] ¦ rakudo/main: 20c3028c44 | (Elizabeth Mattijsen)++ (committed using GitHub Web editor) | 3 files [17:54] ¦ rakudo/main: Merge pull request #6293 from ugexe/ugexe/rakuast-indirect-package-lookup [17:54] ¦ rakudo/main: [17:54] ¦ rakudo/main: RakuAST: Resolve a package lookup or call through a runtime lexical [17:54] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/20c3028c44 [17:54] [Coke]: yes, all RakuAST except patrick's one [18:11] ¦ rakudo: lizmat++ created pull request #6318: RakuAST: small refactor of ::Resolver.resolve-lexical-constant [18:11] ¦ rakudo: review: https://github.com/rakudo/rakudo/pull/6318 [18:12] heh... interesting... looks like the commit felt in a black hole [18:13] ¦ rakudo/main: 0a62540648 | (Nick Logan)++ | 2 files [18:13] ¦ rakudo/main: RakuAST: Resolve a package lookup through a runtime lexical [18:13] ¦ rakudo/main: [18:13] ¦ rakudo/main: `t::{$key}` where `t` is a lexical bound to a type (my \t := SomeEnum) [18:13] ¦ rakudo/main: failed to compile with "Symbol 't' does not have a compile-time value". [18:13] ¦ rakudo/main: Resolving the qualified name ran the leading part through the constant [18:13] ¦ rakudo/main: name resolver, which threw for a lexical that is not itself a constant, [18:13] ¦ rakudo/main: before the runtime .WHO fallback could take over. This broke installing [18:13] ¦ rakudo/main: <…commit message has 8 more lines…> [18:13] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/0a62540648 [18:13] ¦ rakudo/main: 3b1e53c06a | (Nick Logan)++ | 2 files [18:13] ¦ rakudo/main: RakuAST: Resolve a package-qualified call through a runtime lexical [18:13] ¦ rakudo/main: [18:13] ¦ rakudo/main: `t::foo()` where `t` is a lexical bound to a type (my \t := SomeType) [18:13] ¦ rakudo/main: could not find the routine. Resolve the leading part as a plain lexical [18:13] ¦ rakudo/main: so a runtime package base binds as the call's package even when it lacks [18:13] ¦ rakudo/main: a compile-time value. Codegen already takes .WHO on its value to find [18:13] ¦ rakudo/main: the routine, the same as for a compile-time package. [18:13] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/3b1e53c06a [18:13] ¦ rakudo/main: 20c3028c44 | (Elizabeth Mattijsen)++ (committed using GitHub Web editor) | 3 files [18:13] ¦ rakudo/main: Merge pull request #6293 from ugexe/ugexe/rakuast-indirect-package-lookup [18:14] ¦ rakudo/main: [18:14] ¦ rakudo/main: RakuAST: Resolve a package lookup or call through a runtime lexical [18:14] ¦ rakudo/main: review: https://github.com/rakudo/rakudo/commit/20c3028c44 [18:14] ¦ rakudo/lizmat-24: 0974e1ab89 | (Elizabeth Mattijsen)++ | src/Raku/ast/resolver.rakumod [18:14] ¦ rakudo/lizmat-24: RakuAST: small refactor of ::Resolver.resolve-lexical-constant [18:14] ¦ rakudo/lizmat-24: [18:14] ¦ rakudo/lizmat-24: Since it felt like pretty hot code during compilation: [18:14] ¦ rakudo/lizmat-24: - no return statement unless needed [18:14] ¦ rakudo/lizmat-24: - no unneccesary intermediat variables [18:14] ¦ rakudo/lizmat-24: review: https://github.com/rakudo/rakudo/commit/0974e1ab89 [18:14] it appears that Github is having some webhooks issues [18:29] I'll stop merging PRs now