|
Welcome to MUGS ⚄♠♞🏹 (Multi-User Gaming Services)! | github.com/Raku-MUGS | v0.1.4 has been released! (github.com/Raku-MUGS/MUGS/blob/mai...v0.1.4.md) | This channel is logged for historical purposes; logs at irclogs.raku.org/mugs/index.html Set by japhb on 3 March 2024. |
|||
| timo | > ♥♥♥♥♥♥♥♥♥♥♥♥♥���♥♥♥♥♥♥♥♥♥♥♥♥♥♥♥ | 01:00 | |
| what's that all about? | |||
| is it just showing escape sequences that Terminal::Print uses there? | 01:02 | ||
| japhb | The use of the replacement character there is a bit odd, yeah. | 02:22 | |
|
05:37
lizmat_ joined
05:41
lizmat left
09:46
Geth joined
|
|||
| patrickb | I actually have the tests succeeding on my windows box. | 11:22 | |
| Putting a debug print printing cold and rows in the failing test file gives cols: 120, rows: 9001 | 11:23 | ||
| That's probably the culprit. | |||
| A quick googling on how to manipulate the terminal size gave nothing. Would it make sense to skip the affected test if the terminal height is > 300 ? | 11:34 | ||
| I have adapted the test accordingly. Now we are succeeding on all platforms. | 11:51 | ||
| japhb | It sounds like somehow the rows is returning the scrollback length rather than the viewport height? That's ... rather odd. | 14:42 | |
| I let this roll around in my brain while I got ready for the morning, and have some thoughts ... | 15:01 | ||
| Something is wrong with either the test or the T-P implementation if it crashes because there's lots of rows that actually *can* be addressed. | 15:03 | ||
| Something is wrong with the T-API implementation on Windows if the number of rows is completely bogus, and furthermore people won't actually be able to *use* T-P if the row count is nonsense. | 15:04 | ||
| I feel like instead of skipping this test for bogus row counts we need an *earlier* test that the row count is actual sensical. | 15:05 | ||
| Oddly, this is one of those places where using a hacky version of T-W's query-based detection might actually make a useful test; | 15:06 | ||
| it might actually be worth having a test that checks whether the escape sequence queries and T-API's detection return the same result. | 15:07 | ||
| Seems like the kind of test that belongs in the T-API test suite, actually. | 15:08 | ||
| (It doesn't need to be the actual implementation, and in fact probably *shouldn't* be. But as a test checking that multiple different methods produce the same result? Seems valid.) | 15:11 | ||
| Odd thought: Are you sure that Windows CI actually even has a properly set up terminal? I kinda wonder if we're just *assuming* that the Windows CI environment makes sense for terminal UI code | 15:38 | ||
| timo | yeah i was kind of surprised that there's even something at all that responds to asking the terminal how big it is | 17:28 | |
| patrickb | I kind of fear it's actually a correct size, an artifact of how the CI works with the apps. I'll try to validate this. | 18:52 | |
| japhb | Thank you patrickb++ | 22:22 | |