|
irclog.perlgeek.de/perl6book/today | source: github.com/perl6/book/ Set by moderator on 24 March 2010. |
|||
|
00:11
eternaleye joined
|
|||
| dalek | ok: a8ccc78 | chromatic++ | src/subs-n-sigs.pod: Edited half of this section, mostly for clarity and style. This could use some word parameter versus argument. |
00:44 | |
| PerlJam | FWIW, I tend to use "parameter" rather than "argument". | 01:45 | |
| sub foo ($a,$b,$c) { ... } # this subroutine has 3 parameters. | 01:46 | ||
| The C<foo> subroutine is parameterized by 3 scalar values | |||
| Also, there's a common usage of "parameter" to mean the slot, and "argument" to mean that which is put in the the slot | 01:48 | ||
| sub foo ($a) { ... }; foo(7); # $a is the parameter, 7 is the argument. | |||
|
03:56
p6eval joined
05:21
japhb joined
|
|||
| moritz_ | PerlJam: that's the terminology I try to use too | 06:27 | |
|
07:37
eternaleye joined,
hugme joined
|
|||
| dalek | ok: 0db6713 | moritz++ | src/subs-n-sigs.pod: [subs] try to be more consistent wrt argument vs. parameter; also define "parameter" |
10:24 | |
| moritz_ | there are a few places where I'm not quite sure about the distinction... further review welcome | 10:25 | |
|
10:43
masak joined
|
|||
| moritz_ | masak: I'd appreciate it if you could proof-read my last book commit | 12:34 | |
| masak | will do. | 12:35 | |
|
13:56
sahadev joined
|
|||
| masak | looks good. | 14:22 | |
| moritz_ | thanks | 14:23 | |
| dalek | ok: db22164 | masak++ | src/subs-n-sigs.pod: [subs-n-sigs] fixed grammaro |
14:28 | |
| sahadev | hello. i forked the "book" project and made a few changes in the first couple of chapters. i am not familiar with "git way" yet. what's the best/right way to submit these to the main repo? | 14:39 | |
| my fork is at github.com/prakashk/book | |||
| masak | thank you. I'll have a look | 14:43 | |
| moritz_ | sahadev: I'm a bit confused by github.com/prakashk/book/commit/a60...2662634454 - it reverts a change I needed to make the format actually run with current rakudo | ||
| rakudo: printf '%- 3s', 'ab' | 14:44 | ||
| p6eval | rakudo 6a502f: OUTPUT«ab » | ||
| moritz_ | rakudo: printf '%-3s', 'ab' | ||
| p6eval | rakudo 6a502f: OUTPUT«ab » | ||
| moritz_ | - say "$n has won { %games{$n} } games and { %sets{$n} } sets"; | 14:45 | |
| 62 | |||
| + say "$n has won %games{$n} games and %sets{$n} sets"; | |||
| there's no need for the blocks, though we haven't explained that yet I fear | |||
| sahadev: other parts of your corrections look very good though | 14:47 | ||
| sahadev | masak: are you talking about these lines specifically? | ||
| - the value on the right is a bare identifier, it is taken to be a string. So one 67 +the key on the left is an identifier, it is taken to be a string. So one | |||
| masak | uh. sahadev, maybe you meant moritz_. | 14:49 | |
| sahadev | oops, sorry. | ||
| i should read first before responding :) | |||
| moritz_: i just updated my rakudo tree today and tested the change and it works. btw, it wasn't exactly reverting to the previous version. it has a small change (the $ sigil is now inside the braces. | 14:51 | ||
| ) | |||
| however, feel free to reject any changes, if they are not appropriate. | 14:52 | ||
| moritz_ | ok | ||
| sahadev++ # lots of work | |||
| I don't know if I'll get around to a detailed review today, but I'll definitively do it this week - unless masak++ beats me to it | 14:53 | ||
| sahadev | thanks. i have been trying to get into Perl6 somehow. thought following the book is the easiest way (for me) | ||
| masak | sahadev: that's very good to hear. | 14:56 | |
| sahadev | about the use of beramono font in the latex version. i found the size of verbatim strings within paragraphs (\\texttt) to be much bigger than the other surrounding text (which is rendered using the default computer modern fonts i believe). i have a version of the file using "bera", which uses bera family for everything (mono, sans and serif). | 15:00 | |
| that looks better to me. | |||
| moritz_ | sahadev: I think the fix shouldn't go into an external tex package, but into the latex template in bin/book-to-latex | 15:02 | |
| sahadev | moritz_: yes. i changed the script, not the latex template. | ||
| moritz_ | ah, great | ||
| +1 to that change | |||
| sahadev | here's my change, if you are interested. | ||
| -\\usepackage[T1]{fontenc} | |||
| -\\usepackage{textcomp} | |||
| -\\usepackage[scaled]{beramono} | |||
| +\\usepackage{bera} | |||
| i didn't commit it yet, since this one is a "subjective" change. | 15:03 | ||
| wasn't sure, if it was that important. | |||
| moritz_ | I kinda still hope that Onix Neon Press takes layout into their hands | 15:04 | |
| but until they do, layout improvements are welcome too | |||
| the main reason for beramono was because computer modern mono doesn't support bold font | |||
| sahadev | ok. | 15:06 | |
| moritz_ | anyway, I like it | 15:07 | |
| pushed | |||
| sahadev | excellent. | ||
| dalek | ok: 95acbd0 | moritz++ | bin/book-to-latex: [latex] use the font "bera" consistently. Patch by sahadev++ |
15:10 | |
|
15:52
dalek joined
18:29
hicx174 joined
21:50
hicx174 joined
22:12
p6eval joined
22:24
sahadev left
22:30
dalek left,
dalek joined
|
|||
| dalek | ok: 228f280 | duff++ | src/subs-n-sigs.pod: [subs] some clarifications and minor text changes |
22:55 | |
| ok: a706369 | chromatic++ | src/subs-n-sigs.pod: Finished editing what's in this section. Added a couple of examples. |
23:00 | ||
| ok: 7c843c4 | chromatic++ | src/subs-n-sigs.pod: Merged branch 'master' of git@github.com:perl6/book. |
23:01 | ||