Geth | doc/main: 58c3b74f7e | (Eric Forste)++ (committed using GitHub Web editor) | CREDITS add self to CREDITS (#4666) |
01:41 | |
03:24
arkiuat left
03:37
arkiuat joined
03:44
arkiuat left
04:10
arkiuat joined
04:26
arkiuat left
05:11
[Coke] left
07:01
[Coke] joined
09:02
ds7823 joined
09:45
ds7823 left
09:55
ds7823 joined
10:27
librasteve_ left
10:40
ds7823 left
11:27
ds7832 joined
|
|||
Geth | doc/schultzdavid-patch-2: 3440c15953 | schultzdavid++ (committed using GitHub Web editor) | doc/Language/regexes.rakudoc change "parentheses" to singular "parenthesis" where single one is meant |
11:50 | |
13:25
samebchase4 joined
13:32
samebchase left,
samebchase4 is now known as samebchase,
[Coke] left
13:33
[Coke]_ joined
13:36
sjn left,
sjn joined
|
|||
Geth | doc: arkiuat++ created pull request #4667: Update modules.rakudoc |
13:42 | |
doc/schultzdavid-patch-2: 166a2d9c99 | schultzdavid++ (committed using GitHub Web editor) | doc/Language/regexes.rakudoc correct the explanation for how the 24 iterations come about * Expand the iteration log (but for brevity keep only the relevant 2 lines per iteration; it should be transparent through the words and code that are above) * The current explanation for the number 24 is incorrect (based on a numerical coincidence; and where it says 'OUTPUT: «23»' the output is actually 22) * The correct explanation (as can be seen from the complete iteration log) is that 24 = 10 + 14 = (1+9)+(1+13), i.e. that first the 10 chars of " database!" get backtracked [down to 1, taking 10 trials total], and then the 13 chars of "SQL database!" get backtracked [down to 0, taking 14 trials total, with the last one a match] |
13:48 | ||
ds7832 | Coke: I'll probably be through with regexes.rakudoc today or tomorrow; I'll notify you then | 14:04 | |
14:05
[Coke]_ is now known as [Coke]
|
|||
[Coke] | OK, thanks. | 14:06 | |
in future, if you're doing a work in progress like that, mark it draft so I don't keep wondering if I can merge. :) | |||
Geth | doc/schultzdavid-patch-2: eaebf476b4 | schultzdavid++ (committed using GitHub Web editor) | doc/Language/regexes.rakudoc whitespace |
14:09 | |
ds7832 | Yes, will do :) | 14:11 | |
14:20
arkiuat joined
|
|||
ds7832 | Expect a bigger rewrite at the end of docs.raku.org/language/regexes#Und...cktracking : The lower half of the paragraph "Understanding backtracking" has apparently been constructed upon an error: After the words (Ctrl+F) "Consider the following slightly changed example:", the first capture group es removed from the regex, but the reference at the end, $1, which is supposed to contain "SQL", isn't adjusted to $0, as it' | 16:05 | |
s necessary. | |||
changing it to $0 makes the match actually work: | 16:06 | ||
my $string = 'PostgreSQL is a SQL database!'; say $string ~~ / (SQL) (.+) $0 /; | |||
... would produce: | |||
「SQL is a SQL」 | |||
0 => 「SQL」 | |||
1 => 「 is a 」 | 16:07 | ||
The same mistake of using $1 rather than $0 has been carried through to the end, and most of the text is built around its results... So not sure how much of it can be kept. | 16:08 | ||
I rthink the one main poin that remains, is that even with the :ratchet adverb, there can still be more than one iteration. | 16:09 | ||
I think what I'll do is talk about frugal quantifiers. Indeed much of what's going on there is effects of greedy quantifiers (or their absence), and it's very much worth knowing how one can influence backtracking by using frugal rather than greedy quantifiers. | 16:23 | ||
[Coke] | good catch | 17:09 | |
I think a lot of the changes I have been making over the years are more targeted, nice to have a more holistic approach on a given page. | 17:10 | ||
17:21
arkiuat left
17:33
arkiuat joined
17:38
arkiuat left
|
|||
Geth | doc/schultzdavid-patch-2: e9f74fff29 | schultzdavid++ (committed using GitHub Web editor) | doc/Language/regexes.rakudoc Correct extended backtracking example, making it about frugal quantifiers In the current line "say $string ~~ / (SQL) (.+) $1 /; # OUTPUT: «Nil»", positional capture group should have been $0 rather than $1. Changing it to $0 actually makes most of the supposedly failing examples (a) work and (b) non-informative because of that. What's missing so far though is an illustration of frugal quantifiers in the context of backtracking/ratcheting, so I've introduced some. (The subsequent subsection is more about frugal _ratcheting_ and mentions frugal quantifiers only briefly.) |
17:58 | |
18:05
arkiuat joined
18:11
arkiuat left
|
|||
ds7832 | I have a line of output (wrapped in =code :lang<text>) that actually should contain a trailing whitespace. Is there a way to say, pass the whitespace test? | 18:13 | |
18:24
arkiuat joined
19:07
ds7823 joined
19:19
ds7832 left
19:24
ab5tract_ joined
19:25
timo2 joined
19:26
librasteve_ joined
19:28
timo left,
ab5tract left,
ab5tract_ is now known as ab5tract
|
|||
[Coke] | not at the moment. | 20:33 | |
can you reconstruct the example so it doesn't need it? | |||
If not, that test can fail, just leave a warning in the PR so I know | 20:34 | ||
and I'll add a special case in the test to ignore it. | |||
21:06
arkiuat left
21:19
arkiuat joined
21:45
ds7832 joined
|
|||
Geth | doc/schultzdavid-patch-2: e54205454c | schultzdavid++ (committed using GitHub Web editor) | doc/Language/regexes.rakudoc add comments to example output, addressing whitespace |
21:47 | |
21:58
arkiuat_ joined
22:04
arkiuat_ left,
arkiuat left,
ds7823 left,
arkiuat joined
22:05
ds7823 joined
22:17
ds7823 left,
ds7832 left
22:21
arkiuat_ joined
22:22
ds7823 joined,
ds7832 joined
|
|||
ds7832 | [Coke]: I'm done with my edits :) github.com/Raku/doc/pull/4663#issu...3408509538 | 22:23 | |
22:24
arkiuat left
22:40
ds7832 left
23:11
arkiuat_ left
23:12
arkiuat joined
23:27
ds7823 left
|