| SmokeMachine | japhb: Done and tests added | 00:12 | |
| someone with permission could allow the tests to run on that PR, please? | 00:13 | ||
| japhb | I think I triggered it for the latest version of the PR | 02:13 | |
| CI passed. | 02:18 | ||
| Ready for merge, SmokeMachine ? | 02:19 | ||
| disbot3 | <simon_sibl> I am sure the code could be so much better, especially for the end goal xD but since I dont know much about hArc yet, thats what I do xD | 04:41 | |
| <simon_sibl> it basically will be a file explorer (later maybe add a system of permission but not sure at all yet), for now it shows every file at the same time like /some/dir/file another/path/file in the same table xD | 04:42 | ||
| <librasteve> @simon_sibl - I have been able to take a quick look ... your repo was missing the pico node modules so I have made a PR to add them and then your site looks very nice! I can pass in a directory and see the filelist. I see that you have the Download method stubbed for now - but apart from that looks cool to me. TBH, I did not find anything to dislike in your code ... but then only a superficial look... | 10:05 | ||
| <librasteve> I am not an expert in web sockets but it looks like you are over that pretty well | 10:06 | ||
| SmokeMachine | japhb: from my side, I think so. :) | 12:35 | |
| Geth | cro-http/main: 8a2b7e3c5a | (Fernando Corrêa de Oliveira)++ | 6 files Copy diff from `Support link generation #152` from 4 years ago to current code (Altai-man++) |
15:19 | |
| cro-http/main: 7490e31cc5 | (Geoffrey Broadwell)++ (committed using GitHub Web editor) | 6 files Merge pull request #208 from FCO/update-link-gen-no-fork Copy diff from `Support link generation #152` from 4 years ago to current code (Altai-man++) |
|||
| japhb | SmokeMachine: 208 merged, 152 closed. Can 207 also be closed now? | 15:21 | |
| SmokeMachine | japhb: yes, please. And thanks! | 15:31 | |
| japhb | Done, and you're welcome! | 15:59 | |
| SmokeMachine: While we're here, what's the status of #205? | 16:03 | ||
|
16:40
librasteve_ joined
|
|||
| SmokeMachine | japhb: the t/ tests passes. and the code looks correct to me... but it might conflict with the last PR. I'll rebase it with master now... | 17:23 | |
| japhb | Sounds good | 17:37 | |
| SmokeMachine | I just rebased it. I also made `http` with multiple methods accept names as well (but a function that will receive the method being used) and a new test. The original test was on `xt/` and `xt/` is not passing locally, it fails with `certificate has expired`... | 17:57 | |
| japhb: ☝️ | |||
| japhb | There's a script to regenerate the certificates. Long lived certs were banned by the browser makers, so now all the cryptography libraries changed defaults. Sucks for test certs though. | 22:32 | |
| Also, I think there's a good chance one of the PRs recently neglected to add a Changes entry, so before release we'll need to fill in any missing lines. | 22:38 | ||
| Ah no, Altai-man's PR just had a rather minimalist Changes update | 22:41 | ||
| Geth | cro-http/main: 5d74c63c5b | (Geoffrey Broadwell)++ | 3 files Refresh TLS key/certs used for xt/ tests |
22:45 | |
| japhb | OK, that's refreshed testing keys. SmokeMachine please rebase on that ^^ | 22:46 | |
| SmokeMachine | japhb: rebased and pushed | 23:15 | |
| everything seems to be working... | 23:16 | ||
| Geth | cro-http/main: e2767515f6 | (Fernando Corrêa de Oliveira)++ | 4 files Make http function accept a list of http methods |
23:22 | |
| cro-http/main: a9d0a60543 | (Geoffrey Broadwell)++ (committed using GitHub Web editor) | 4 files Merge pull request #205 from FCO/http-list feat: Make http function accept a list of http methods |
|||
| SmokeMachine | \o/ | ||
| japhb | My feelings exactly. :-) | ||
| This brings us down to 4 open PRs in cro-http | |||
| SmokeMachine | I think I'll try to take a look on them... maybe I can help somehow... | 23:28 | |
| all of them should be applied, or any of them is out of scope? | 23:29 | ||
| japhb | Finally found the right tip on how to do this: github.com/pulls?user=croservices # All open PRs in croservices org | 23:30 | |
| So 18 altogether | |||
| SmokeMachine: Well, those that still make sense. #114 looks like one that already had jnthn review, but was not merged after vendethiel pushed last | 23:33 | ||
| SmokeMachine | I'll take a look after I finish adapting Crolite to show routes list with out using RouterUtils, that module is not needed anymore... | ||
| japhb | SGTM, thanks SmokeMachine++ | 23:35 | |
| SmokeMachine | it seems #114 is very small, and seems to be just the case to create a new PR copying the diff (again .pm6 -> .rakumod problem) | 23:36 | |
| japhb | OK, I'll close it when you open the new copy, and work from there on your version. | 23:37 | |
| Geth | cro-http: FCO++ created pull request #209: Catch URI parse errors during routing (Copy from #114 vendethiel++) |
23:51 | |
| SmokeMachine | japhb: ☝️ | 23:52 | |
| japhb | One comment | 23:54 | |
| Closed #114 now that #209 is live | 23:55 | ||
| Thanks for updating the PR; I'm just waiting for CI tests now | 23:59 | ||
|
23:59
librasteve_ left
|
|||