| 1 Oct 2025 | |||
| SmokeMachine | I think I'll try to take a look on them... maybe I can help somehow... | 23:28 | |
| all of them should be applied, or any of them is out of scope? | 23:29 | ||
| japhb | Finally found the right tip on how to do this: github.com/pulls?user=croservices # All open PRs in croservices org | 23:30 | |
| So 18 altogether | |||
| SmokeMachine: Well, those that still make sense. #114 looks like one that already had jnthn review, but was not merged after vendethiel pushed last | 23:33 | ||
| SmokeMachine | I'll take a look after I finish adapting Crolite to show routes list with out using RouterUtils, that module is not needed anymore... | ||
| japhb | SGTM, thanks SmokeMachine++ | 23:35 | |
| SmokeMachine | it seems #114 is very small, and seems to be just the case to create a new PR copying the diff (again .pm6 -> .rakumod problem) | 23:36 | |
| japhb | OK, I'll close it when you open the new copy, and work from there on your version. | 23:37 | |
| Geth | cro-http: FCO++ created pull request #209: Catch URI parse errors during routing (Copy from #114 vendethiel++) |
23:51 | |
| SmokeMachine | japhb: ☝️ | 23:52 | |
| japhb | One comment | 23:54 | |
| Closed #114 now that #209 is live | 23:55 | ||
| Thanks for updating the PR; I'm just waiting for CI tests now | 23:59 | ||
| 2 Oct 2025 | |||
| Geth | cro-http/main: b63ae11a7b | (Fernando Corrêa de Oliveira)++ | 3 files Catch URI parse errors during routing (Copy from #114 vendethiel++) |
00:02 | |
| cro-http/main: 0c30cd665e | (Geoffrey Broadwell)++ (committed using GitHub Web editor) | 3 files Merge pull request #209 from FCO/copy-of-invalid-url Catch URI parse errors during routing (Copy from #114 vendethiel++) |
|||
| japhb | <freddie-mercury>Another one bites the dust (hey-hey!)</> | 00:03 | |
| SmokeMachine | :) | ||
| o| | 00:04 | ||
| japhb | Thanks for all your work SmokeMachine++! | ||
| SmokeMachine | #46 I'm not sure... because I don't think it would work if there is a `get -> "bla", Str $ble, "bli" {...}` and if there is a request for `/bla//bli`... I don't think that would set $bla to ""... | 00:08 | |
| japhb | Yeah, that one seems a bit odd. | 00:10 | |
| Closed #46 based on your point. | 00:16 | ||
| 2 left in cro-http, 16 overall | 00:17 | ||
| SmokeMachine | once we are here... | 00:28 | |
| Geth | cro-http: FCO++ created pull request #210: Fix throwing with client-supplied invalid cookie (copy of #126 vrurg++) |
00:29 | |
| SmokeMachine | japhb: ☝️ | 00:35 | |
| Geth | cro-http/main: ba5345fbdd | (Fernando Corrêa de Oliveira)++ | 2 files Fix throwing with client-supplied invalid cookie (copy of #126 vrurg++) |
00:50 | |
| cro-http/main: 58d8e4d58d | (Geoffrey Broadwell)++ (committed using GitHub Web editor) | 2 files Merge pull request #210 from FCO/copy-of-fix-bad-client-cookie Fix throwing with client-supplied invalid cookie (copy of #126 vrurg++) |
|||
| japhb | #210 merged, #126 closed. | 00:51 | |
| You're on a roll, SmokeMachine :-) | |||
| SmokeMachine | the last you is a bit more complex... I'll need to leave that for another day... | 00:52 | |
| japhb | No worries, thankful for the work so far! | 00:53 | |
| disbot3 | <simon_sibl> I merge your pr 🙏 still need to figure out how to handle the upload, then I can focus on the actual Node code xD | 04:06 | |
| <librasteve> SmokeMachine ++ … great to see Cro rise from a long sleep | 07:30 | ||
| 3 Oct 2025 | |||
| <librasteve> @simon_sibl ... sorry just noticed your point about upload ... I have been working on automating this here github.com/librasteve/harcstack-org.git ... which already works pretty well (imho) - so all you need to do is commit and then restart then docker-compose down, up on the server | 09:46 | ||
| <librasteve> to use this for your site, just clone this repo and then replace the lib/ and static/ folders with your own site ... currently this uses the Cro service.raku to run the server ... so you may need to adjust the last line in the Dockerfile to suit your entrypoint ... eg CMD ["raku", "-Ilib", "dfs.raku"] | 09:52 | ||
| 5 Oct 2025 | |||
| <vendethiel> Oh I guess I never fixed that test | 11:13 | ||
| 8 Oct 2025 | |||
| disbot5 | <simon_sibl> I was checking this: htmx.org/examples/file-upload/ I will continue digging when I get the time to work on this project again 🙏 | 08:23 | |