|
Welcome the channel on the development of Cro, a set of libraries for building reactive distributed systems, lovingly crafted to take advantage of all the Raku Programming Language has to offer (cro.services). This channel is being logged for historical purposes. Set by lizmat on 24 May 2021. |
|||
| patrickb | I have just successfully uploaded a file to OBS using Cro. :-) | 00:07 | |
| I'm just not entirely sure my fix is correct. Will do a PR so people can give their opinion. | 00:08 | ||
| Geth | cro-http: patrickbkr++ created pull request #160: Do not send the ENO_OF_STREAM flag twice |
00:26 | |
| patrickb | It's a bit ironic that I first implemented remote window handling and only afterwards noticed this actually a lot more obvious protocol violation. | 00:28 | |
| japhb glares in the general direction of `$MAX-FRAME-SIZE-9` -- that's just confusing. | 00:31 | ||
|
00:42
patrickb left
00:43
patrickz joined
|
|||
| patrickz | that's the frame header 3 bytes length + 1 byte type + 1 byte flags + 4 bytes stream id | 00:51 | |
| but yeah, could be made more obvious... | 00:52 | ||
| Geth | cro-http: patrickbkr++ created pull request #161: Implement remote window handling |
00:56 | |
| japhb | patrickz: I meant because it's not clear that `$MAX-FRAME-SIZE-9` will actually be parsed as `$MAX-FRAME-SIZE - 9`, but yeah, having `my $FRAME-OVERHEAD = 9; # frame header 3 bytes length + 1 byte type + 1 byte flags + 4 bytes stream id` followed by using `$MAX-FRAME-SIZE - $FRAME-OVERHEAD` is probably even better | 01:19 | |
| patrickz | Ah! I didn't see that other reading! | 01:20 | |
| japhb: github.com/jnthn/p6-io-socket-async-ssl/pull/64 | 01:26 | ||
| Geth | cro-http: patrickbkr++ created pull request #162: Implement support for sslkeylogfile |
01:31 | |
| patrickz | I'm off to bed. o/ | 01:40 | |
|
01:41
patrickz left
|
|||
| japhb | .tell patrickz Thank you for making the sslkeylogfile PRs! | 01:44 | |
|
07:52
Xliff joined
12:22
patrickb joined
|
|||
| Geth | cro-http: 4ae89f440b | (Patrick Böker)++ | lib/Cro/HTTP2/FrameSerializer.pm6 Do not send the ENO_OF_STREAM flag twice The FrameSerializer must only mark the last partial frame as END_OF_STREAM if the original non-split frame contained that flag. This caused the marker to be sent twice if the conditions were right and results in the remote end (rightfully) aborting the connection. |
17:48 | |
| cro-http: 855a1c858a | (Jonathan Worthington)++ (committed using GitHub Web editor) | lib/Cro/HTTP2/FrameSerializer.pm6 Merge pull request #160 from patrickbkr/no-duplicate-end-of-stream-flags Do not send the ENO_OF_STREAM flag twice |
|||
| sena_kun | patrickb++ | 17:55 | |
|
19:59
Xliff_ left
20:07
TempIRCLogger joined
20:51
Xliff_ joined
23:14
Xliff left
|
|||