| librasteve_ | SmokeMachine: iirc one of the tests does a loopback (eg to 0.0.0.0) [this can often break on a new install due to firewall and so on] … suggest you find this in and expand to cover redirect? | 09:50 | |
| Geth | cro-http: FCO++ created pull request #207: Adding named endpoints |
16:42 | |
| SmokeMachine | ☝️ I created this PR, it probably isn't good enough, but I decided to PR it anyway to let you all to critic and comment on it and that way I'll be able to fix the problems (if it's interesting to have named endpoints on Cro). | 16:44 | |
| librasteve_: ☝️ | 16:46 | ||
| if/when that's accepted I'll be able to update Crolite to not use RouterUtils and depends only on Cro... | 17:11 | ||
|
20:24
ds7832 left
|
|||
| SmokeMachine | It seems there is a PR that does what I’ve done on my PR, but it looks better and it seems to do more stuff: github.com/croservices/cro-http/pull/152 | 23:25 | |
| But it seems to be from 4 years ago… | 23:26 | ||
| Another thing, would someone like to review this one? github.com/croservices/cro-http/pull/205 | 23:47 | ||