|
Welcome the channel on the development of Cro, a set of libraries for building reactive distributed systems, lovingly crafted to take advantage of all the Raku Programming Language has to offer (cro.services). This channel is being logged for historical purposes. Set by lizmat on 24 May 2021. |
|||
| librasteve_ | lizmat: are you ok for me to merge github.com/croservices/cro-http/pull/214 ? | 11:21 | |
| (I just want to have a 2nd pair of eyes for deep changes like this in case any possible side-effects I have not considered - then I can go ahead with a point release of cro-http) | 11:23 | ||
| Geth | cro-http/main: a2949b6443 | (Fritz Zaucker)++ (committed using GitHub Web editor) | lib/Cro/HTTP/Middleware.rakumod Fix unbounded memory growth in Conditional middleware (#214) The Conditional middleware's Response transform taps the per-connection `early-responses` Supplier but never completes it. The RequestResponse middleware completes the same Supplier via `LAST ... .done` when its response pipeline ends; Conditional omitted this, so the Supplier (and the connection-scoped state reachable from its subscription) was retained, ... (11 more lines) |
11:46 | |
| lizmat | librasteve_ yes :-) | 12:10 | |
| disbot4 | <librasteve> ah - already done - tx | 12:45 | |
| librasteve_ | croservices CI failure www.irccloud.com/pastebin/MoRpOkVv | 12:48 | |
| hi - we got ^^ this failure github.com/croservices/cro-openapi...8649520851 on the PR checks on croservices — any raku CI folks who know the fix? | 12:49 | ||
| lizmat | raku-version: 2021.03 ??? | 12:51 | |
| feels like a YAML fix is needed > | |||
| ? | |||
| librasteve_: removed the reference to 2021.03... testing only latest Raky | 12:54 | ||
| Raku | |||
| not sure why Geth didn't report | 12:55 | ||
| disbot4 | <librasteve> what is the platform test strategy for Cro - do we / should we span (or cover) "an old one" + "latest" [I had naively thought that we would want to not drop the quite old 2021.03 since that has been working all along] | 12:57 | |
| <librasteve> I am happy to drop it, but would just like to understand the plan | 12:58 | ||
| lizmat | well, the test failed because the image for 2021.03 could not be found | 12:59 | |
| fwiw, I've added an organization-wide webhook, so all croservices repos will report here | 13:11 | ||
| and removed any other webhooks from the cro repos (they were either identical or non-functional) | |||
| Geth | cro-openapi-routes-from-definition/main: f970092dba | (Elizabeth Mattijsen)++ (committed using GitHub Web editor) | .github/workflows/ci.yml Add Raku version 2022.04 to CI workflow |
13:13 | |
| disbot4 | <librasteve> ok, capiche | 13:28 | |
| Geth | cro-openapi-routes-from-definition/main: a38c4db639 | (Fritz Zaucker)++ (committed using GitHub Web editor) | 2 files Fix OperationHandler for Cro::HTTP::Router 0.8.12+ Cro::HTTP 0.8.12 added a per-handler `.name` lookup and `.url-prefix` assignment in `Cro::HTTP::Router::RouteSet.definition-complete` (used when a `route` block does `include 'foo' => ...` with a handler from this module). The built-in `RouteHandler` declares both attributes; `OperationHandler` did not, so any pattern that includes an OpenAPI ... (18 more lines) |
13:47 | |
|
15:00
japhb left
15:09
japhb joined
17:26
librasteve_ left
19:06
japhb left
19:17
japhb joined
|
|||