github.com/moarvm/moarvm | IRC logs at irclog.perlgeek.de/moarvm/today
Set by moderator on 25 July 2013.
00:18 benabik joined 01:12 FROGGS_ joined
dalek arVM/readlineintfh2: cd6f2d5 | jimmy++ | / (10 files):
added Windows-compatible version of linenoise, and so updated to newest linenoise. Now it works on Windows.

NOTE: refreshMultiLine() didn't work on Windows yet, but we don't need this future now.
02:46
JimmyZ ^^ I didn't test on linux, I have no linux box :-) 02:50
dalek arVM/readlineintfh2: 95975f4 | jimmy++ | nqp-cc/nqp-src/NQPHLL.nqp:
uncomment more code in NQPHLL.nqp
02:53
arVM/readlineintfh2: 1085cd2 | jimmy++ | 3rdparty/linenoise/linenoise.c:
small fixes
03:00
arVM/readlineintfh: 10b0f88 | jimmy++ | / (2 files):
small fixes
03:11
arVM/readlineintfh: 0f03de9 | jimmy++ | 3rdparty/linenoise/ (3 files):
added linenoise to 3rdparty
03:18
arVM/readlineintfh: 3d868dd | jimmy++ | / (7 files):
added readlineintfh op
arVM/readlineintfh: 355a98f | jimmy++ | src/io/fileops.c:
small refactor, FROGGS++
arVM/readlineintfh: cd6f2d5 | jimmy++ | / (10 files):
added Windows-compatible version of linenoise, and so updated to newest linenoise. Now it works on Windows.

NOTE: refreshMultiLine() didn't work on Windows yet, but we don't need this future now.
arVM/readlineintfh2: 02ac1ba | jimmy++ | / (2 files):
small fixes
03:24
03:45 crab2313 joined 03:59 crab2313 joined
diakopter JimmyZ: how much ram do you have? you an use virtualbox to install linux 04:40
or vmware player
vmware player is generally better 04:41
04:45 birdwindupbird joined
JimmyZ diakopter: I have a virtualbox, didn't set up moarvm yet 04:50
dalek arVM/readlineintfh: d4eed58 | jimmy++ | / (2 files):
small fixes
05:05
JimmyZ ok, now it builds no linux 05:07
gist.github.com/zhuomingliang/6119449 , if anyone wants to test on linux 05:10
:P
s/no/on/ 05:41
dalek arVM/readlineintfh2: 6144dc5 | jimmy++ | / (2 files):
small fixes
06:33
JimmyZ readline now works well with ctrl+key on windows :-) 06:35
07:25 FROGGS[mobile] joined 07:42 FROGGS joined
FROGGS gmorning #moarvm 07:59
dalek arVM/readlineintfh: a854226 | jimmy++ | / (2 files):
small fixes
08:00
FROGGS JimmyZ++ # \\o/ 08:01
JimmyZ FROGGS: good moarning
FROGGS *g*
JimmyZ FROGGS: please test on linux if you have time, gist.github.com/zhuomingliang/6119449
It works pretty well on windows now 08:02
FROGGS sure, I will 08:03
08:19 odc joined
FROGGS JimmyZ: there are just one/two minor issues 08:52
1) it crashes when doing CTRL+c 08:53
2) it does funny things when you type a tab
when you then press the up-key, the blinking cursor has the size of a tab
and if you type chars before a tab, it displays these chars after the tab too, when you press enter then, it doesnt display these chars at all 08:54
JimmyZ FROGGS: weird, I din't change any code on linux
FROGGS: could you change linenoise.c to the original one and try again? 08:55
FROGGS sure 08:56
JimmyZ: it does the same 08:59
JimmyZ FROGGS: so not me break it 09:02
FROGGS nope
JimmyZ FROGGS: actually windows ver is aslo broken
FROGGS looks like linenoise is not well maintained when looking at the github repo
JimmyZ FROGGS: I fixed it 09:03
FROGGS are you going to push this upstream? 09:09
JimmyZ nope
there are two upstream
one for lua and one for redis on windows
FROGGS ohh
JimmyZ maybe one for linenoise itself too... 09:10
FROGGS: feel free to push to these there upstreams :P 09:11
*three
FROGGS I'd thought about linenoise itself
JimmyZ FROGGS: yeah, that's better
FROGGS would be nice to have tests for it though 09:12
JimmyZ yeah
FROGGS would that work that you open something like "nqp -e" as a pipe in, say Perl 5, and do some "real testing" there? 09:13
JimmyZ doesn't know 09:14
FROGGS k
JimmyZ E:\\opensource\\MoarVM\\nqp-cc>echo sdfsdf | nqp nqp-moar-cc.nqp test.nqp 09:15
sdfsdf
works well 09:16
FROGGS cool 09:22
and it doesnt segfault for you at the end?
JimmyZ it doesn't 09:23
badthing is that I don't know how to decode GBK encoding 09:31
so I can't type chinese in readline 09:32
FROGGS well, I can't either :P
JimmyZ maybe someday I will steal ideas from mb_* function in PHP 09:33
FROGGS: could you try press esc and see whether it will be segfault? 09:35
FROGGS ESC does nothing 09:36
JimmyZ ok
09:45 crab2313 joined 10:34 crab2313 joined 11:00 yoleaux joined 12:06 benabik joined 13:13 ggoebel joined 13:54 crab2313 joined
JimmyZ FROGGS: looks like there is segfault when I press ctrl+c on win32 also, I got in the the msvc debugger 13:59
FROGGS JimmyZ: I think that is because ctrl+c isnt catched ba isnull and !defined, and then dies when attempting to print it 14:01
JimmyZ FROGGS: I don't think so, I press ctrl+s, noting happend 14:03
nothing
ctrl-c is system interrupt 14:04
FROGGS comment out the nqp::say($code)
it acts like pressing enter then
(on my box)
JimmyZ comment out also segfault 14:05
FROGGS hmmm
dalek arVM/readlineintfh: 5300215 | jimmy++ | 3rdparty/linenoise/linenoise.c:
added support for HOME and END keys and prevent duplicate consecutive lines,

also added ctrl-r search for linenoise, originally the patch is from Jalil Karimov, see github.com/antirez/linenoise/pull/29 I changed it starting from last line, also added Windows support for ctrl-r
14:16
JimmyZ ^^ You will like it :P
FROGGS :o) 14:17
JimmyZ++
JimmyZ it really good, we almost don't need readline lib any more. 14:24
dalek arVM/readlineintfh: 846a227 | jimmy++ | 3rdparty/linenoise/linenoise.c:
make some function static
14:35
JimmyZ FROGGS: I think I know why it segfault 15:36
FROGGS: it needs add signal/sigaction to catch SIGINT 15:38
FROGGS aha, okay 15:39
JimmyZ I'm not sure, for windows see msdn.microsoft.com/en-us/library/wi...85%29.aspx 15:41
dalek arVM/readlineintfh: 40ad29c | jimmy++ | 3rdparty/linenoise/linenoise.c:
fixed win32 segfault when press ctrl-c
16:12
JimmyZ FROGGS: I got a patch to fix linux segfault 16:16
FROGGS: pull lastest commit , and try
- raw.c_lflag &= ~(ECHO | ICANON | IEXTEN | ISIG); 16:17
+ raw.c_lflag &= ~(ECHO | ICANON | IEXTEN);
good night
FROGGS gnight
will do when I am at home
diakopter howdy channel 16:22
benabik diakopter: greetings and salutations 16:23
18:18 Alpha64 joined 18:21 FROGGS joined 18:25 Alpha64_ joined 19:21 Alpha64 joined 19:25 Guest1337 joined 20:12 colomon joined 20:20 FROGGS joined 20:42 benabik joined 20:48 benabik joined 22:11 benabik joined 23:13 benabik joined
FROGGS JimmyZ: it works with the patch you gave me: 23:24
<JimmyZ> - raw.c_lflag &= ~(ECHO | ICANON | IEXTEN | ISIG);
<JimmyZ> + raw.c_lflag &= ~(ECHO | ICANON | IEXTEN);
and now it even displays something when pressing ESC 23:25
"it works" means that ctrl+c shuts it down properly
ohh, but up/down doesnt work anymore
hmmm, actually that pasted patch doesnt matter..., I have the same behaviour with latest HEAD 23:27