|
05:52
kjp left
05:56
kjp joined
|
|||
| Geth | MoarVM/unicode-18.0: 15 commits pushed by Faye++ review: github.com/MoarVM/MoarVM/compare/1...06d11226b1 |
12:02 | |
| MoarVM: ShimmerFairy++ created pull request #2050: Update for Unicode 18.0 |
12:08 | ||
| ShimmerFairy | As mentioned in the pull request, I also picked off a couple of longstanding issues around properties in particular, though there's still work to be done in the future. | 12:10 | |
| lizmat | Let's see what CI says :) ShimmerFairy++ | ||
| if merged, would you like to see it squashed, or each commit merged separately? | 12:11 | ||
| ShimmerFairy | I don't mind either way. I was worried I make too many "atomic" commits, but I like keeping each thing I do separate. I think for the most part squashing it might make more sense as a single logical "update Unicode" commit (and likely helps the automated changelog checker I think we have), though it isn't strictly speaking *just* fallout from upgrading. | 12:14 | |
| The one big thing where squashing would help is with the big pregenerated source files, I had to generate them a couple times and eliminating a couple big files via squashing would possibly be a kind thing to do (depends on how specifically squashing works). | 12:15 | ||
| lizmat | my understanding is that it takes the diff of all the commits, and creates a single commit for that | 12:20 | |
| ShimmerFairy | That's what I figured. Like I said, it's fine either way with me. I think the only real loss would be the wordy explanations I wrote in my commits, but I think most of the "along the way" fixes are pretty obvious just by looking at them. | 12:23 | |
| Just in case there are CI breakages, I can at least attest to the NQP tests, rakudo tests, and spec stresstest (less Perl5 tests) working just fine, aside from one flappy repl test in rakudo and a spectest that always coredumps on me. | 12:27 | ||
| Ah, seeing the rakudo test failure, I suppose I should've seen the addition of two new huge blocks of characters causing problems with old tests coming. | 12:32 | ||
|
14:46
timo joined
|
|||