| samcv | that's a long link | 00:20 | |
|
01:02
evalable6 joined
01:17
colomon joined
02:56
ilbot3 joined
04:10
evalable6 joined
05:07
evalable6 joined
05:59
evalable6 joined
07:32
evalable6 joined
08:07
domidumont joined
08:12
domidumont joined
|
|||
| nine | 2 answers to my question from yesterday so far: we can't annotate the last instruction of the inlinee before merging because #1 we need it's index in the inlines table and more importantly #2 the last instruction can and probably will change as we replace the return statement by a set and goto | 08:48 | |
| But maybe we still can. We could also move the end annotation when replacing the last instruction. | 08:54 | ||
| A nicer way would be to do all the rewriting before the merging. But I don't know yet if that's even possible or if the rewriting needs information that's available only after the merge. Have to read more code... | 09:00 | ||
| Or maybe it's much, much simpler. merge_graph does know exactly the last basic block of the inlinee. We don't change the list of basic blocks of the inlinee. We only change instructions. So the information stays correct. | 09:15 | ||
|
09:34
AlexDaniel joined
09:52
domidumont joined
10:20
evalable6 joined
11:03
nativecallable6 joined,
quotable6 joined,
releasable6 joined,
committable6 joined,
bloatable6 joined,
evalable6 joined,
benchable6 joined,
unicodable6 joined,
bisectable6 joined,
coverable6 joined,
greppable6 joined,
squashable6 joined,
statisfiable6 joined
|
|||
| nine | Oooh...disabling eliminate_pointless_gotos improves things a lot. So that's where the MVM_SPESH_ANN_INLINE_END annotation goes missing | 11:25 | |
|
11:37
lizmat joined
13:17
evalable6 joined
13:21
domidumont joined
13:40
TimToady joined
13:45
dogbert17 joined
14:28
TimToady joined
|
|||
| timotimo | sounds like it needs to consider some more gotos "not pointless" :) | 15:33 | |
|
15:57
domidumont joined
|
|||
| jnthn | Well, or to move the annotation better :) | 15:57 | |
|
15:59
zakharyas joined
16:04
zakharyas joined
16:39
ggoebel joined
16:57
MasterDuke joined
19:23
evalable6 joined
19:43
unicodable6 joined,
benchable6 joined,
bloatable6 joined,
nativecallable6 joined,
greppable6 joined,
quotable6 joined,
evalable6 joined,
committable6 joined,
coverable6 joined,
bisectable6 joined,
releasable6 joined,
squashable6 joined,
statisfiable6 joined
20:15
MasterDuke joined
20:26
camelia joined
21:26
stmuk joined
21:38
zakharyas joined
23:16
ggoebel joined
|
|||