Geth MoarVM: e87a74130b | (Stefan Seifert)++ | src/core/nativecall.c
Remove some duplicated code

This is already done in lines 461 and 463 (before processing argument processing nodes).		 16:42
dogbert17 nine: are you a nativecall expert? 17:11
japhb dogbert17: He constantly claims that he is not, yet he's responsible for both Inline::Perl5 and Inline::Python. :-) 17:38
Plus of course nativecall JIT optimizations 17:39
dogbert17 japhb: I'm wondering about this line, github.com/MoarVM/MoarVM/blob/mast...call.c#L19 17:41
it must be incorrect as a check for 'stdcall' is made on line 13
or, it's correct and line 13 is fishy 17:43
japhb Yep, one of those is wrong, I agree. 18:02
"vectorcall" for the x64 one, maybe? (Not a windows programmer, just noticed it in the wikipedia article for stdcall) 18:04
nine dogbert17: well that's certainly unreachable code 18:40
nine Wikipedia tells me that on x86-64 there's only one calling convention in Windows (and UEFI) and one for everything else 18:55
dogbert17 nine: do you think the test, on line 19, should be removed? 18:56
timotimo what happened to all the other calling conventions windows has? 19:04
nine Looks to me like this should be more correct: gist.github.com/niner/9cf08c0f83a0...13ab383ef0 19:07
Except for the missing #endif of course 19:08
I do have the suspicion however that dyncall ignores the dcMode on x86_64 anyway. It's documentation already says that it will ignore invalid platform/mode combinations.
Also #ifdef __x86_64__ is probably not the proper cross-platform way to check for that architecture 19:10
dogbert17 is there a proper cross-palform way? 19:22
*platform
nine Updated the gist with a probably more correct version 19:25
Compiles and runs just fine on x86_64 Linux.
But then, so did the previous code :)
dogbert17 sounds promising :) 19:26
nine dogbert17: do you actually see a problem with this code or did you just come across it and noticed the oddity? 19:27
samcv i think i may attempt to add proper integer property values to ucd2c.pl because right now it doesn't store it as an enum it just stores it using the full number of bits 21:02
dogbert17 nine: sorry for the late reply, was out eating. I saw no problem but cppcheck did :) On the other hand, there might possibly be a problem but obviously not on Linux, which is what I have. 22:08

Powered by Cro and the Raku® Programming Language.

Please report any issues / comments / feature requests as an issue on App::Raku::Log.

Thank you!