|
00:35
dalek joined,
synopsebot joined
00:37
Geth joined,
SourceBaby joined
00:57
patrickz_ joined
00:59
evalable6 joined
02:58
ilbot3 joined
04:26
reportable6 joined
04:51
reportable6 joined
08:16
AlexDaniel joined
08:21
AlexDaniel joined
09:03
robertle joined
09:11
domidumont joined
09:19
domidumont joined
10:44
reportable6 joined
10:45
reportable6 joined
11:06
MasterDuke joined
11:09
Ven`` joined
13:03
brrt joined
13:22
AlexDaniel joined
13:31
reportable6 joined
|
|||
| timotimo | every few months i seem to fail at shrinking phi nodes | 13:44 | |
|
13:47
reportable6 joined
|
|||
| moritz | try psi nodes next time :-) | 13:54 | |
|
14:16
geospeck joined
14:18
robertle joined
14:59
geospeck joined
|
|||
| timotimo | the first difference that seems wrong appears in the spesh log at line 17.6k | 15:19 | |
| hm, but what if it's actually correct, and the phi shrinking actually manages to do something good? | 15:20 | ||
| and i've just been staring at perfectly benign code ... | |||
|
15:43
Ven`` joined
16:02
Voldenet joined
16:08
lizmat joined
|
|||
| dogbert17 | timotimo: are there any 'easy' optimization wins left in MoarVM now? | 16:09 | |
| clickbaits lizmat: irclog.perlgeek.de/perl6-dev/2017-...i_15525445 | 16:13 | ||
| lizmat looks | 16:18 | ||
| ah, test-t < 3 ? yeah cool! | 16:19 | ||
| dogbert17 | jnthn and timotimo at work | 16:20 | |
| dogbert17 oO (stumbles upon a valgrind error in a Proc::Async-test) | 16:21 | ||
| ==20866== Conditional jump or move depends on uninitialised value(s) | 16:22 | ||
| ==20866== at 0x418355B: optimize_throwcat (optimize.c:1728) | |||
| ==20866== by 0x418355B: second_pass (optimize.c:2348) | |||
| ==20866== by 0x41834F6: second_pass (optimize.c:2356) | |||
| jnthn | Poor cat... | 16:23 | |
| dogbert17 | indeed :) | 16:24 | |
| was going to look for potential memory leaks but got distracted by this | |||
| test 36 in t/spec/S17-procasync/basic.t ('Process that doesn't output anything will not emit') | 16:26 | ||
| should be this piece of code: github.com/MoarVM/MoarVM/blob/mast...ze.c#L1728 | 16:28 | ||
| jnthn | Could well be | 16:30 | |
| Oh, I wonder | |||
| It could be the new inline boundary indicators I stuck into the handlers table | |||
| That probably doesn't set action | 16:31 | ||
| But since it's just an integer compare, and even if it accidentally matches then the line below won't match anyway, it'll be benign | |||
| Still, worth squishing the warning | |||
| dogbert17 | so you've already solved it, impressive. Do you want an issue? | ||
| jnthn | github.com/MoarVM/MoarVM/blob/mast...ine.c#L549 | 16:32 | |
| Adding inliner->handlers[*inline_boundary_handler].action = 0; here will likely clean up the warning | |||
| Yeah, issue, or if you're up for trying out adding that line and seeing if it helps and sending a PR, that also works :) | 16:33 | ||
| dogbert17 | I could do that unless you'd like to do it yourself :) | ||
| jnthn | I can't right now :) | ||
| dogbert17 | ok, you can see a PR in your future :) | 16:34 | |
| jnthn | Cool, thanks :) | ||
| jnthn away for a bit | |||
|
16:46
vendethiel- joined
|
|||
| Geth | MoarVM: dogbert17++ created pull request #760: Impl. of the new inline boundary indicators forgot to set action |
16:54 | |
|
17:03
wander joined
17:19
Ven`` joined
18:12
patrickz joined
|
|||
| Geth | MoarVM: 41050d1894 | (Jan-Olof Hendig)++ | src/spesh/inline.c Impl. of the new inline boundary indicators forgot to set action The newly implemented inline boundary indicators omitted to set the action field. This led to a warning from valgrind. Although the warning was benign in this case, it should be fixed anyway. jnthn++ for providing the fix. |
18:16 | |
| MoarVM: 3c7b49e8f0 | (Jonathan Worthington)++ (committed using GitHub Web editor) | src/spesh/inline.c Merge pull request #760 from dogbert17/fix-uninit-action Impl. of the new inline boundary indicators forgot to set action |
|||
|
19:35
releasable6 joined
19:36
unicodable6 joined,
bisectable6 joined,
committable6 joined
20:33
benchable6 joined
21:40
greppable6 joined
|
|||