|
00:27
Kaiepi joined
00:32
Kaiepi joined
00:38
Kaiepi joined
01:16
nativecallable6 joined,
statisfiable6 joined,
releasable6 joined
01:17
unicodable6 joined,
committable6 joined,
quotable6 joined
02:57
ilbot3 joined
04:51
piojo joined
04:55
piojo joined
05:29
Kaiepi joined
07:02
Kaiepi joined
07:04
Kaiepi joined
08:01
domidumont joined
08:08
domidumont joined
08:20
zakharyas joined
09:00
geekosaur joined
09:04
geekosaur joined
09:52
scovit joined
11:21
domidumont joined
|
|||
| dogbert17 | o/ would anyone object if I created a PR to get rid of this line: github.com/MoarVM/MoarVM/blob/mast...ect.c#L265 | 11:53 | |
|
12:02
reportable6 joined
|
|||
| lizmat | seems pretty harmless, why remove it ? | 12:17 | |
| dogbert17 | lizmat: it causes a SEGV :) and to me it's far from obvious what its purpose is, casting an '1' to a pointer | 12:19 | |
| lizmat | then by all means, PR and remove it :) | 12:20 | |
| dogbert17 | ok will do, at worst it'll be rejected :-) | 12:21 | |
|
12:25
MasterDuke joined
|
|||
| timotimo | you know, maybe the intention is actually to cause a segfault there so that the debugger stops on its own | 12:36 | |
| lizmat | would one not document that then, that that is the intention ? | 12:37 | |
| timotimo | *shrug*, maybe the code was too obviously a way to cause a segfault to say that's what it does | 12:39 | |
| like, you *can* make 1 a valid address, you just have to map some memory there. you can't do that unless you run the program as root and i don't think anything in moar has any code at all to do such a thing | |||
| so saying /* cause a segfault */ is like i++ /* increment i by one */ | |||
| i'll remove the code without the need for a PR | 12:41 | ||
| Geth | MoarVM: 5710340878 | (Timo Paulssen)++ | src/gc/collect.c remove strange segfault-inducing debug code don't have a good explanation why this was ever there to begin with dogbert17++ |
12:42 | |
| dogbert17 | timotimo++ | 12:45 | |
| timotimo: btw, how are your wrist? | 12:47 | ||
| *wrists | |||
|
12:59
travis-ci joined
|
|||
| travis-ci | MoarVM build passed. Timo Paulssen 'remove strange segfault-inducing debug code | 12:59 | |
| travis-ci.org/MoarVM/MoarVM/builds/325011674 github.com/MoarVM/MoarVM/compare/4...103408786d | |||
|
12:59
travis-ci left
|
|||
| timotimo | i had to put undue stress on them yesterday and the day before that, their state got a bit worse from that | 13:27 | |
| dogbert17 | :( | 13:57 | |
|
14:02
zakharyas joined
14:37
domidumont joined
15:26
geospeck joined
15:27
domidumont joined
15:32
Kaiepi joined
15:46
committable6 joined
16:58
squashable6 joined
17:22
bloatable6 joined,
coverable6 joined,
benchable6 joined
17:31
AlexDaniel joined
17:39
bisectable6 joined
18:14
Kaiepi joined
18:55
geospeck joined
19:39
greppable6 joined
19:53
Ven`` joined
19:59
Kaiepi joined
20:05
FROGGS joined
20:59
evalable6 joined
21:22
Kaiepi joined
22:24
geospeck joined
22:28
lizmat joined
22:41
geospeck joined
|
|||