dogbert17 o/ would anyone object if I created a PR to get rid of this line: github.com/MoarVM/MoarVM/blob/mast...ect.c#L265 11:53
lizmat seems pretty harmless, why remove it ? 12:17
dogbert17 lizmat: it causes a SEGV :) and to me it's far from obvious what its purpose is, casting an '1' to a pointer 12:19
lizmat then by all means, PR and remove it :) 12:20
dogbert17 ok will do, at worst it'll be rejected :-) 12:21
timotimo you know, maybe the intention is actually to cause a segfault there so that the debugger stops on its own 12:36
lizmat would one not document that then, that that is the intention ? 12:37
timotimo *shrug*, maybe the code was too obviously a way to cause a segfault to say that's what it does 12:39
like, you *can* make 1 a valid address, you just have to map some memory there. you can't do that unless you run the program as root and i don't think anything in moar has any code at all to do such a thing
so saying /* cause a segfault */ is like i++ /* increment i by one */
i'll remove the code without the need for a PR 12:41
Geth MoarVM: 5710340878 | (Timo Paulssen)++ | src/gc/collect.c
remove strange segfault-inducing debug code

don't have a good explanation why this was ever there to begin with
  dogbert17++		 12:42
dogbert17 timotimo++ 12:45
timotimo: btw, how are your wrist? 12:47
*wrists
travis-ci MoarVM build passed. Timo Paulssen 'remove strange segfault-inducing debug code 12:59
travis-ci.org/MoarVM/MoarVM/builds/325011674 github.com/MoarVM/MoarVM/compare/4...103408786d
timotimo i had to put undue stress on them yesterday and the day before that, their state got a bit worse from that 13:27
dogbert17 :( 13:57

Powered by Cro and the Raku® Programming Language.

Please report any issues / comments / feature requests as an issue on App::Raku::Log.

Thank you!