github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
MasterDuke is it the enum or the tc->cur_frame->static_info that's most wrong 00:02
timotimo i think using the cur_frame at the point where profiling is turned on is wrong 00:06
MasterDuke thread_entry_frame? 00:10
nope, that causes a segv 00:14
timotimo sorry, brain is too mush to think
MasterDuke no worries. but let me know if inspiration strikes in the night 00:15
nine timotimo: now ;) 07:23
timotimo now what? 09:07
MasterDuke nine: did you see my question in github.com/MoarVM/MoarVM/pull/935 ? 10:40
timotimo i somehow totally forgot about the existence of strdup 10:54
MasterDuke heh 11:05
timotimo so yeah, that's probably the right fix 11:06
MasterDuke k, i'll update the PR 11:11
timotimo i wonder if we want to limit it to some upper bound and use strndup 11:25
MasterDuke timotimo: why do all the other MVM_telemetry_interval_* functions just do `record->u.annotation.description = description;`? i.e., directly assign the passed in string
timotimo because those are required to have constant strings 11:31
i.e. these pointers would point into the read-only section of the libmoar.so 11:32
pretty much a requirement for good performance, i think
MasterDuke oh, i see this one is named *_dynamic, didn't even look at the name before
timotimo: any particular suggestion for a limit? 11:39
timotimo 1024 is probably a very conservative limit 11:41
MasterDuke timotimo: PR updated 11:49
lizmat tyil++ 11:51
MasterDuke timotimo: any reason not to merge? 12:18
timotimo don't think so, go ahead if you want 12:19
MasterDuke good, will do
oh right, Geth isn't working here 12:21
no warnings for me using gcc 8.3.0 now 12:25
timotimo jnthn, can you set up geth.svc.tyil.net/ on github.com/moarvm/moarvm/settings/hooks/
MasterDuke still a bunch with clang. mostly `warning: '&&' within '||' [-Wlogical-op-parentheses]` 12:26
timotimo probably no harm in cleaning that up
MasterDuke timotimo: also a bunch of `src/debug/debugserver.c:431:1: warning: control may reach end of non-void function [-Wreturn-type] }` 12:32
MasterDuke src/core/interp.c:99:1: warning: control may reach end of non-void function [-Wreturn-type] 12:35
travis-ci MoarVM build passed. MasterDuke17 'Use strndup instead of malloc+strncpy (#935) 12:38
travis-ci.org/MoarVM/MoarVM/builds/531112635 github.com/MoarVM/MoarVM/compare/f...7b92f929ce
Geth MoarVM: 807b92f929 | MasterDuke17++ (committed using GitHub Web editor) | src/profiler/telemeh.c
Use strndup instead of malloc+strncpy (#935)

This is simpler and also silences an incorrect GCC warning.		 12:56
jnthn timotimo: Done; redelivered ^ to test it :)
timotimo \o/ 12:57
thank you
MasterDuke nice 13:03
Geth MoarVM: MasterDuke17++ created pull request #1100:
Silence -Wlogical-op-parentheses warnings in clang		 19:33

Powered by Cro and the Raku® Programming Language.

Please report any issues / comments / feature requests as an issue on App::Raku::Log.

Thank you!