github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
MasterDuke timotimo: how come some functions don't get linkified by your script even though the corresponding filename is? 11:53
timotimo give me an example and i'll see that i wiggle the regex around 11:57
MasterDuke the bottom comment on github.com/MoarVM/MoarVM/issues/1105 12:02
#1 in the backtrace, check_reg 12:03
oh, and that one has some files that aren't linkified 12:04
timotimo i've got a little whitelist of things that are valid moar-related "first argument in argument list" things, like tc, instance, ... 12:09
"idx" is not among them
and neither is "data"
not entirely sure if the whitelist is a sensible approach 12:10
oh, i think my script is actually killing syntax highlighting in gists 12:17
updated the gist: gist.githubusercontent.com/timo/7c...Linkify.js 12:19
fixes gist syntax highlighting as well 12:21
MasterDuke cool, catches more stuff. it does now sometimes highlight the whole line though 12:59
timotimo examples, please? 14:19
MasterDuke #1 and #4 in the bottom comment of github.com/MoarVM/MoarVM/issues/1105 14:49
timotimo interesting. but but it does linkify the entire thing from start to end 15:21
so that's okay to me
MasterDuke yeah, works fine, just cosmetic nitpicking 17:45
timotimo OK 17:49
MasterDuke oooooo, can you do the same thing for rakudo backtraces? 17:52
timotimo it's already in 17:54
do you have one where it doesn't happen?
MasterDuke timotimo: oh, is it supposed to already? 22:52
timotimo yes 22:53
MasterDuke nice. but github.com/rakudo/rakudo/issues/2921 has a backtrace with at least one line that could be highlighted 22:55
github.com/rakudo/rakudo/issues/2738 has some too 22:58
oh! 22:59
now it's working!
wait, this is the link it's creating github.com/MoarVM/MoarVM/blob/mast....nqp#L2861 so not quite right... 23:00
timotimo it makes some NaN links, eh?
an earlier version of the script should work better 23:01
i changed the regex a lot to add support for valgrind output
MasterDuke some NaN links, but see it's also trying to link to rakudo files in the moarvm repo
timotimo that explains it then
it's getting the wrong branch
MasterDuke afk for dinner, but timotimo++ 23:02