github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
00:45 anatofuz left 00:46 anatofuz joined 00:53 anatofuz left 01:01 lucasb left 01:09 anatofuz joined 01:20 MasterDuke left 01:50 AlexDani` joined 01:51 Kaiepi joined 01:54 AlexDaniel left 02:20 squashable6 left 02:23 squashable6 joined
timotimo cdn.discordapp.com/attachments/538...nknown.png - showing incoming refs of the STable of QAST::Var shows a whole bunch of QAST::Var objects appearing in a heap snapshot 02:33
02:51 anatofuz left 02:52 anatofuz joined 02:58 anatofuz left 03:08 anatofuz joined 03:35 anatofuz left 03:41 anatofuz joined 03:46 anatofuz left 04:43 ZzZombo joined 05:01 anatofuz joined 05:03 anatofuz left 05:08 ZzZombo left 05:09 ZzZombo joined 05:29 anatofuz joined 05:33 anatofuz left 05:41 anatofuz joined 05:45 anatofuz left 06:14 ZzZombo_ joined 06:16 ZzZombo left, ZzZombo_ is now known as ZzZombo 06:20 anatofuz joined 06:27 anatofuz left 06:56 anatofuz joined 07:36 anatofuz left 07:37 anatofuz joined 07:42 anatofuz left 07:47 anatofuz joined 07:52 anatofuz left, anatofuz joined 08:00 zakharyas joined, anatofuz left 08:02 anatofuz joined, anatofuz left 08:10 anatofuz joined 08:20 anatofuz left 08:21 anatofuz joined 08:36 ZzZombo_ joined 08:39 ZzZombo left, ZzZombo_ is now known as ZzZombo 08:46 ZzZombo_ joined 08:48 ZzZombo left, ZzZombo_ is now known as ZzZombo 08:50 anatofuz left, anatofuz joined 09:19 anatofuz left 09:24 zakharyas left 09:26 zakharyas joined 09:29 ZzZombo left 09:41 anatofuz joined 09:45 anatofuz left 09:59 anatofuz joined 10:03 ZzZombo joined 10:04 anatofuz left 10:24 AlexDani` is now known as AlexDaniel, AlexDaniel left, AlexDaniel joined 10:51 zakharyas left 10:52 zakharyas joined 11:04 zakharyas left 11:43 squashable6 left 11:47 squashable6 joined 13:11 zakharyas joined 13:53 eaterof joined 13:54 Util_ joined 13:55 eater left, kawaii left, tadzik left, kawaii joined 13:57 tadzik joined 13:58 mornfall joined 14:04 lucasb joined
Guest3346 .seen timotimo 15:06
tellable6 Guest3346, gist.github.com/e9190f0dccb3a64ca9...c52570c7ee
16:20 zakharyas left 16:34 patrickb joined
Kaiepi can someone review M#1190? 17:10
synopsebot M#1190 [open]: github.com/MoarVM/MoarVM/pull/1190 [IP6NS Grant] Close synchronous sockets properly
18:31 MasterDuke joined
dogbert17 Ah, it's MasterDuke 18:38
been looking for you :) 18:39
MasterDuke heh. i saw that mention yesterday and wasn't sure why at first
then figured out it looked like the valgrind problem was called by my more-context-in-error-messages commits 18:40
dogbert17 it's about a valgrind issue with t/spec/S17-procasync/encoding.t
try it
MasterDuke yep, can repro 18:41
dogbert17 do you think it's been there all the time or are the changes to the file somehow involved? 18:42
btw, I'm looking for timotimo as well regarding another matter :) 18:43
MasterDuke i'm not 100% sure, but it looks like my code is involved, so i would assume it's recent 18:44
dogbert17 I believe so although I'm far from certain 18:45
MasterDuke looks like it might be the cast of `MVMGrapheme32 *buffer` into `char *` 18:48
dogbert17 if I go back to MoarVM b72a790b1b21c88c the problem vanishes
aha 18:49
19:04 Kaiepi left 19:24 patrickb left 19:26 committable6 left 19:27 committable6 joined
timotimo o/ 19:31
dogbert17 hi timotimo 19:37
have a quick question for you? 19:38
is this code in use? github.com/MoarVM/MoarVM/blob/mast...ot.c#L1347 19:39
timotimo only if zstd is detected during Configure.pl time 19:40
dogbert17 cppcheck complains about lines 1364-5 claiming that 'entry' is not initialized. Could that be a problem? 19:41
timotimo ha 19:52
yeah, that could be kind of bad
on the other hand, i think entry isn't actually used?
does it highlight a place where it's used? 19:53
dogbert17 nope, I don't think the tool is that good 20:05
timotimo OK 20:10
because just looking over the code i couldn't find one
was potentially a left-over from copypasting the ver2 functions to make the ver3 ones
MasterDuke i probably won't have time to work on it again tonight, but the reason i used MVM_exception_throw_adhoc_free was because brrt didn't like repeating a free() call in every branch. is there a way to use a cast and/or MVM_exception_throw_adhoc_free that won't annoy valgrind? 20:57
21:03 Kaiepi joined 22:09 anatofuz joined 22:17 anatofuz left 22:37 anatofuz joined 22:44 anatofuz left 23:16 Kaiepi left 23:33 lucasb left