| IRC logs at
Set by AlexDaniel on 12 June 2018.
00:16 lucasb left 03:52 AlexDani` joined 03:56 AlexDaniel left 05:04 squashable6 left, nativecallable6 left, statisfiable6 left, unicodable6 left, coverable6 left, notable6 left, greppable6 left, committable6 left, quotable6 left, reportable6 left, shareable6 left, benchable6 left, releasable6 left 05:05 bloatable6 left, greppable6 joined, coverable6 joined, reportable6 joined 05:06 squashable6 joined, bloatable6 joined, releasable6 joined, benchable6 joined, quotable6 joined, shareable6 joined 05:07 committable6 joined, notable6 joined, statisfiable6 joined, unicodable6 joined, nativecallable6 joined 06:19 domidumont joined 06:29 domidumont left 06:32 domidumont joined 07:34 sena_kun joined 08:37 domidumont left
Geth MoarVM: 23daabadc9 | (Stefan Seifert)++ | src/io/signals.c
Fix memory corruption after cancelling signal

According to libuv docs, memory MUST only be released once uv_close on a handle runs the supplied callback. Otherwise, uv_run's cleanup will overwrite memory that has already been freed. Therefore we must ensure that we hold on to the async task (and it's SignalInfo structure) until uv_close calls the callback and only then remove the taks from the work queue.
nine It's certainly worth to look at other parts of IO as they may have the same issue with cancellation as ^^^! 08:50
(that means someone else should do it, as I'm still on vacation and should get some 2 hours of sleep before going on ) 08:51
nwc10 sleep well 08:52
lizmat nine++ 08:53
09:00 robertle joined 09:08 Altai-man_ joined 09:10 sena_kun left
jnthn Interesting: 10:06
(The whole thread, but the tweet I linked is the reason I mention it here)
oh, wait, I maybe linked the thread...anyway, the bit about JITs. :) 10:07
10:20 AlexDani` is now known as AlexDaniel, AlexDaniel left, AlexDaniel joined 10:56 Kaiepi left, Kaiepi joined 11:08 sena_kun joined 11:11 Altai-man_ left
lizmat yikes 12:37
12:52 tobs left, tadzik left, Util_ left, nine left 12:53 tobs joined, mornfall joined, hoelzro joined, tadzik joined, Util_ joined, nine joined 12:54 brrt joined 12:59 brrt left 13:07 lucasb joined 13:08 Altai-man_ joined 13:11 sena_kun left
Guest13443 nine: how was the Observatory? 13:42
13:55 Kaiepi left 13:57 Kaiepi joined 14:07 robertle left 14:08 Kaiepi left 14:09 robertle joined, Kaiepi joined
Geth MoarVM: 1b2f72e5e9 | (Stefan Seifert)++ | src/io/signals.c
Remove dead code

Accidentally committed leftover from debugging. Spotted by patzim++
15:08 sena_kun joined 15:10 Altai-man_ left
lizmat jnthn brrt: 16:03
seems related ?
16:03 robertle left 16:20 Kaiepi left 16:59 robertle joined 17:08 Altai-man_ joined 17:10 sena_kun left 18:00 MasterDuke joined 18:21 AlexDaniel` left, Kaiepi joined 18:40 domidumont joined 19:09 sena_kun joined 19:10 Altai-man_ left
nine Guest13443: absolutely fantastic! 19:26
19:36 brrt joined
brrt jnthn: I saw it.... I think 'suffer the consequences' is a bit much, but yeah 19:37
I'd prefer testing the real impact over rushing to implement the 'fix'
(which would be difficult to do given how dynasm works)
19:45 MasterDuke left 20:21 MasterDuke joined 20:42 brrt left 21:08 Altai-man_ joined 21:10 sena_kun left 21:27 lucasb left 21:28 domidumont left 22:38 Altai-man_ left 23:02 ZzZombo left 23:03 ZzZombo joined