github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
nine Looks like even with github.com/MoarVM/MoarVM/commit/fc...27ef6f81ec there's still some issue with finalizers and nested runloops. 09:37
I'll try to find a proper fix in the evening. 09:38
Please if you want to do a release before I got that fix, commit this workaround: gist.github.com/niner/b2988f1824f5...d9f26163f0 09:39
This restores the old behaviour which is also broken, but in a more benign way (missed DESTROY calls and potential memory leaks instead of segfaults) 09:40
nine Aaah...now I get it :) Funny how obvious such issues are once you find out what's going on. 15:08
lizmat waits in anticipation for the punchline 15:27
Geth_ MoarVM: 3806735a4b | (Stefan Seifert)++ | src/core/frame.c
Fix even more obscure crashes when returning from a native callback

The special_return or special_unwind handler may schedule a finalizer call for the current runloop. If we are already in the top most call frame of the runloop, we need to replace the thread_entry_frame with the finalizer call. Otherwise we won't run the special code for ending the runloop when the finalizer returns.		 15:48
nine lizmat: this ^^^ 15:49
But of course, there's yet another regression :( Reproducible with MVM_SPESH_NODELAY=1 MVM_SPESH_BLOCKING=1 perl6-gdb-m -Ilib t/data_in_module.t 16:07
Apparently caused (or uncovered) by github.com/MoarVM/MoarVM/commit/35...6542636fa5 which I pushed by accident
(hence the rather short commit message) 16:08
Ok, looks like this is not that bad. It's purely a side effect MVM_SPESH_NODELAY=1. With that, we never even run a non-optimized version of the code but start right away with the JIT compiled one. The JITed code however does not contain the check if the native library is loaded. 16:29
After all the non-JITed code would have long done this and we want to be fast.
So even changing the spesh threshold from 1 to 2 when MVM_SPESH_NODELAY=1 gets rid of the issue. So I conclude that this will never appear under normal circumstances and I can relax :) 16:30
The part I don't understand is why this doesn't break any other test files with MVM_SPESH_NODELAY=1 MVM_SPESH_BLOCKING=1. 16:33
Anyway, seems like we've regained stability and got rid of a couple bugs. A release with this would be very welcome :) 16:37
lizmat nine++ 18:26
nine Apparently the couple of weeks even payed off :) All green on the first try: build.opensuse.org/project/show/ho...ages:perl6 18:49
lizmat whee!
discord6 <sjn 🇳🇴> Yay! 19:48

Powered by Cro and the Raku® Programming Language.

Please report any issues / comments / feature requests as an issue on App::Raku::Log.

Thank you!