| IRC logs at
Set by AlexDaniel on 12 June 2018.
00:07 patrickz joined 00:11 patrickb left 00:42 sena_kun left 00:43 lucasb left 00:44 patrickz left 00:57 sena_kun joined 02:01 unicodable6 left, sourceable6 left, statisfiable6 left, reportable6 left, coverable6 left, notable6 left, quotable6 left, bloatable6 left, benchable6 left, releasable6 left, greppable6 left, squashable6 left, nativecallable6 left, bisectable6 left, shareable6 left, committable6 left 02:02 reportable6 joined, bisectable6 joined, sourceable6 joined, coverable6 joined, shareable6 joined, nativecallable6 joined 02:03 squashable6 joined, committable6 joined, notable6 joined 02:04 benchable6 joined, greppable6 joined, statisfiable6 joined, bloatable6 joined, unicodable6 joined, quotable6 joined, releasable6 joined 02:42 sena_kun left 02:57 sena_kun joined 03:57 evalable6 left, evalable6 joined 04:42 sena_kun left 04:55 sena_kun joined 05:55 sourceable6 left, coverable6 left, nativecallable6 left, quotable6 left, squashable6 left, notable6 left, bloatable6 left, committable6 left, releasable6 left, reportable6 left, benchable6 left, shareable6 left, greppable6 left, statisfiable6 left, unicodable6 left 05:56 bisectable6 left, nativecallable6 joined, squashable6 joined, sourceable6 joined 05:57 greppable6 joined, bisectable6 joined, notable6 joined, benchable6 joined, reportable6 joined, shareable6 joined, bloatable6 joined, statisfiable6 joined 05:58 coverable6 joined, releasable6 joined, committable6 joined 05:59 quotable6 joined, unicodable6 joined 06:30 jeffythedragonsl joined
jeffythedragonsl hello! 06:30
nwc10 Hello 06:31
06:41 sena_kun left
jeffythedragonsl can someone recommend an easy open issue? 06:51
nwc10 sorry I can't, as I've not been actively working on MoarVM. Hopefully someone else can, although I suspect most folks are asleep currently. 06:53
jeffythedragonsl haha true 06:54
06:57 sena_kun joined 07:21 jeffythedragonsl left 08:42 sena_kun left 08:56 sena_kun joined 10:41 sena_kun left 10:57 sena_kun joined 12:15 camelia left 12:42 sena_kun left 12:48 camelia joined 12:57 sena_kun joined
lizmat nine: would a Moar bump be ok ? 13:14
nine sure 13:15
lizmat oki 13:18
13:29 lucasb joined 14:13 brrt joined
brrt \o 14:14
nwc10 o/
brrt happy new year #moarvm 14:16
14:42 sena_kun left 14:56 sena_kun joined 15:01 brrt left
jnthn Happy New Year :) 16:35
16:43 sena_kun left 16:57 sena_kun joined 17:00 brrt joined 17:52 Altai-man_ joined, sena_kun left 18:09 brrt left 18:11 domidumont joined 18:16 patrickb joined
nine jnthn: what optimizer talk did you mean with this comment? 18:21
18:39 domidumont1 joined 18:40 domidumont left
nine The Supply stuff is a really confusing maze of exceptions and handlers 18:52
What's making this harder is that I have no idea when getting or returning an actual NULL in a register is OK and when it is not
Well I guess the answer is "rarely" 19:10
19:38 timo joined, timo is now known as timotimo 19:52 sena_kun joined 19:53 Altai-man_ left 20:04 domidumont1 left 20:45 patrickz joined 20:46 patrickb left 21:17 MasterDuke joined
nine OMG the solution is so simple! 21:19
The JITed version of takehandlerresult simply doesn't match the interpreted one wrt NULL handling 21:20 not that surprising. The code matches 100 % the version introduced in the commit "WIP on Handler support." 21:21
MasterDuke nine++ is on a roll recently
moritz don't we have some kind JIT validation mode that runs both versions, and throws an exception when they disagree? 21:38
nine moritz: that would be seriously hard to implement 21:39
moritz :-( 21:40
Geth MoarVM: e35bd5f0ea | (Stefan Seifert)++ | src/jit/x64/emit.dasc
Fix segfaults caused by JITed takehandlerresult returning NULL

The interpreter implementation of takehandlerresult returns VMNull if last_handler_result is NULL. The JITed version didn't and instead put the NULL into the result register, which caused segfaults later on. Fix by having the JITed implementation match the interpreter's.
nine The sad part is that despite being able to fix this, I do not have the slightest idea how to write a test for this issue 21:47
I'm really surprised, this didn't show up much more often 21:48
21:51 Altai-man_ joined 21:53 sena_kun left 22:23 MasterDuke left
japhb nine: I can remember a lot of bugs over the years that have been of the "I can't believe this didn't explode *all the time*" variety. 22:39
It's kindof amazing how "mostly working" does in fact mostly work. 22:40
nine japhb: yeah, I've fixed a few of those my self. Still amazes me every time 22:43
22:57 lucasb left
jnthn nine: I think probably it's because handlers in nqp::handle imply a block being generated, and lexical to local lowering fails to grok that and so thinks it can lower away...probably one or both of $state and &code 23:48
23:52 sena_kun joined 23:54 Altai-man_ left