github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm
Set by AlexDaniel on 12 June 2018.
02:46 Geth_ joined, Geth left 04:19 discord6 joined, discord6 left, discord6 joined 04:21 discord6 left 04:22 discord6 joined, discord6 left, discord6 joined 07:30 brrt joined
nwc10 good *, #moarvm 07:55
07:58 sena_kun joined 08:00 AlexDaniel joined, AlexDaniel left, AlexDaniel joined 08:01 zakharyas joined 08:06 Altai-man_ joined 08:08 sena_kun left 08:23 brrt left 08:27 Geth joined 08:28 Geth_ left 08:34 zakharyas left 08:35 AlexDaniel left 08:36 angelds joined 08:37 zakharyas joined 08:50 angelds left 09:17 zakharyas left 09:18 zakharyas joined 09:36 zakharyas left 09:38 zakharyas joined 09:41 brrt joined
brrt good * 09:42
hope everyone is still healthy :-) 09:48
jnthn o/ brrt 09:51
Doing OK. You? :)
nwc10 \o 09:52
lizmat \o
brrt doing well as well 09:53
10:07 sena_kun joined 10:09 Altai-man_ left 10:18 AlexDaniel joined, AlexDaniel left, AlexDaniel joined 10:21 MasterDuke left 10:27 brrt left 11:22 zakharyas1 joined 11:23 MasterDuke joined 11:24 zakharyas left 12:06 Altai-man_ joined 12:08 sena_kun left 12:31 zakharyas joined 12:34 zakharyas1 left 12:57 Kaeipi is now known as Kaiepi 13:32 zakharyas1 joined 13:34 zakharyas left 13:54 vrurg_ joined 13:57 vrurg left 13:58 vrurg joined 14:01 vrurg_ left 14:07 sena_kun joined 14:08 Altai-man_ left 14:27 lucasb joined 14:48 brrt joined 14:52 zakharyas joined 14:53 zakharyas1 left 15:32 Kaiepi left 15:34 Kaiepi joined 15:54 brrt left 16:06 Altai-man_ joined 16:09 sena_kun left
Geth MoarVM: 6baf0de4af | (Jonathan Worthington)++ | 3 files
Add a value_desc_cont container descriptor

This is a mild generalization of the Rakudo Scalar container descriptor that removes the reliance on precise P6opaque layout. It was planned to move this into MoarVM after the last round of Scalar refactors, however that was never actually done. Doing it now because it will make it much easier to use the offsets to have argument guards to decont/rw-check without having to do a function pointer call.
16:21
16:22 Kaiepi left 16:30 Kaiepi joined
Geth MoarVM: 1bd5f19e05 | (Jonathan Worthington)++ | src/6model/containers.c
Fix copy-pasta

Which breaks surprisingly little.
16:30
16:39 travis-ci joined
travis-ci MoarVM build failed. Jonathan Worthington 'Add a value_desc_cont container descriptor 16:39
travis-ci.org/MoarVM/MoarVM/builds/669776383 github.com/MoarVM/MoarVM/compare/1...af0de4aff1
16:39 travis-ci left 16:43 zakharyas1 joined
jnthn ah, just a race on NQP version 16:43
16:45 zakharyas left
Geth MoarVM: 035eae1933 | (Stefan Seifert)++ | src/core/compunit.c
Fix interned callsites getting leaked when fixing up inlines

Interned callsites are no longer owned by the comp unit but by the instance. This means that we also do not free them when the comp unit gets garbage collected. It also means that it should be safe to reuse the existing pointer when adding an interned callsite to a comp unit (e.g. when inlining across comp unit boundaries).
16:46
MoarVM: c7e75be60a | (Jonathan Worthington)++ (committed using GitHub Web editor) | src/core/compunit.c
Merge pull request #1263 from niner/master

Fix interned callsites getting leaked when fixing up inlines
nine But it may be easier to fix now. Unless the fix is actually just freeing the old st->container_data (if there is one) in github.com/MoarVM/MoarVM/commit/6b...73e6ddR387 17:21
jnthn home time o/ 17:27
17:28 zakharyas1 left 18:07 sena_kun joined 18:09 Altai-man_ left
MasterDuke nine: adding `if (st->container_data) MVM_free(st->container_data);` gets `valgrind --leak-check=full raku --full-cleanup -e ''` to report `(definitely|indirectly|possibly) lost: 0 bytes in 0 blocks` 18:19
does say `still reachable: 1,677 bytes in 5 blocks` though
but those are all dlopen related 18:20
nine I know. I've been running with this patch for a week now 18:27
But I don't know if that's the right thing to do
MasterDuke PR and see if jnthn, timotimo, etc have any thoughts? 18:28
nine Yeah, that's the proper way to do this :) 18:29
18:55 brrt joined
nwc10 \o 18:55
[Coke] o/ 19:03
19:15 zakharyas joined
brrt \o 19:28
20:00 zakharyas left, MasterDuke left 20:06 Altai-man_ joined 20:07 MasterDuke joined 20:09 sena_kun left 20:22 brrt left 21:19 MasterDuke left 21:31 MasterDuke joined 22:07 sena_kun joined 22:08 Altai-man_ left 22:15 squashable6 left 22:16 squashable6 joined 23:16 sena_kun left