| IRC logs at
Set by AlexDaniel on 12 June 2018.
00:53 kawaii left 00:56 kawaii joined 06:14 Kaiepi left 06:20 Kaiepi joined 08:37 domidumont joined
nine nwc10: FWIW we already use pragmas to disable some warnings in dependencies' header files. 08:44
nwc10 that's a pragma within the source of the header file that would otherwise warn? 08:45
nine 08:47
nwc10 yes, the fun thing is "our" warnings flags on header files we don't "control". I don't think that pragamata help us there 08:48
nine But that's exactly where this pragma helps? We compile everything with -Wimplicit-fallthrough but not that dynasm header file, because it's not our's 08:50
nwc10 oh, ah, right I see. yes. I'm confused here. 08:51
actually, that approach still wouldn't work for the error I hit, as it was one of the bundled projects in 3rdparty, so we don't control any of its source code, including the #include lines 08:59
need to go afk.
there's a longer story about why I don't think that this is generally a "winning move"
nine oh, yeah, that case sucks
09:39 sena_kun joined 10:53 squashable6 left 10:54 squashable6 joined 11:42 sxmx left 12:08 Altai-man joined 12:11 sena_kun left 14:12 domidumont left 14:31 domidumont joined 16:09 sena_kun joined 16:10 Altai-man left 18:00 domidumont left 18:01 domidumont joined 19:15 domidumont left 19:40 sxmx joined 20:05 sxmx left 20:08 sxmx joined 20:11 sena_kun left
Geth MoarVM: MasterDuke17++ created pull request #1376:
Report the lines that caused coverage
20:34 squashable6 left 20:37 squashable6 joined 21:25 Kaiepi left 21:56 Kaiepi joined 22:29 vrurg left 22:30 vrurg joined 22:51 squashable6 left 22:53 squashable6 joined