|
github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
|
04:06
linkable6 left,
notable6 left,
evalable6 left,
greppable6 left,
sourceable6 left,
unicodable6 left,
nativecallable6 left,
benchable6 left,
bloatable6 left,
shareable6 left,
quotable6 left,
bisectable6 left,
statisfiable6 left,
committable6 left,
coverable6 left,
squashable6 left,
releasable6 left,
tellable6 left,
greppable6 joined,
nativecallable6 joined,
tellable6 joined,
committable6 joined,
releasable6 joined
04:07
quotable6 joined,
unicodable6 joined,
linkable6 joined,
bisectable6 joined
04:08
bloatable6 joined,
coverable6 joined,
shareable6 joined,
squashable6 joined,
benchable6 joined
04:09
notable6 joined,
sourceable6 joined,
statisfiable6 joined,
evalable6 joined
05:25
linkable6 left,
linkable6 joined
06:53
quotable6 left,
nativecallable6 left,
benchable6 left,
linkable6 left,
unicodable6 left,
squashable6 left,
evalable6 left,
committable6 left,
sourceable6 left,
greppable6 left,
coverable6 left,
notable6 left,
bisectable6 left,
bloatable6 left,
bisectable6 joined
06:54
committable6 joined,
greppable6 joined,
linkable6 joined,
nativecallable6 joined,
quotable6 joined,
bloatable6 joined
06:55
benchable6 joined,
notable6 joined,
unicodable6 joined,
evalable6 joined,
sourceable6 joined
06:56
coverable6 joined,
squashable6 joined
|
|||
| nwc10 | good *, #moarvm | 08:39 | |
|
09:02
evalable6 left,
linkable6 left,
evalable6 joined
09:03
linkable6 joined
09:13
domidumont joined
09:32
sena_kun joined
10:19
Altai-man joined
10:21
sena_kun left
|
|||
| nine | Good Sunday! | 10:28 | |
| lizmat | Good * :-) | 12:05 | |
| www.cs.purdue.edu/homes/rompf/pmca...index.html appeared on my Twitter timeline, haven't read it, thought it might be interesting for folks here | |||
| "Post-Modern Compiler Design" | 12:06 | ||
| Geth | MoarVM/asan_fixes: 26 commits pushed by (Stefan Seifert)++ review: github.com/MoarVM/MoarVM/compare/0...03c476e13f |
12:22 | |
| MoarVM: niner++ created pull request #1419: Fix a bunch of memory leaks |
12:31 | ||
| nine | The "Cleanup the build system probes" PR was much easier to review than I feared :) Maybe not everything involving build systems is horrible... | 12:58 | |
| I just went through the first page of (25) MoarVM PR's and reviewed all that weren't done by me, were still WIP or were waiting for requested changes. | 13:41 | ||
| Actually took just a bit more than an hour. And it reinforced the necessity of investing some quality time into NativeCall | 13:42 | ||
| I hope, this has earned me some reviews for my own PRs *hint hint* ;) | 13:43 | ||
| Geth | MoarVM/master: 18 commits pushed by (Elizabeth Mattijsen)++, (Jonathan Worthington)++ review: github.com/MoarVM/MoarVM/compare/1...065af4e44e |
13:45 | |
|
13:47
brrt joined
14:20
sena_kun joined
14:21
Altai-man left
14:45
lucasb joined
15:08
MasterDuke left
16:33
brrt left
17:01
MasterDuke joined
18:19
Altai-man joined
18:21
sena_kun left
18:48
domidumont left
20:21
MasterDuke left
20:34
brrt joined
20:43
sxmx left
20:44
sxmx joined
21:00
MasterDuke joined
|
|||
| Geth | MoarVM/asan_fixes: 26 commits pushed by (Stefan Seifert)++ review: github.com/MoarVM/MoarVM/compare/7...6311d4af51 |
21:17 | |
| MasterDuke | nine: do you see my comment on the strncpy commit? github is showing it as pending for me | 21:25 | |
|
21:33
brrt left
|
|||
| Geth | MoarVM/master: 4 commits pushed by (Stefan Seifert)++, niner++ | 21:41 | |
| nine | MasterDuke: no, I don't? | 21:42 | |
| MasterDuke: thanks for the reviews :) | |||
| MasterDuke | hm. i'll just copy it into a new comment then | ||
| i deleted and re-commented, looks like it's there now | 21:44 | ||
| nine | That's a lot of pragma for very little code... | ||
| MasterDuke | true. but personally i don't like warnings. and so many are required to get it silenced in both gcc and clang | 21:46 | |
| i mean i wouldn't disapprove the pr over it | 21:47 | ||
| Geth | MoarVM/asan_fixes: 26 commits pushed by (Stefan Seifert)++ review: github.com/MoarVM/MoarVM/compare/8...c7962c741f |
21:48 | |
| nine | Nah, I added it to the commit along with a comment explaining what it's all about | ||
| Compiler warnings are too useful to get swamped in false positives as the one about freeing the wrong thing shows | 21:49 | ||
| MasterDuke | nine++ | ||
|
21:50
Altai-man left
|
|||
| MasterDuke | nine: two minor comments. for whatever it's worth, i'm happy to approve it as is | 22:04 | |
| nine | The MVM_free_null(si->prog); is just consistent with the rest of the function where MVM_free_null calls were added by Daniel Green | 22:07 | |
| MasterDuke sidles away looking guilty | |||
| nine | In your defense, there were NULL assignments in the code before that. You just changed them when introducing MVM_free_null :) | 22:08 | |
| MasterDuke | ha! | ||
| nine | I'll leave them for now. They will at least make a hypothetical use-after-free more obvious | 22:09 | |
| MasterDuke | sure | 22:11 | |
| afk for a bit | |||
| nine | afk for the night | ||
| dogbert17 | two nqp tests are failing (t/nqp/111-spawnprocasync.t, t/nqp/113-run-command.t) and one is hanging (t/nqp/114-pod-panic.t) | 22:17 | |
|
23:55
Kaiepi left,
Kaiepi joined
|
|||