Welcome to the main channel on the development of MoarVM, a virtual machine for NQP and Rakudo (moarvm.org). This channel is being logged for historical purposes.
Set by lizmat on 24 May 2021.
00:01 [Coke] joined 00:06 reportable6 left 00:07 reportable6 joined 02:05 evalable6 left, linkable6 left 02:23 CaCode joined 02:45 CaCode_ joined 02:47 CaCode- joined, CaCode left 02:49 CaCode_ left 03:06 evalable6 joined 04:06 greppable6 left, reportable6 left, sourceable6 left, coverable6 left, evalable6 left, bisectable6 left, unicodable6 left, bloatable6 left, shareable6 left, tellable6 left, nativecallable6 left, committable6 left, notable6 left, quotable6 left, releasable6 left, statisfiable6 left, benchable6 left, squashable6 left 04:07 greppable6 joined, statisfiable6 joined, coverable6 joined, shareable6 joined 04:08 committable6 joined, bisectable6 joined 04:09 benchable6 joined, squashable6 joined, reportable6 joined, unicodable6 joined 04:17 CaCode- left 05:07 notable6 joined, linkable6 joined, tellable6 joined 05:08 quotable6 joined, bloatable6 joined 05:09 sourceable6 joined 06:04 frost joined 06:07 reportable6 left 07:06 nativecallable6 joined 07:07 releasable6 joined 07:10 reportable6 joined
Nicholas good *, * 07:42
08:09 evalable6 joined 08:46 TheAthlete joined
nine Beautiful *, #moarvm 10:04
11:01 evalable6 left, linkable6 left 12:01 evalable6 joined 12:08 reportable6 left 12:09 reportable6 joined 12:42 Altai-man joined 13:03 linkable6 joined 14:10 TempIRCLogger left, TempIRCLogger joined 15:10 shareable6 left, squashable6 left, nativecallable6 left, greppable6 left, bisectable6 left, bloatable6 left, benchable6 left, linkable6 left, evalable6 left, statisfiable6 left, coverable6 left, unicodable6 left, reportable6 left, notable6 left, sourceable6 left, releasable6 left, quotable6 left, tellable6 left, committable6 left 15:11 frost left, bisectable6 joined, evalable6 joined, unicodable6 joined 15:12 benchable6 joined, linkable6 joined, committable6 joined 15:13 tellable6 joined
nine I've finally managed to confirm my hypothesis that the crashes in the GC that I can reproduce with LibXML's t/90threads.t are caused by native call sites getting cloned while a different thread is still in the process of initializing them 16:00
jdv sounds scary 16:02
nine The copy_to call itself is triggered by a getattr_o op
Ironically the getattr_o access is to check whether the callsite is setup yet or not 16:09
16:11 quotable6 joined, coverable6 joined 16:12 statisfiable6 joined, squashable6 joined, reportable6 joined 16:13 notable6 joined, releasable6 joined, sourceable6 joined 17:08 TheAthlete left 17:12 shareable6 joined 17:14 bloatable6 joined
Geth MoarVM: 207db4bb5b | (Stefan Seifert)++ | 2 files
Fix segfaults due to race condition when initializing native call sites

Ensure that a native callsite's arg_types and arg_info arrays are fully populated before the body's pointers to them are assigned. Otherwise another thread may copy uninitialized data as part of a copy_to operation (probably triggered by getattr_o).
nine Over an hour of having 27 loops run 90threads.t and not a single failure :) 17:42
Sadly that has to be with MVM_JIT_EXPR_DISABLE=1 du to the known racy code the expr jit creates. 17:43
But at least we can be reasonably sure that no other bug affects this test (and thus LibXML) anymore :)
[Coke] nine++ 17:44
me: Maybe I can hack on stuff during my break! also me: Hey, let's my booster shot right before break!
lizmat jdv nine time for a MoarVM bump ? 17:45
Geth MoarVM: 768228b327 | (Stefan Seifert)++ | 2 files
Fix return register staying uninitialized on dispatch to void native functions

This got lost when turning nativecall_invoke into nativecall_dispatch. Even if the native function itself doesn't return a result (i.e. void), we have to set the call's result to something as in general the call will be initiated through dispatch_o which is expected to return an object. NativeCall convention is to return a type object in this case. So follow the convention
MoarVM: fd6a41035e | (Stefan Seifert)++ | src/spesh/disp.c
Fix uninitialized return register on translated calls to void native functions

We optimize calls to native functions without return values (i.e. void) to sp_runnativecall_v. Nevertheless we have to initialize the original target register with something (i.e. the return value type object), because the register may be read after a deopt. This is all the more likely as a guard on the return register would trigger a deopt if the register contains a NULL value.
Fixes segfaults after deopts after void native calls.
MoarVM: 69c9452953 | niner++ (committed using GitHub Web editor) | 3 files
Merge pull request #1622 from MoarVM/fix_segfault_with_void_native_calls

Fix segfault with void native calls
MoarVM: f0e4b08c09 | (Stefan Seifert)++ | src/core/args.c
Fix possible access to fromspace when autoboxing return values

If the target frame (e.g. tc->cur_frame) is a heap frame that lives in the nursery, the return value is a native value (e.g. return_i or a native call), the caller expects an object and boxing happens to trigger a GC run, the target frame could be moved before we dereference the target pointer to get the return_value register. This would lead to a segfault with GC_DEBUG 3. ... (5 more lines)
MoarVM: 2914410fa7 | niner++ (committed using GitHub Web editor) | src/core/args.c
Merge pull request #1624 from MoarVM/fix_autoboxing_gc_issue

Fix possible access to fromspace when autoboxing return values
nine lizmat: now's probably a better time :)
lizmat I see :-)
jdv are you ok with that? 17:48
nine I figured better to get these merged and exercised rather than wait longer for a review. The review can still be done post-facto
lizmat nine: or do you think these should be in a release anyway ?
nine They absolutely need to be in the next release 17:52
lizmat ok, I will bump now 17:54
jdv fun stuff 18:00
18:09 reportable6 left 18:10 reportable6 joined
lizmat nine: github.com/rakudo/rakudo/pull/4676 ?? 18:23
18:26 linkable6 left
jdv nice catch. i was about to ask about that one. 18:27
lizmat afk for dinner& 18:31
18:45 Altai-man left 19:26 linkable6 joined 19:30 japhb joined
MasterDuke nine: nice fixes. did that dyncall fix also end up making it into ffi? 19:58
20:11 nativecallable6 joined
dogbert17 nine++, does this mean that MoarVM is now officially bug free :) 20:29
22:13 greppable6 joined 22:44 japhb left