Welcome to the main channel on the development of MoarVM, a virtual machine for NQP and Rakudo (moarvm.org). This channel is being logged for historical purposes.
Set by lizmat on 24 May 2021.
Nicholas good *, #moarvm 09:57
MasterDuke Nicholas: were you looking to make coerce_si faster, or just checking for correctness. github.com/j-jorge/atoi-benchmark might have some faster implementations, but i think some of them are even more simplified, and i don't know how much of the speedup we'd lose adding back in the dropped functionality 10:33
Nicholas have two working commits to get rid of ctype.h 10:35
MasterDuke also, i wonder if that `if (str->body.storage_type == MVM_STRING_GRAPHEME_ASCII)` could be `|| str->body.storage_type == MVM_STRING_GRAPHEME8`
nice
Nicholas but realised that there seemed to be bugs in the end of string handling
I now have written some tests
yet to try them on the JVM NQP 10:36
java.lang.NumberFormatException: For input string: " " 10:37
which was probably a tab
OK, "interesting" 10:39
So previously with the strtoll implementation we *weren't* exposed to locale issues because:
Error encoding ASCII string: could not encode codepoint 128
MasterDuke "The characters in the string must all be decimal digits, except that the first character may be an ASCII minus sign '-' (\u002D') to indicate a negative value or an ASCII plus sign '+' ('\u002B') to indicate a positive value. " so the jvm implementation never matched moarvm 10:40
Nicholas thanks for that definition - that's useful to know. 10:41
Geth MoarVM: nwc10++ created pull request #1657:
Inline ascii ctype
13:47