Welcome to the main channel on the development of MoarVM, a virtual machine for NQP and Rakudo (moarvm.org). This channel is being logged for historical purposes.
Set by lizmat on 24 May 2021.
00:00 reportable6 left 00:03 reportable6 joined 01:18 sena_kun left 01:27 sena_kun joined 03:04 evalable6 left 03:06 evalable6 joined
Geth MoarVM: MasterDuke17++ created pull request #1745:
Convert all dir functions to just use libuv...
06:00 reportable6 left 06:03 reportable6 joined 10:39 sena_kun left 12:00 reportable6 left 12:01 reportable6 joined
[Coke] oooh, nifty 13:23
if we have a moarvm patch that requires a rakudo patch... does the rakudo patch have to include the nqp/moarvm bumps, or is that a separate task done by the merger? 15:27
lizmat well, there could be associated PRs in nqp and rakudo 15:28
[Coke] yes, and should those PRs have the bump or no? 15:34
Or just the code change? 15:35
(since at the time the PR is submitted, they don't have the ref id of the change in the lower part of the stack)
lizmat having the bump in there could complicate things
[Coke] ... I think I just answered my own question
(going to submit the rakudo change on masterduke's moarvm change, once I've tested it with the typo fix)
lizmat :q 15:37
[Coke] sadly that PR doesn't work here. 15:45
ugexe fwiw how i'd test that PR is: rakubrew the latest rakudo, cd to ~/.rakubrew/versions/moar-2023.13/nqp/MoarVM, apply the PR, run make install, cd to ~/.rakubrew/versions/moar-2023.13, and run make install. I dunno if thats useful 15:48
rakubrew the latest rakudo, cd to ~/.rakubrew/versions/moar-2023.13/nqp/MoarVM, apply the PR, run make install, cd to ~/.rakubrew/versions/moar-2023.13, make the changes to rakudo, and run make install 15:49
[Coke] added github.com/rakudo/rakudo/pull/5215 but mainly just as a placeholder for now. will double check testing once the MoarVM issues are resolved. 15:57
ugexe oh i misunderstood, i thought that PR already exists. nevermind me 16:08
16:12 gighu joined 16:58 gighu left 18:00 reportable6 left 18:03 reportable6 joined 18:07 sena_kun joined 18:34 Altai-man joined 18:38 sena_kun left
nine I do usually include the bump (I just update it before merging) and I think that's the better way because it makes it very clear that the patch needs an associated change in the VM. It also increases bisectability. 18:53
20:29 vrurg left 20:30 vrurg joined 22:05 squashable6 left 22:08 squashable6 joined 22:24 Altai-man left