|
github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
| MasterDuke | is it the enum or the tc->cur_frame->static_info that's most wrong | 00:02 | |
| timotimo | i think using the cur_frame at the point where profiling is turned on is wrong | 00:06 | |
| MasterDuke | thread_entry_frame? | 00:10 | |
| nope, that causes a segv | 00:14 | ||
| timotimo | sorry, brain is too mush to think | ||
| MasterDuke | no worries. but let me know if inspiration strikes in the night | 00:15 | |
|
00:27
lucasb left
01:18
synopsebot joined
05:17
eater left
05:18
eater joined
05:20
Geth_ left
05:51
bartolin joined,
bartolin_ left
06:19
lizmat left
06:28
discord6 left,
discord64 joined
06:29
discord64 is now known as discord6
06:54
domidumont joined
|
|||
| nine | timotimo: now ;) | 07:23 | |
|
07:37
lizmat joined
08:17
lizmat_ joined
08:20
lizmat left
08:23
lizmat joined
08:24
lizmat_ left
08:25
Garland_g[m] left,
AlexDaniel` left
08:39
AlexDaniel` joined
08:49
sena_kun joined
08:55
lizmat left
08:59
lizmat joined
|
|||
| timotimo | now what? | 09:07 | |
|
09:16
Garland_g[m] joined
09:34
lizmat left
09:37
lizmat joined
09:46
nebuchadnezzar left
09:59
Kaiepi left
10:00
Kaiepi joined
|
|||
| MasterDuke | nine: did you see my question in github.com/MoarVM/MoarVM/pull/935 ? | 10:40 | |
| timotimo | i somehow totally forgot about the existence of strdup | 10:54 | |
|
11:01
lizmat left
|
|||
| MasterDuke | heh | 11:05 | |
| timotimo | so yeah, that's probably the right fix | 11:06 | |
| MasterDuke | k, i'll update the PR | 11:11 | |
|
11:21
lizmat joined
|
|||
| timotimo | i wonder if we want to limit it to some upper bound and use strndup | 11:25 | |
| MasterDuke | timotimo: why do all the other MVM_telemetry_interval_* functions just do `record->u.annotation.description = description;`? i.e., directly assign the passed in string | ||
|
11:29
sena_kun left,
sena_kun joined
|
|||
| timotimo | because those are required to have constant strings | 11:31 | |
| i.e. these pointers would point into the read-only section of the libmoar.so | 11:32 | ||
| pretty much a requirement for good performance, i think | |||
| MasterDuke | oh, i see this one is named *_dynamic, didn't even look at the name before | ||
| timotimo: any particular suggestion for a limit? | 11:39 | ||
| timotimo | 1024 is probably a very conservative limit | 11:41 | |
| MasterDuke | timotimo: PR updated | 11:49 | |
|
11:51
Geth joined
|
|||
| lizmat | tyil++ | 11:51 | |
|
12:11
Altai-man_ joined
12:15
sena_kun left
|
|||
| MasterDuke | timotimo: any reason not to merge? | 12:18 | |
| timotimo | don't think so, go ahead if you want | 12:19 | |
| MasterDuke | good, will do | ||
| oh right, Geth isn't working here | 12:21 | ||
| no warnings for me using gcc 8.3.0 now | 12:25 | ||
| timotimo | jnthn, can you set up geth.svc.tyil.net/ on github.com/moarvm/moarvm/settings/hooks/ | ||
| MasterDuke | still a bunch with clang. mostly `warning: '&&' within '||' [-Wlogical-op-parentheses]` | 12:26 | |
| timotimo | probably no harm in cleaning that up | ||
| MasterDuke | timotimo: also a bunch of `src/debug/debugserver.c:431:1: warning: control may reach end of non-void function [-Wreturn-type] }` | 12:32 | |
|
12:34
squashable6 left
|
|||
| MasterDuke | src/core/interp.c:99:1: warning: control may reach end of non-void function [-Wreturn-type] | 12:35 | |
|
12:38
travis-ci joined
|
|||
| travis-ci | MoarVM build passed. MasterDuke17 'Use strndup instead of malloc+strncpy (#935) | 12:38 | |
| travis-ci.org/MoarVM/MoarVM/builds/531112635 github.com/MoarVM/MoarVM/compare/f...7b92f929ce | |||
|
12:38
travis-ci left,
squashable6 joined
12:40
lucasb joined
|
|||
| Geth | MoarVM: 807b92f929 | MasterDuke17++ (committed using GitHub Web editor) | src/profiler/telemeh.c Use strndup instead of malloc+strncpy (#935) This is simpler and also silences an incorrect GCC warning. |
12:56 | |
| jnthn | timotimo: Done; redelivered ^ to test it :) | ||
| timotimo | \o/ | 12:57 | |
| thank you | |||
| MasterDuke | nice | 13:03 | |
|
13:46
lizmat_ joined
13:48
lizmat left
13:50
Altai-man_ is now known as sena_kun
13:51
lizmat_ is now known as lizmat
14:13
Altai-man_ joined
14:16
sena_kun left
14:52
lizmat left
14:58
dogbert17 joined
15:02
lizmat joined
15:18
lizmat left
16:05
zakharyas joined
16:43
zakharyas left
17:37
lucasb left
18:30
domidumont left
|
|||
| Geth | MoarVM: MasterDuke17++ created pull request #1100: Silence -Wlogical-op-parentheses warnings in clang |
19:33 | |
|
20:37
lizmat joined
20:38
Kaiepi left
22:56
Kaiepi joined
|
|||