github.com/moarvm/moarvm | IRC logs at colabti.org/irclogger/irclogger_logs/moarvm Set by AlexDaniel on 12 June 2018. |
|||
00:03
synopsebot___ joined
00:04
Geth_ joined
01:13
synopsebot___ left,
Geth_ left
01:23
Geth__ joined,
synopsebot_ joined
01:27
synopsebot left
01:28
Geth left
01:36
sena_kun left
01:40
synopsebot joined,
Geth joined
01:58
synopsebot left,
Geth left
02:00
Geth__ left,
synopsebot_ left
02:01
Geth joined
02:02
discord6 joined,
synopsebot joined
02:07
Geth left
02:08
Geth joined
05:59
squashable6 left
06:04
squashable6 joined
08:31
sena_kun joined
08:38
patrickb joined
09:27
patrickb left
09:37
squashable6 left
09:39
squashable6 joined
09:42
squashable6 left
09:46
squashable6 joined
10:41
harrow left
10:52
harrow joined
11:16
MasterDuke left
11:24
pamplemousse joined
11:29
ggoebel left
11:31
pamplemousse left
11:44
MasterDuke joined,
MasterDuke left,
MasterDuke joined
|
|||
MasterDuke | timotimo: how come some functions don't get linkified by your script even though the corresponding filename is? | 11:53 | |
timotimo | give me an example and i'll see that i wiggle the regex around | 11:57 | |
MasterDuke | the bottom comment on github.com/MoarVM/MoarVM/issues/1105 | 12:02 | |
#1 in the backtrace, check_reg | 12:03 | ||
oh, and that one has some files that aren't linkified | 12:04 | ||
timotimo | i've got a little whitelist of things that are valid moar-related "first argument in argument list" things, like tc, instance, ... | 12:09 | |
"idx" is not among them | |||
and neither is "data" | |||
not entirely sure if the whitelist is a sensible approach | 12:10 | ||
oh, i think my script is actually killing syntax highlighting in gists | 12:17 | ||
updated the gist: gist.githubusercontent.com/timo/7c...Linkify.js | 12:19 | ||
fixes gist syntax highlighting as well | 12:21 | ||
12:46
Altai-man_ joined
12:49
sena_kun left
|
|||
MasterDuke | cool, catches more stuff. it does now sometimes highlight the whole line though | 12:59 | |
14:19
Altai-man_ left
|
|||
timotimo | examples, please? | 14:19 | |
MasterDuke | #1 and #4 in the bottom comment of github.com/MoarVM/MoarVM/issues/1105 | 14:49 | |
timotimo | interesting. but but it does linkify the entire thing from start to end | 15:21 | |
so that's okay to me | |||
16:25
Geth left
16:26
Geth joined
|
|||
MasterDuke | yeah, works fine, just cosmetic nitpicking | 17:45 | |
timotimo | OK | 17:49 | |
17:50
squashable6 left
|
|||
MasterDuke | oooooo, can you do the same thing for rakudo backtraces? | 17:52 | |
timotimo | it's already in | 17:54 | |
do you have one where it doesn't happen? | |||
17:54
squashable6 joined
17:56
squashable6 left
17:57
zakharyas joined
18:01
squashable6 joined
21:10
zakharyas left
22:51
sena_kun joined
|
|||
MasterDuke | timotimo: oh, is it supposed to already? | 22:52 | |
timotimo | yes | 22:53 | |
MasterDuke | nice. but github.com/rakudo/rakudo/issues/2921 has a backtrace with at least one line that could be highlighted | 22:55 | |
github.com/rakudo/rakudo/issues/2738 has some too | 22:58 | ||
oh! | 22:59 | ||
now it's working! | |||
wait, this is the link it's creating github.com/MoarVM/MoarVM/blob/mast....nqp#L2861 so not quite right... | 23:00 | ||
timotimo | it makes some NaN links, eh? | ||
an earlier version of the script should work better | 23:01 | ||
i changed the regex a lot to add support for valgrind output | |||
MasterDuke | some NaN links, but see it's also trying to link to rakudo files in the moarvm repo | ||
timotimo | that explains it then | ||
it's getting the wrong branch | |||
MasterDuke | afk for dinner, but timotimo++ | 23:02 |