|
02:30
nine left
02:35
nine joined
16:46
Geth joined
|
|||
| Geth | MoarVM/moar-gdb-rrdb: 47 commits pushed by (Timo Paulssen)++ review: github.com/MoarVM/MoarVM/compare/b...8945aa4a99 |
16:49 | |
| MoarVM/moar-gdb-rrdb: 0caad5522f | (Timo Paulssen)++ | tools/libmoar.so-gdb.py gdb plugin: remove leftover commented debug statements |
|||
| MoarVM: timo++ created pull request #2025: general GDB plugin improvements + prototype of `moar rrdb` command |
16:57 | ||
| MoarVM/moar-gdb-rrdb: 882974ad91 | (Timo Paulssen)++ | docs/ChangeLog Changelog entry for gdb plugin work |
16:59 | ||
| MoarVM/main: 49 commits pushed by (Timo Paulssen)++ review: github.com/MoarVM/MoarVM/compare/a...2974ad912c |
17:00 | ||
| timo | merry christmas i guess? :) | ||
| [Coke] | ... I'm kind of concerned that we just got 50 commits to main days before the release | 17:09 | |
| how many point releases have I had to do this year so far? | 17:10 | ||
| timo | i addressed this concern in the pull request | ||
| > Since the gdb plugin is fully optional, and problems with it are unlikely to actually cause issues, and the only other change in this PR is in a debug helper function you would have to call by hand, I have decided that merging this without a full review just before the release is not an issue. | |||
| [Coke] | did you assign me to the PR so I could review it before you applied it? | ||
| timo | i promise you the PR is harmless :) | 17:11 | |
| [Coke] | Why does no one *talk to the release manager* about these things? | ||
| lizmat | [Coke]: good point | ||
| shall I bump NQP / Rakudo to get some CI going? or are you thinking of skipping these commits for the release ? | 17:12 | ||
| [Coke] | I need more time to consider. | ||
| timo | irclogs.raku.org/moarvm/2026-07-01...22:49-0009 | 17:13 | |
| [Coke] | Don't bother bumping them yet in case I decide against. | ||
| lizmat | yup, understood | ||
| timo | to be fair, that was not so close to the release | 17:14 | |
| [Coke] | and did you get an answer? | ||
| timo | next day i got a "timo++" from lizmat and a "go ahead!" from patrick | 17:15 | |
| lizmat | timo: the point is that the release manager is supposed to to a blin run.... and your merge basically made the last blin runs meaningless :-( | ||
| timo | it does, even though the changes are nonfunctional? | 17:16 | |
| lizmat | so, my ++ was for then... now I would have said, "++ but wait until after the release" | ||
| [Coke] | there are changes to the src folder. | ||
| lizmat | thing is, I also have been guilty of pushing things I thought were harmless just before a release... only to find out they weren't | 17:17 | |
| [Coke] | not just the plugin | ||
| timo | indeed, that's the debug helper function i've mentioned in the comment | ||
| that code is unreachable except when you connect a debugger and call it by hand | |||
| [Coke] | ok. | 17:18 | |
| timo | sorry for giving you a heart attack there | ||
| [Coke] | Color me "incredibly frustrated" and we'll see if any issues on release day | ||
| also please see my note in #raku-dev | 17:19 | ||
| timo | sorry again | 17:20 | |
| your work is greatly appreciated | 17:22 | ||
| if you prefer, you can revert the merge, or I can do it | 17:23 | ||
| [Coke] | Just leave it | ||
| Thanks for the work on it. | 17:24 | ||
| timo | I hope it can benefit end users, GDBing moar can be frightening, but this can make some things a lot nicer | 17:27 | |
| [Coke]: where did you see the failed checks? for me it shows all green for the PR's checks | 17:48 | ||
| could be from the second-to-last commit where the checks were aborted because i pushed the next one soon after? | 17:52 | ||
| [Coke] | timo: checked again from the top level, it's fine, updated my comment. Thanks for the follouwp | 18:01 | |