|
Welcome to the main channel on the development of MoarVM, a virtual machine for NQP and Rakudo (moarvm.org). This channel is being logged for historical purposes. Set by lizmat on 24 May 2021. |
|||
|
01:30
nine left,
nine joined
08:26
sena_kun joined
08:59
kjp_ left
09:01
kjp joined
|
|||
| nine | patrickb: github.com/MoarVM/MoarVM/pull/1782 seems to still counteract the consensus from the problem-solving ticket? | 10:54 | |
| patrickb | nine: That PR is mostly unrelated to the problem-solving issue. | 10:55 | |
| That PR solves a problem where any &return irrelevant how deep down the call stack inside A LEAVE phaser will overwrite the return value of the &return that originally caused the stack unwind. | 10:57 | ||
| The tests in roast#851 actually depend on three PRs, the one you linked included. | 11:01 | ||
| linkable6 | ROAST#851 [open]: github.com/Raku/roast/pull/851 Test return prioritization | ||
|
11:29
lizmat_ joined
11:33
lizmat left
12:05
lizmat_ left
12:06
lizmat joined
15:35
Geth left,
Geth joined
|
|||
| Geth | MoarVM/main: d67da80f39 | (Elizabeth Mattijsen)++ | src/core/frame.c Revert "Don't lose return value with LEAVE phasers" This reverts commit f8e7173226ce49f192fcd39f8dce1f63e1737f22. Way too close to the release, and just after a blin run. Sorry. Will re-apply after the 2024.05 release |
15:38 | |
| lizmat | patrickb ^^ | ||
| patrickb | nine: Thanks for taking the time to review my PRs! (I'll try to return the favor and also review a few PRs not authored by me.) | 15:50 | |
| lizmat: I'm curious if I / we manage to get those merged in 2024.06. :-) | 15:52 | ||
| lizmat | this one was approved by nine: that's good enough in my book (at the start of a release cycle) | 15:53 | |
| nine | patrickb: sorry for the wrong delay. I'd have reviewed those earlier if I had realized that the whole thing is a bunch of somewhat independent issues | 16:30 | |
|
18:34
sena_kun left,
sena_kun joined
21:24
nine left,
nine joined
22:04
sena_kun left
|
|||