|
09:05
apogee_ntv left
09:06
apogee_ntv joined
|
|||
| Geth | MoarVM/pending-object-repossession: 2d078bbc54 | (Elizabeth Mattijsen)++ | 3 files Install pending object repossession target in demand_object MVM_serialization_deserialize queues every repossessed STable for body deserialization and then runs the object repossession loop. Inside that loop, resolving a row's updated STable through read_object_table_entry can demand one of the compilation unit's own STables, which enters the work loop and deserializes the queued STable bodies. Deserializing an ... (55 more lines) |
09:18 | |
| MoarVM: lizmat++ created pull request #2046: Install pending object repossession target in demand_object |
09:19 | ||
| MoarVM/main: a6b33639c7 | (Elizabeth Mattijsen)++ (committed using GitHub Web editor) | 3 files Install pending object repossession target in demand_object MVM_serialization_deserialize queues every repossessed STable for body deserialization and then runs the object repossession loop. Inside that loop, resolving a row's updated STable through read_object_table_entry can demand one of the compilation unit's own STables, which enters the work loop and deserializes the queued STable bodies. Deserializing an ... (55 more lines) |
10:20 | ||
|
13:34
bisectable6 left,
quotable6 left,
bloatable6 left,
committable6 left,
coverable6 left,
notable6 left,
shareable6 left,
tellable6 left,
unicodable6 left,
evalable6 left,
sourceable6 left,
huggable6 left,
greppable6 left,
releasable6 left,
linkable6 left,
benchable6 left,
nativecallable6 left
13:39
bloatable6 joined,
releasable6 joined,
bisectable6 joined,
benchable6 joined,
linkable6 joined
13:40
committable6 joined,
notable6 joined,
sourceable6 joined
13:41
evalable6 joined,
quotable6 joined,
greppable6 joined,
shareable6 joined,
unicodable6 joined,
nativecallable6 joined
13:42
huggable6 joined,
tellable6 joined,
coverable6 joined
|
|||
| [Coke] | I am not a fan of commits being faux-cherry picked from an outside repository | 16:46 | |
| I would rather the commit had gone in with ugexe as the author via a pull request so it could have gone through CI, etc. | |||
| (rather than relying on the CI running on main) | |||
| I did this for a previous ugexe commit, where I cloned his repo, added ours as an upstream, pushed his branch to our repo, and then made a PR out of that new branch. | 16:47 | ||
| (I see this was done via a PR as well, so that gets us the CI, but does not get the author information correct) | 16:50 | ||
| lizmat | The reason it happened this way, is that ugexe at least appeared to be unwilling to make a PR | 17:58 | |
| irclogs.raku.org/raku-dev/gist.htm...9-21Z23:48 | 18:00 | ||
| please note that github.com/MoarVM/MoarVM/commit/2d078bbc54 states at the end: | |||
| Taken from: | 18:01 | ||
| ugexe@cb4feec | |||
| [Coke] | we can pull the branch in as is, then create a pr in moarvm/moarvm ourselves from that. | 18:03 | |
| (that's how I tested that originally) (that branch is probably still around) | 18:04 | ||
| Just for next time. | |||
| no worries about changing this one. | |||
| lizmat | well, I guess my git foo was insufficient to do what you suggested | ||
| also, I find that just copying the code from a PR manually, helps in understanding the PR significantly | 18:05 | ||
| it's a forced slow way of looking at the code, works for me | |||
| apogee_ntv | I will try to look at that prefix topic setter issue properly once I get Selkie 0.99 out, that's taking most of the hours I have in the day at the moment. | 22:51 | |
| postfix* | |||