pmurias when do we increament the MoarVM serialization format version? 08:53
* increment 08:54
JimmyZ normally: see github.com/MoarVM/MoarVM/commit/cd...f5f0574091 09:02
pmurias: this one really github.com/MoarVM/MoarVM/commit/6e...197765e859 09:03
pmurias: it added codes like : if (reader->root.version >= 19) 09:04
pmurias JimmyZ: I didn't add a check because I added a flag 10:04
JimmyZ: if we are deserializing something serialized by version 19 the flag will be set to 0 10:05
if version 20 serializes an object with a set hll role, and version 19 gets attempts to serialize it, version 19 will ignore the new flag it doesn't know about and things will fail with a weird error 10:06
a hll role could be set before my commit, it was just not serialized 10:07
JimmyZ pmurias: according your commit, if it didn't write it, then it won't read 13:04